From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: John Hubbard <jhubbard@nvidia.com>, Shuah Khan <shuah@kernel.org>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>,
SeongJae Park <sj@kernel.org>,
Valentin Obst <kernel@valentinobst.de>,
linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev
Subject: Re: [PATCH v2] selftests/mqueue: fix 5 warnings about signed/unsigned mismatches
Date: Fri, 10 May 2024 16:41:08 +0500 [thread overview]
Message-ID: <17a9be15-5e4f-4aed-a2b1-b3aa2defbfc9@collabora.com> (raw)
In-Reply-To: <20240508200028.272513-1-jhubbard@nvidia.com>
On 5/9/24 1:00 AM, John Hubbard wrote:
> When building with clang, via:
>
> make LLVM=1 -C tools/testing/selftest
>
> ...clang warns about several cases of using a signed integer for the
> priority argument to mq_receive(3), which expects an unsigned int.
>
> Fix this by declaring the type as unsigned int in all cases.
>
> Also, both input and output priority are unsigned, per the man pages, so
> let's change the type of both priorities throughout, even though clang
> did not warn about the prio_out variable.
>
> Also, add an argument name to test->func(), in order to address another
> warning from clang.
>
> Cc: Ryan Roberts <ryan.roberts@arm.com>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
LGTM
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> tools/testing/selftests/mqueue/mq_perf_tests.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/tools/testing/selftests/mqueue/mq_perf_tests.c b/tools/testing/selftests/mqueue/mq_perf_tests.c
> index 5c16159d0bcd..9380c656581f 100644
> --- a/tools/testing/selftests/mqueue/mq_perf_tests.c
> +++ b/tools/testing/selftests/mqueue/mq_perf_tests.c
> @@ -323,7 +323,8 @@ void *fake_cont_thread(void *arg)
> void *cont_thread(void *arg)
> {
> char buff[MSG_SIZE];
> - int i, priority;
> + int i;
> + unsigned int priority;
>
> for (i = 0; i < num_cpus_to_pin; i++)
> if (cpu_threads[i] == pthread_self())
> @@ -373,27 +374,27 @@ void *cont_thread(void *arg)
>
> struct test {
> char *desc;
> - void (*func)(int *);
> + void (*func)(unsigned int *prio);
> };
>
> -void const_prio(int *prio)
> +void const_prio(unsigned int *prio)
> {
> return;
> }
>
> -void inc_prio(int *prio)
> +void inc_prio(unsigned int *prio)
> {
> if (++*prio == mq_prio_max)
> *prio = 0;
> }
>
> -void dec_prio(int *prio)
> +void dec_prio(unsigned int *prio)
> {
> if (--*prio < 0)
> *prio = mq_prio_max - 1;
> }
>
> -void random_prio(int *prio)
> +void random_prio(unsigned int *prio)
> {
> *prio = random() % mq_prio_max;
> }
> @@ -425,7 +426,7 @@ struct test test2[] = {
> void *perf_test_thread(void *arg)
> {
> char buff[MSG_SIZE];
> - int prio_out, prio_in;
> + unsigned int prio_out, prio_in;
> int i;
> clockid_t clock;
> pthread_t *t;
>
> base-commit: 45db3ab70092637967967bfd8e6144017638563c
> prerequisite-patch-id: b901ece2a5b78503e2fb5480f20e304d36a0ea27
--
BR,
Muhammad Usama Anjum
prev parent reply other threads:[~2024-05-10 11:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 20:00 [PATCH v2] selftests/mqueue: fix 5 warnings about signed/unsigned mismatches John Hubbard
2024-05-09 12:42 ` Ryan Roberts
2024-05-10 11:41 ` Muhammad Usama Anjum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17a9be15-5e4f-4aed-a2b1-b3aa2defbfc9@collabora.com \
--to=usama.anjum@collabora.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).