From: Simon Horman <horms@kernel.org>
To: Benjamin Poirier <benjamin.poirier@gmail.com>
Cc: Aaron Conole <aconole@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
dev@openvswitch.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, Jiri Pirko <jiri@resnulli.us>
Subject: Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements
Date: Thu, 25 Apr 2024 08:33:17 +0100 [thread overview]
Message-ID: <20240425073317.GS42092@kernel.org> (raw)
In-Reply-To: <ZilIgbIvB04iUal2@f4>
On Wed, Apr 24, 2024 at 01:59:29PM -0400, Benjamin Poirier wrote:
> On 2024-04-24 18:37 +0100, Simon Horman wrote:
> > On Wed, Apr 24, 2024 at 05:44:05PM +0100, Simon Horman wrote:
> > > Hi Aaron, Jakub, all,
> > >
> > > I have recently been exercising the Open vSwitch kernel selftests,
> > > using vng, something like this:
> > >
> > > TESTDIR="tools/testing/selftests/net/openvswitch"
> > >
> > > vng -v --run . --user root --cpus 2 \
> > > --overlay-rwdir "$PWD" -- \
> > > "modprobe openvswitch && \
> > > echo \"timeout=90\" >> \"${TESTDIR}/settings\" && \
> > > make -C \"$TESTDIR\" run_tests"
> > >
> > > And I have some observations that I'd like to ask about.
> > >
> > > 1. Building the kernel using the following command does not
> > > build the openvswitch kernel module.
> > >
> > > vng -v --build \
> > > --config tools/testing/selftests/net/config
> > >
> > > All that seems to be missing is CONFIG_OPENVSWITCH=m
> > > and I am wondering what the best way of resolving this is.
> > >
> > > Perhaps I am doing something wrong.
> > > Or perhaps tools/testing/selftests/net/openvswitch/config
> > > should be created? If so, should it include (most of?) what is in
> > > tools/testing/selftests/net/config, or just CONFIG_OPENVSWITCH=m?
>
> I noticed something similar when testing Jiri's virtio_net selftests
> patchset [1].
>
> drivers/net/virtio_net/config includes virtio options but the
> test also needs at least CONFIG_NET_VRF=y which is part of net/config.
>
> Whatever the answer to your question, all config files should be
> coherent on this matter.
Yes, agreed. That is the main reason I'm asking about this.
> [1] https://lore.kernel.org/netdev/20240424104049.3935572-1-jiri@resnulli.us/
>
> [...]
> >
> > 5. openvswitch.sh starts with "#!/bin/sh".
> > But substitutions such as "${ns:0:1}0" fail if /bin/sh is dash.
> > Perhaps we should change openvswitch.sh to use bash?
>
> I think so. A similar change was done in
> c2518da8e6b0 selftests: bonding: Change script interpreter (v6.8-rc1)
Thanks, this one seems straightforward.
next prev parent reply other threads:[~2024-04-25 7:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 16:44 selftests: openvswitch: Questions about possible enhancements Simon Horman
2024-04-24 17:37 ` [ovs-dev] " Simon Horman
2024-04-24 17:59 ` Benjamin Poirier
2024-04-24 18:14 ` Aaron Conole
2024-04-25 7:33 ` Simon Horman [this message]
2024-04-24 18:14 ` Aaron Conole
2024-04-25 7:40 ` Simon Horman
2024-04-25 20:00 ` Aaron Conole
2024-04-25 0:30 ` Jakub Kicinski
2024-04-25 8:26 ` Simon Horman
2024-04-25 18:57 ` [ovs-dev] " Simon Horman
2024-04-25 19:21 ` Jakub Kicinski
2024-04-25 20:04 ` Aaron Conole
2024-04-26 7:05 ` Simon Horman
2024-04-25 19:58 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425073317.GS42092@kernel.org \
--to=horms@kernel.org \
--cc=aconole@redhat.com \
--cc=benjamin.poirier@gmail.com \
--cc=dev@openvswitch.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).