From: Christian Brauner <brauner@kernel.org>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: "Jakub Kicinski" <kuba@kernel.org>,
"Kees Cook" <keescook@chromium.org>,
"Mark Brown" <broonie@kernel.org>,
"Shengyu Li" <shengyu.li.evgeny@gmail.com>,
"Shuah Khan" <shuah@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"Günther Noack" <gnoack@google.com>,
"Will Drewry" <wad@chromium.org>,
"kernel test robot" <oliver.sang@intel.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
"Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3 7/9] selftests/pidfd: Fix wrong expectation
Date: Thu, 2 May 2024 16:12:28 +0200 [thread overview]
Message-ID: <20240502-leiden-wegnehmen-9ac8f35c7204@brauner> (raw)
In-Reply-To: <20240429191911.2552580-8-mic@digikod.net>
On Mon, Apr 29, 2024 at 09:19:09PM +0200, Mickaël Salaün wrote:
> Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(),
> which will be actually tested on the parent and child sides with a
> following commit.
>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> Link: https://lore.kernel.org/r/20240429191911.2552580-8-mic@digikod.net
> ---
Looks good to me,
Reviewed-by: Christian Brauner <brauner@kernel.org>
next prev parent reply other threads:[~2024-05-02 14:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 19:19 [PATCH v3 0/9] Fix Kselftest's vfork() side effects Mickaël Salaün
2024-04-29 19:19 ` [PATCH v3 1/9] selftests/pidfd: Fix config for pidfd_setns_test Mickaël Salaün
2024-05-02 14:10 ` Christian Brauner
2024-04-29 19:19 ` [PATCH v3 2/9] selftests/landlock: Fix FS tests when run on a private mount point Mickaël Salaün
2024-04-29 19:19 ` [PATCH v3 3/9] selftests/harness: Fix fixture teardown Mickaël Salaün
2024-04-29 19:19 ` [PATCH v3 4/9] selftests/harness: Fix interleaved scheduling leading to race conditions Mickaël Salaün
2024-04-29 19:19 ` [PATCH v3 5/9] selftests/landlock: Do not allocate memory in fixture data Mickaël Salaün
2024-04-29 19:19 ` [PATCH v3 6/9] selftests/harness: Constify fixture variants Mickaël Salaün
2024-04-29 19:19 ` [PATCH v3 7/9] selftests/pidfd: Fix wrong expectation Mickaël Salaün
2024-05-02 14:12 ` Christian Brauner [this message]
2024-04-29 19:19 ` [PATCH v3 8/9] selftests/harness: Share _metadata between forked processes Mickaël Salaün
2024-04-29 19:19 ` [PATCH v3 9/9] selftests/harness: Fix vfork() side effects Mickaël Salaün
2024-04-30 13:54 ` [PATCH v3 0/9] Fix Kselftest's " Mickaël Salaün
2024-04-30 15:13 ` Jakub Kicinski
2024-04-30 16:38 ` Mickaël Salaün
2024-04-30 16:50 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240502-leiden-wegnehmen-9ac8f35c7204@brauner \
--to=brauner@kernel.org \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=gnoack@google.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mic@digikod.net \
--cc=oliver.sang@intel.com \
--cc=shengyu.li.evgeny@gmail.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).