From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Amer Al Shanawany <amer.shanawany@gmail.com>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Javier Carrasco <javier.carrasco.cruz@gmail.com>,
Shuah Khan <shuah@kernel.org>,
Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
Subject: Re: [PATCH] selftests/capabilities: fix warn_unused_result build warnings
Date: Mon, 6 May 2024 09:52:13 +0500 [thread overview]
Message-ID: <4d565066-5e4a-48fb-a0dc-17c4380ccd65@collabora.com> (raw)
In-Reply-To: <20240504170916.131580-1-amer.shanawany@gmail.com>
Thanks for the patch!
On 5/4/24 10:09 PM, Amer Al Shanawany wrote:
> Fix the following warnings by adding return check and error handling.
>
> test_execve.c: In function ‘do_tests’:
> test_execve.c:100:17: warning: ignoring return value of
> ‘capng_get_caps_process’
> declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 100 | capng_get_caps_process();
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> validate_cap.c: In function ‘main’:
> validate_cap.c:47:9: warning: ignoring return value of
> ‘capng_get_caps_process’
> declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 47 | capng_get_caps_process();
> | ^~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Amer Al Shanawany <amer.shanawany@gmail.com>
LGTM
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> tools/testing/selftests/capabilities/test_execve.c | 12 +++++++++---
> tools/testing/selftests/capabilities/validate_cap.c | 7 ++++++-
> 2 files changed, 15 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/capabilities/test_execve.c b/tools/testing/selftests/capabilities/test_execve.c
> index 7cde07a5df78..47bad7ddc5bc 100644
> --- a/tools/testing/selftests/capabilities/test_execve.c
> +++ b/tools/testing/selftests/capabilities/test_execve.c
> @@ -82,7 +82,7 @@ static bool create_and_enter_ns(uid_t inner_uid)
> {
> uid_t outer_uid;
> gid_t outer_gid;
> - int i;
> + int i, ret;
> bool have_outer_privilege;
>
> outer_uid = getuid();
> @@ -97,7 +97,10 @@ static bool create_and_enter_ns(uid_t inner_uid)
> ksft_exit_fail_msg("setresuid - %s\n", strerror(errno));
>
> // Re-enable effective caps
> - capng_get_caps_process();
> + ret = capng_get_caps_process();
> + if (ret == -1)
> + ksft_exit_fail_msg("capng_get_caps_process failed\n");
> +
> for (i = 0; i < CAP_LAST_CAP; i++)
> if (capng_have_capability(CAPNG_PERMITTED, i))
> capng_update(CAPNG_ADD, CAPNG_EFFECTIVE, i);
> @@ -207,6 +210,7 @@ static void exec_validate_cap(bool eff, bool perm, bool inh, bool ambient)
>
> static int do_tests(int uid, const char *our_path)
> {
> + int ret;
> bool have_outer_privilege = create_and_enter_ns(uid);
>
> int ourpath_fd = open(our_path, O_RDONLY | O_DIRECTORY);
> @@ -250,7 +254,9 @@ static int do_tests(int uid, const char *our_path)
> ksft_exit_fail_msg("chmod - %s\n", strerror(errno));
> }
>
> - capng_get_caps_process();
> + ret = capng_get_caps_process();
> + if (ret == -1)
> + ksft_exit_fail_msg("capng_get_caps_process failed\n");
>
> /* Make sure that i starts out clear */
> capng_update(CAPNG_DROP, CAPNG_INHERITABLE, CAP_NET_BIND_SERVICE);
> diff --git a/tools/testing/selftests/capabilities/validate_cap.c b/tools/testing/selftests/capabilities/validate_cap.c
> index 60b4e7b716a7..65f2a1c89239 100644
> --- a/tools/testing/selftests/capabilities/validate_cap.c
> +++ b/tools/testing/selftests/capabilities/validate_cap.c
> @@ -28,6 +28,7 @@ static bool bool_arg(char **argv, int i)
> int main(int argc, char **argv)
> {
> const char *atsec = "";
> + int ret;
>
> /*
> * Be careful just in case a setgid or setcapped copy of this
> @@ -44,7 +45,11 @@ int main(int argc, char **argv)
> atsec = " (AT_SECURE is not set)";
> #endif
>
> - capng_get_caps_process();
> + ret = capng_get_caps_process();
> + if (ret == -1) {
> + ksft_print_msg("capng_get_caps_process failed\n");
> + return 1;
> + }
>
> if (capng_have_capability(CAPNG_EFFECTIVE, CAP_NET_BIND_SERVICE) != bool_arg(argv, 1)) {
> ksft_print_msg("Wrong effective state%s\n", atsec);
--
BR,
Muhammad Usama Anjum
prev parent reply other threads:[~2024-05-06 4:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 17:09 [PATCH] selftests/capabilities: fix warn_unused_result build warnings Amer Al Shanawany
2024-05-06 4:52 ` Muhammad Usama Anjum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d565066-5e4a-48fb-a0dc-17c4380ccd65@collabora.com \
--to=usama.anjum@collabora.com \
--cc=amer.shanawany@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=swarupkotikalapudi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).