From: "Moger, Babu" <babu.moger@amd.com>
To: "Reinette Chatre" <reinette.chatre@intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: fenghua.yu@intel.com, shuah@kernel.org,
LKML <linux-kernel@vger.kernel.org>,
linux-kselftest@vger.kernel.org,
"Maciej Wieczór-Retman" <maciej.wieczor-retman@intel.com>,
peternewman@google.com, eranian@google.com
Subject: Re: [PATCH 3/4] selftests/resctrl: Add support for MBM and MBA tests on AMD
Date: Mon, 26 Feb 2024 12:02:33 -0600 [thread overview]
Message-ID: <62200490-6dcb-4c35-b358-b9c63e580787@amd.com> (raw)
In-Reply-To: <9f814712-7189-424b-9af2-67f565dc35f2@intel.com>
Hi Reinette
On 2/23/24 16:39, Reinette Chatre wrote:
> Hi Babu,
>
> On 2/23/2024 11:47 AM, Moger, Babu wrote:
>> On 2/23/24 13:30, Moger, Babu wrote:
>>> On 2/23/24 04:53, Ilpo Järvinen wrote:
>>>> On Thu, 22 Feb 2024, Babu Moger wrote:
>>>>> @@ -131,8 +130,7 @@ static void run_mba_test(const char * const *benchmark_cmd, int cpu_no)
>>>>> }
>>>>>
>>>>> if (!validate_resctrl_feature_request("MB", NULL) ||
>>>>> - !validate_resctrl_feature_request("L3_MON", "mbm_local_bytes") ||
>>>>> - (get_vendor() != ARCH_INTEL)) {
>>>>> + !validate_resctrl_feature_request("L3_MON", "mbm_local_bytes")) {
>>>>> ksft_test_result_skip("Hardware does not support MBA or MBA is disabled\n");
>>>>> goto cleanup;
>>>>> }
>>>>
>>>> These need to be rebased as this code moved into per test files with the
>>>> generic test framework. The .vendor_specific field is the new way to make
>>>> tests limited to particular vendors.
>>>
>>> Hmm. I picked the latest code from tip/master. Where is the latest code
>>> now? Is it yet to be submitted?
>>>
>>> I can wait for your code to merge first.
>>
>> Oh. ok. Here it is
>> https://lore.kernel.org/lkml/cover.1708072203.git.maciej.wieczor-retman@intel.com/
>>
>> I will rebase it on top of this next revision.
>
> The resctrl selftest changes are routed through the kselftest repo. Shuah just picked
> up this series you noticed but it is based on the framework changes from Ilpo that
> is already merged. I recommend that you base your next series on the "next" branch
> of the kselftest repo [1].
Sure. Will do.
>
> Reinette
>
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
--
Thanks
Babu Moger
next prev parent reply other threads:[~2024-02-26 18:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 21:35 [PATCH 0/4] selftests/resctrl: Enable MBM and MBA tests on AMD Babu Moger
2024-02-22 21:35 ` [PATCH 1/4] selftests/resctrl: Rename variable imcs and num_of_imcs() to generic names Babu Moger
2024-02-23 10:38 ` Ilpo Järvinen
2024-02-23 18:11 ` Moger, Babu
2024-02-22 21:35 ` [PATCH 2/4] selftests/resctrl: Pass sysfs controller name of the vendor Babu Moger
2024-02-22 21:35 ` [PATCH 3/4] selftests/resctrl: Add support for MBM and MBA tests on AMD Babu Moger
2024-02-23 10:53 ` Ilpo Järvinen
2024-02-23 19:30 ` Moger, Babu
2024-02-23 19:47 ` Moger, Babu
2024-02-23 22:39 ` Reinette Chatre
2024-02-26 18:02 ` Moger, Babu [this message]
2024-02-22 21:35 ` [PATCH 4/4] selftests/resctrl: Skip the tests if iMC/UMC counters are unavailable Babu Moger
2024-02-23 10:56 ` Ilpo Järvinen
2024-02-23 19:39 ` Moger, Babu
2024-04-25 20:16 ` [PATCH v2 0/4] selftests/resctrl: Enable MBM and MBA tests on AMD Babu Moger
2024-04-25 20:16 ` [PATCH v2 1/4] selftests/resctrl: Rename variable imcs and num_of_imcs() to generic names Babu Moger
2024-05-09 21:10 ` Reinette Chatre
2024-05-30 16:07 ` Moger, Babu
2024-04-25 20:17 ` [PATCH v2 2/4] selftests/resctrl: Pass sysfs controller name of the vendor Babu Moger
2024-05-09 21:11 ` Reinette Chatre
2024-05-30 16:08 ` Moger, Babu
2024-04-25 20:17 ` [PATCH v2 3/4] selftests/resctrl: Add support for MBM and MBA tests on AMD Babu Moger
2024-05-09 21:11 ` Reinette Chatre
2024-05-30 16:08 ` Moger, Babu
2024-04-25 20:17 ` [PATCH v2 4/4] selftests/resctrl: Enable MBA/MBA " Babu Moger
2024-04-26 7:06 ` Ilpo Järvinen
2024-04-26 14:56 ` Moger, Babu
2024-05-09 21:11 ` Reinette Chatre
2024-05-30 16:08 ` Moger, Babu
2024-05-09 21:10 ` [PATCH v2 0/4] selftests/resctrl: Enable MBM and MBA " Reinette Chatre
2024-05-30 16:07 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62200490-6dcb-4c35-b358-b9c63e580787@amd.com \
--to=babu.moger@amd.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=peternewman@google.com \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).