From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
Jakub Kicinski <kuba@kernel.org>,
shuah@kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] selftests: net: increase the delay for relative cmsg_time.sh test
Date: Thu, 09 May 2024 22:25:33 -0400 [thread overview]
Message-ID: <663d859d60010_13d89429497@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20240510005705.43069-2-kuba@kernel.org>
Jakub Kicinski wrote:
> Slow machines can delay scheduling of the packets for milliseconds.
> Increase the delay to 8ms if KSFT_MACHINE_SLOW. Try to limit the
> variability by moving setsockopts earlier (before we read time).
>
> This fixes the "TXTIME rel" failures on debug kernels, like:
>
> Case ICMPv4 - TXTIME rel returned '', expected 'OK'
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Willem de Bruijn <willemb@google.com>
next prev parent reply other threads:[~2024-05-10 2:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 0:57 [PATCH net-next 1/2] selftests: net: fix timestamp not arriving in cmsg_time.sh Jakub Kicinski
2024-05-10 0:57 ` [PATCH net-next 2/2] selftests: net: increase the delay for relative cmsg_time.sh test Jakub Kicinski
2024-05-10 2:25 ` Willem de Bruijn [this message]
2024-05-10 2:49 ` [PATCH net-next 1/2] selftests: net: fix timestamp not arriving in cmsg_time.sh Willem de Bruijn
2024-05-11 1:23 ` Jakub Kicinski
2024-05-11 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=663d859d60010_13d89429497@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).