* [PATCH] Documentation: kunit: correct KUNIT_VERY_SLOW to KUNIT_SPEED_VERY_SLOW
@ 2024-03-20 17:14 Kemeng Shi
2024-03-22 4:12 ` David Gow
0 siblings, 1 reply; 3+ messages in thread
From: Kemeng Shi @ 2024-03-20 17:14 UTC (permalink / raw
To: brendan.higgins, davidgow, rmoar, corbet
Cc: linux-kselftest, kunit-dev, linux-doc, linux-kernel
There is no KUNIT_VERY_SLOW, I guess we mean KUNIT_SPEED_VERY_SLOW.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
Documentation/dev-tools/kunit/running_tips.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/dev-tools/kunit/running_tips.rst b/Documentation/dev-tools/kunit/running_tips.rst
index bd689db6fdd2..482f598d141c 100644
--- a/Documentation/dev-tools/kunit/running_tips.rst
+++ b/Documentation/dev-tools/kunit/running_tips.rst
@@ -294,7 +294,7 @@ macro to define the test case instead of ``KUNIT_CASE(test_name)``.
.. code-block:: c
static const struct kunit_attributes example_attr = {
- .speed = KUNIT_VERY_SLOW,
+ .speed = KUNIT_SPEED_VERY_SLOW,
};
static struct kunit_case example_test_cases[] = {
@@ -311,7 +311,7 @@ suite definition.
.. code-block:: c
static const struct kunit_attributes example_attr = {
- .speed = KUNIT_VERY_SLOW,
+ .speed = KUNIT_SPEED_VERY_SLOW,
};
static struct kunit_suite example_test_suite = {
--
2.30.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: kunit: correct KUNIT_VERY_SLOW to KUNIT_SPEED_VERY_SLOW
2024-03-20 17:14 [PATCH] Documentation: kunit: correct KUNIT_VERY_SLOW to KUNIT_SPEED_VERY_SLOW Kemeng Shi
@ 2024-03-22 4:12 ` David Gow
2024-04-02 16:15 ` Jonathan Corbet
0 siblings, 1 reply; 3+ messages in thread
From: David Gow @ 2024-03-22 4:12 UTC (permalink / raw
To: Kemeng Shi
Cc: brendan.higgins, rmoar, corbet, linux-kselftest, kunit-dev,
linux-doc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1701 bytes --]
On Wed, 20 Mar 2024 at 16:18, Kemeng Shi <shikemeng@huaweicloud.com> wrote:
>
> There is no KUNIT_VERY_SLOW, I guess we mean KUNIT_SPEED_VERY_SLOW.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
> ---
Nice catch, thanks!
Reviewed-by: David Gow <davidgow@google.com>
Cheers,
-- David
> Documentation/dev-tools/kunit/running_tips.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/dev-tools/kunit/running_tips.rst b/Documentation/dev-tools/kunit/running_tips.rst
> index bd689db6fdd2..482f598d141c 100644
> --- a/Documentation/dev-tools/kunit/running_tips.rst
> +++ b/Documentation/dev-tools/kunit/running_tips.rst
> @@ -294,7 +294,7 @@ macro to define the test case instead of ``KUNIT_CASE(test_name)``.
> .. code-block:: c
>
> static const struct kunit_attributes example_attr = {
> - .speed = KUNIT_VERY_SLOW,
> + .speed = KUNIT_SPEED_VERY_SLOW,
> };
>
> static struct kunit_case example_test_cases[] = {
> @@ -311,7 +311,7 @@ suite definition.
> .. code-block:: c
>
> static const struct kunit_attributes example_attr = {
> - .speed = KUNIT_VERY_SLOW,
> + .speed = KUNIT_SPEED_VERY_SLOW,
> };
>
> static struct kunit_suite example_test_suite = {
> --
> 2.30.0
>
> --
> You received this message because you are subscribed to the Google Groups "KUnit Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kunit-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kunit-dev/20240320171424.6536-1-shikemeng%40huaweicloud.com.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4014 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: kunit: correct KUNIT_VERY_SLOW to KUNIT_SPEED_VERY_SLOW
2024-03-22 4:12 ` David Gow
@ 2024-04-02 16:15 ` Jonathan Corbet
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2024-04-02 16:15 UTC (permalink / raw
To: David Gow, Kemeng Shi
Cc: brendan.higgins, rmoar, linux-kselftest, kunit-dev, linux-doc,
linux-kernel
David Gow <davidgow@google.com> writes:
> On Wed, 20 Mar 2024 at 16:18, Kemeng Shi <shikemeng@huaweicloud.com> wrote:
>>
>> There is no KUNIT_VERY_SLOW, I guess we mean KUNIT_SPEED_VERY_SLOW.
>>
>> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
>> ---
>
> Nice catch, thanks!
>
> Reviewed-by: David Gow <davidgow@google.com>
Let me know if you'd like me to pick this up; otherwise I'm assuming it
will go via the kunit path.
Thanks,
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-02 16:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-20 17:14 [PATCH] Documentation: kunit: correct KUNIT_VERY_SLOW to KUNIT_SPEED_VERY_SLOW Kemeng Shi
2024-03-22 4:12 ` David Gow
2024-04-02 16:15 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).