From: Scott Mayhew <smayhew@redhat.com>
To: David Gow <davidgow@google.com>
Cc: brendanhiggins@google.com, rmoar@google.com, npache@redhat.com,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH] kunit: bail out early in __kunit_test_suites_init() if there are no suites to test
Date: Tue, 30 Apr 2024 09:58:08 -0400 [thread overview]
Message-ID: <ZjD48CpjXPsmjU5c@aion> (raw)
In-Reply-To: <CABVgOSmDJpU7km5em_WbY1A04f+AF74a8_4GccjrJk1nW+1Fww@mail.gmail.com>
On Sat, 23 Mar 2024, David Gow wrote:
> On Thu, 21 Mar 2024 at 22:32, Scott Mayhew <smayhew@redhat.com> wrote:
> >
> > Commit c72a870926c2 added a mutex to prevent kunit tests from running
> > concurrently. Unfortunately that mutex gets locked during module load
> > regardless of whether the module actually has any kunit tests. This
> > causes a problem for kunit tests that might need to load other kernel
> > modules (e.g. gss_krb5_test loading the camellia module).
> >
> > So check to see if there are actually any tests to run before locking
> > the kunit_run_lock mutex.
> >
> > Fixes: c72a870926c2 ("kunit: add ability to run tests after boot using debugfs")
> > Reported-by: Nico Pache <npache@redhat.com>
> > Signed-off-by: Scott Mayhew <smayhew@redhat.com>
> > ---
>
> Thanks, this works well here, and is a good idea anyway.
>
> Reviewed-by: David Gow <davidgow@google.com>
>
Brendan, David,
Is there a reason this patch hasn't been merged?
-Scott
> Cheers,
> -- David
>
> > lib/kunit/test.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/lib/kunit/test.c b/lib/kunit/test.c
> > index 1d1475578515..b8514dbb337c 100644
> > --- a/lib/kunit/test.c
> > +++ b/lib/kunit/test.c
> > @@ -712,6 +712,9 @@ int __kunit_test_suites_init(struct kunit_suite * const * const suites, int num_
> > {
> > unsigned int i;
> >
> > + if (num_suites == 0)
> > + return 0;
> > +
> > if (!kunit_enabled() && num_suites > 0) {
> > pr_info("kunit: disabled\n");
> > return 0;
> > --
> > 2.43.0
> >
next prev parent reply other threads:[~2024-04-30 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAA1CXcBqcyXma1kGwvfAQ5T24dmuH_Or9RPrVqxDoVq=N4Se3w@mail.gmail.com>
2024-03-21 14:32 ` [PATCH] kunit: bail out early in __kunit_test_suites_init() if there are no suites to test Scott Mayhew
2024-03-21 23:22 ` Rae Moar
2024-03-23 5:24 ` David Gow
2024-04-30 13:58 ` Scott Mayhew [this message]
2024-05-02 0:01 ` David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjD48CpjXPsmjU5c@aion \
--to=smayhew@redhat.com \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=npache@redhat.com \
--cc=rmoar@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).