From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Edward Liaw <edliaw@google.com>
Cc: linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kselftest@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH] selftests/kcmp: Remove unused open mode
Date: Tue, 30 Apr 2024 20:47:58 +0300 [thread overview]
Message-ID: <ZjEuzoUMX1S19QGb@grain> (raw)
In-Reply-To: <20240429234610.191144-1-edliaw@google.com>
On Mon, Apr 29, 2024 at 11:46:09PM +0000, Edward Liaw wrote:
> Android bionic warns that open modes are ignored if O_CREAT or O_TMPFILE
> aren't specified. The permissions for the file are set above:
>
> fd1 = open(kpath, O_RDWR | O_CREAT | O_TRUNC, 0644);
>
> Fixes: d97b46a64674 ("syscalls, x86: add __NR_kcmp syscall")
> Signed-off-by: Edward Liaw <edliaw@google.com>
Thanks!
Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>
prev parent reply other threads:[~2024-04-30 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 23:46 [PATCH] selftests/kcmp: Remove unused open mode Edward Liaw
2024-04-30 17:47 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjEuzoUMX1S19QGb@grain \
--to=gorcunov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=edliaw@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).