From: John Hubbard <jhubbard@nvidia.com>
To: Ryan Roberts <ryan.roberts@arm.com>, Shuah Khan <shuah@kernel.org>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Maciej Wieczor-Retman" <maciej.wieczor-retman@intel.com>,
"Christian Brauner" <brauner@kernel.org>,
"Muhammad Usama Anjum" <usama.anjum@collabora.com>,
"Alexey Gladkov" <legion@kernel.org>,
"Valentin Obst" <kernel@valentinobst.de>,
linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev
Subject: Re: [PATCH 1/2] selftests/openat2: fix clang build failures: -static-libasan, LOCAL_HDRS
Date: Fri, 10 May 2024 11:22:16 -0700 [thread overview]
Message-ID: <b28e6bcb-dde2-4ac0-ac0d-dfddb42c4426@nvidia.com> (raw)
In-Reply-To: <f715719a-c835-496c-9e99-d249e5607a0b@nvidia.com>
On 5/10/24 10:56 AM, John Hubbard wrote:
> On 5/10/24 4:52 AM, Ryan Roberts wrote:
>> On 04/05/2024 05:43, John Hubbard wrote:
> ...
>> It just occured to me that the bug report I was fixing with my attempt
>> was
>> invoking make like this (see [1]):
>>
>> # tools/testing/selftests/fchmodat2$ make CC=clang
>> # tools/testing/selftests/openat2$ make CC=clang
>>
>> So LLVM is not set in this case. Perhaps my approach [2] (suggested by
>> Arnd) of
>> using cc-option is more robust? (cc-option is alredy used by other
>> selftests).
>>
>
> Yes, I think that would better handle the two cases: setting LLVM,
> and/or setting CC (!).
>
> For that, some nits, but only worth fussing over if the patch hasn't
> gone in yet, or if you're changing it for some other reason:
>
I just remembered it needs the LOCAL_HDRS approach as well. Did your
patch already go in? Should I fix up this one here to use cc-option,
or go with yours? Either way is fine with me.
thanks,
--
John Hubbard
NVIDIA
> In Make, the arguments to functions include *all* spaces, so it's good
> practice to not add spaces in most function calls, unless they are
> definitely desired.
>
> Also, you only ever want one of those $(CC) options, so saying so is a
> nice touch. Neither of these is a functional issue in [2], but you could
> do this on top of the patch (I'm only showing the openat2 case):
>
> diff --git a/tools/testing/selftests/openat2/Makefile
> b/tools/testing/selftests/openat2/Makefile
> index 02af9b6ca5eb..c894778874a5 100644
> --- a/tools/testing/selftests/openat2/Makefile
> +++ b/tools/testing/selftests/openat2/Makefile
> @@ -3,7 +3,7 @@
> include ../../../build/Build.include
>
> CFLAGS += -Wall -O2 -g -fsanitize=address -fsanitize=undefined
> -CFLAGS += $(call cc-option, -static-libasan) $(call cc-option,
> -static-libsan)
> +CFLAGS += $(call cc-option,-static-libasan,$(call
> cc-option,-static-libsan))
> TEST_GEN_PROGS := openat2_test resolve_test rename_attack_test
>
> include ../lib.mk
>
>
>>
>> [1] https://lore.kernel.org/all/202404141807.LgsqXPY5-lkp@intel.com/
>> [2]
>> https://lore.kernel.org/linux-kselftest/20240417160740.2019530-1-ryan.roberts@arm.com/
>>
>>
>>> +
>>> +LOCAL_HDRS += helpers.h
>>> +
>>> include ../lib.mk
>>> -$(TEST_GEN_PROGS): helpers.c helpers.h
>>> +$(TEST_GEN_PROGS): helpers.c
>>>
>>> base-commit: ddb4c3f25b7b95df3d6932db0b379d768a6ebdf7
>>> prerequisite-patch-id: b901ece2a5b78503e2fb5480f20e304d36a0ea27
>>
>
> thanks,
next prev parent reply other threads:[~2024-05-10 18:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 4:43 [PATCH 1/2] selftests/openat2: fix clang build failures: -static-libasan, LOCAL_HDRS John Hubbard
2024-05-04 4:43 ` [PATCH 2/2] selftests/fchmodat2: fix clang build failure due to -static-libasan John Hubbard
2024-05-07 7:45 ` [PATCH 1/2] selftests/openat2: fix clang build failures: -static-libasan, LOCAL_HDRS Ryan Roberts
2024-05-07 16:19 ` John Hubbard
2024-05-07 16:34 ` Ryan Roberts
2024-05-07 16:47 ` John Hubbard
2024-05-07 16:56 ` Ryan Roberts
2024-05-10 11:52 ` Ryan Roberts
2024-05-10 17:56 ` John Hubbard
2024-05-10 18:22 ` John Hubbard [this message]
2024-05-11 17:19 ` Ryan Roberts
2024-05-30 3:58 ` Muhammad Usama Anjum
2024-05-30 4:35 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b28e6bcb-dde2-4ac0-ac0d-dfddb42c4426@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kernel@valentinobst.de \
--cc=legion@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=maciej.wieczor-retman@intel.com \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).