From: John Hubbard <jhubbard@nvidia.com>
To: Shuah Khan <shuah@kernel.org>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Darren Hart" <dvhart@infradead.org>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"André Almeida" <andrealmeid@igalia.com>,
"Nysal Jan K . A" <nysal@linux.ibm.com>,
"Mark Brown" <broonie@kernel.org>,
"Valentin Obst" <kernel@valentinobst.de>,
linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev, "Edward Liaw" <edliaw@google.com>
Subject: Re: [PATCH 3/3] selftests/futex: pass _GNU_SOURCE without a value to the compiler
Date: Wed, 8 May 2024 14:05:22 -0700 [thread overview]
Message-ID: <dbca543e-224b-4fa5-ba23-37f4957ff79d@nvidia.com> (raw)
In-Reply-To: <20240503041843.99136-4-jhubbard@nvidia.com>
On 5/2/24 9:18 PM, John Hubbard wrote:
> It's slightly better to set _GNU_SOURCE in the source code, but if one
> must do it via the compiler invocation, then the best way to do so is
> this:
Hi Shuah, Edward and all,
This patch now seems to be obsolete, due to Edward Liaw's comprehensive
fix, "[PATCH v2 0/5] Define _GNU_SOURCE for sources using" [1].
[1] https://lore.kernel.org/20240507214254.2787305-1-edliaw@google.com
A process question for Shuah: shall I gather up the selftest patches
that have reviews and acks, and post them with the versions incremented?
I'm new to this list, and I'm not sure of your exact workflow. And there
are admittedly a flurry of patches involved.
[1] https://lore.kernel.org/20240507214254.2787305-1-edliaw@google.com
thanks,
--
John Hubbard
NVIDIA
>
> $(CC) -D_GNU_SOURCE=
>
> ...because otherwise, if this form is used:
>
> $(CC) -D_GNU_SOURCE
>
> ...then that leads the compiler to set a value, as if you had passed in:
>
> $(CC) -D_GNU_SOURCE=1
>
> That, in turn, leads to warnings under both gcc and clang, like this:
>
> futex_requeue_pi.c:20: warning: "_GNU_SOURCE" redefined
>
> Fix this by using the "-D_GNU_SOURCE=" form.
>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
> tools/testing/selftests/futex/functional/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/futex/functional/Makefile b/tools/testing/selftests/futex/functional/Makefile
> index a392d0917b4e..994fa3468f17 100644
> --- a/tools/testing/selftests/futex/functional/Makefile
> +++ b/tools/testing/selftests/futex/functional/Makefile
> @@ -1,6 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0
> INCLUDES := -I../include -I../../ $(KHDR_INCLUDES)
> -CFLAGS := $(CFLAGS) -g -O2 -Wall -D_GNU_SOURCE -pthread $(INCLUDES) $(KHDR_INCLUDES)
> +CFLAGS := $(CFLAGS) -g -O2 -Wall -D_GNU_SOURCE= -pthread $(INCLUDES) $(KHDR_INCLUDES)
> LDLIBS := -lpthread -lrt
>
> LOCAL_HDRS := \
next prev parent reply other threads:[~2024-05-08 21:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 4:18 [PATCH 0/3] selftests/futex: clang-inspired fixes John Hubbard
2024-05-03 4:18 ` [PATCH 1/3] selftests/futex: don't redefine .PHONY targets (all, clean) John Hubbard
2024-05-03 4:18 ` [PATCH 2/3] selftests/futex: don't pass a const char* to asprintf(3) John Hubbard
2024-05-03 4:18 ` [PATCH 3/3] selftests/futex: pass _GNU_SOURCE without a value to the compiler John Hubbard
2024-05-08 21:05 ` John Hubbard [this message]
2024-05-06 16:13 ` [PATCH 0/3] selftests/futex: clang-inspired fixes Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbca543e-224b-4fa5-ba23-37f4957ff79d@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=andrealmeid@igalia.com \
--cc=broonie@kernel.org \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=edliaw@google.com \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=nysal@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).