From: Hans de Goede <hdegoede@redhat.com>
To: Lee Jones <lee@kernel.org>
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Pavel Machek" <pavel@ucw.cz>, "Kate Hsuan" <hpa@redhat.com>,
"Sebastian Reichel" <sre@kernel.org>,
platform-driver-x86@vger.kernel.org,
"André Apitzsch" <git@apitzsch.eu>,
linux-leds@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v8 3/7] leds: rgb: leds-ktd202x: Initialize mutex earlier
Date: Fri, 3 May 2024 15:57:34 +0200 [thread overview]
Message-ID: <10b4ac92-dd72-445a-9727-f6e40c68b12a@redhat.com> (raw)
In-Reply-To: <20240503070322.GA1227636@google.com>
Hi,
On 5/3/24 9:03 AM, Lee Jones wrote:
> On Fri, 03 May 2024, Hans de Goede wrote:
>
>> Hi,
>>
>> On 5/3/24 5:43 AM, Andy Shevchenko wrote:
>>> On Fri, May 3, 2024 at 12:14 AM Hans de Goede <hdegoede@redhat.com> wrote:
>>>>
>>>> The mutex must be initialized before the LED class device is registered
>>>> otherwise there is a race where it may get used before it is initialized:
>>>>
>>>> DEBUG_LOCKS_WARN_ON(lock->magic != lock)
>>>> WARNING: CPU: 2 PID: 2045 at kernel/locking/mutex.c:587 __mutex_lock
>>>> ...
>>>> RIP: 0010:__mutex_lock+0x7db/0xc10
>>>> ...
>>>> set_brightness_delayed_set_brightness.part.0+0x17/0x60
>>>> set_brightness_delayed+0xf1/0x100
>>>> process_one_work+0x222/0x5a0
>>>
>>> ...
>>>
>>>> + mutex_init(&chip->mutex);
>>>
>>> devm_mutex_init() ?
>>
>> That is not in Torvald's tree yet.
>
> Neither is this. :)
>
> Since we're nearly at -rc7, I think it's safe to say you have time.
Ok I'll prepare a v9 with this addressed and Andy's Reviewed-by
added.
Regards,
Hans
next prev parent reply other threads:[~2024-05-03 13:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 21:14 [PATCH v8 0/7] KTD2026 indicator LED for X86 Xiaomi Pad2 Hans de Goede
2024-05-02 21:14 ` [PATCH v8 1/7] leds: rgb: leds-ktd202x: Get device properties through fwnode to support ACPI Hans de Goede
2024-05-02 21:14 ` [PATCH v8 2/7] leds: rgb: leds-ktd202x: I2C ID tables for KTD2026 and 2027 Hans de Goede
2024-05-02 21:14 ` [PATCH v8 3/7] leds: rgb: leds-ktd202x: Initialize mutex earlier Hans de Goede
2024-05-03 3:43 ` Andy Shevchenko
2024-05-03 6:53 ` Hans de Goede
2024-05-03 7:03 ` Lee Jones
2024-05-03 13:57 ` Hans de Goede [this message]
2024-05-02 21:14 ` [PATCH v8 4/7] leds: core: Add led_mc_set_brightness() function Hans de Goede
2024-05-02 21:14 ` [PATCH v8 5/7] leds: trigger: Add led_mc_trigger_event() function Hans de Goede
2024-05-02 21:14 ` [PATCH v8 6/7] power: supply: power-supply-leds: Add charging_orange_full_green trigger for RGB LED Hans de Goede
2024-05-03 4:10 ` Andy Shevchenko
2024-05-02 21:14 ` [PATCH v8 7/7] platform: x86-android-tablets: Xiaomi pad2 RGB LED fwnode updates Hans de Goede
2024-05-03 4:12 ` [PATCH v8 0/7] KTD2026 indicator LED for X86 Xiaomi Pad2 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10b4ac92-dd72-445a-9727-f6e40c68b12a@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=git@apitzsch.eu \
--cc=hpa@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).