From: Lee Jones <lee@kernel.org>
To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: linux-leds@vger.kernel.org
Subject: Re: (subset) [PATCH] leds: trigger: panic: simplify led_trigger_set_panic
Date: Thu, 25 Jan 2024 13:34:53 +0000 [thread overview]
Message-ID: <170618969339.1467009.16893486596600124077.b4-ty@kernel.org> (raw)
In-Reply-To: <84c0fa67-2f03-4474-aa75-914d65d88dd0@gmail.com>
On Sat, 09 Dec 2023 23:54:51 +0100, Heiner Kallweit wrote:
> I don't see why we iterate over all triggers to find the panic trigger.
> We *are* the panic trigger. Therefore we also know that the panic
> trigger doesn't have an activate() hook. So we can simplify the code
> significantly.
>
>
Applied, thanks!
[1/1] leds: trigger: panic: simplify led_trigger_set_panic
commit: 682e98564ffb67989a77002844767318d366a9ee
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2024-01-25 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 22:54 [PATCH] leds: trigger: panic: simplify led_trigger_set_panic Heiner Kallweit
2024-01-11 9:03 ` Lee Jones
2024-01-16 22:44 ` Jacek Anaszewski
2024-01-18 14:47 ` Lee Jones
2024-01-25 13:34 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170618969339.1467009.16893486596600124077.b4-ty@kernel.org \
--to=lee@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).