From: Lee Jones <lee@kernel.org>
To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Anjelique Melendez <quic_amelende@quicinc.com>,
Arnd Bergmann <arnd@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Jean Delvare <jdelvare@suse.de>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: (subset) [PATCH] leds: qcom-lpg: add QCOM_PBS dependency
Date: Fri, 23 Feb 2024 14:52:30 +0000 [thread overview]
Message-ID: <170869995050.1680781.3053673810947690497.b4-ty@kernel.org> (raw)
In-Reply-To: <20240212111526.829122-1-arnd@kernel.org>
On Mon, 12 Feb 2024 12:15:02 +0100, Arnd Bergmann wrote:
> The lpg driver fails to link now when the pbs driver is in a loadable module:
>
> x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_brightness_set':
> leds-qcom-lpg.c:(.text+0xe7f): undefined reference to `qcom_pbs_trigger_event'
> x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_probe':
> leds-qcom-lpg.c:(.text+0x16a5): undefined reference to `get_pbs_client_device'
>
> [...]
Applied, thanks!
[1/1] leds: qcom-lpg: add QCOM_PBS dependency
commit: 2b6e12192159605ed7cffd36892cea2c82786975
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2024-02-23 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 11:15 [PATCH] leds: qcom-lpg: add QCOM_PBS dependency Arnd Bergmann
2024-02-12 20:06 ` Jean Delvare
2024-02-23 14:52 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170869995050.1680781.3053673810947690497.b4-ty@kernel.org \
--to=lee@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=quic_amelende@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).