From: Lee Jones <lee@kernel.org>
To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: linux-leds@vger.kernel.org
Subject: Re: (subset) [PATCH] leds: trigger: netdev: Remove not needed call to led_set_brightness in deactivate
Date: Thu, 11 Apr 2024 15:09:47 +0100 [thread overview]
Message-ID: <171284458763.2404313.7196062951404890342.b4-ty@kernel.org> (raw)
In-Reply-To: <8dc929e7-8e14-4c85-aa28-9c5fe2620f52@gmail.com>
On Fri, 05 Apr 2024 22:53:08 +0200, Heiner Kallweit wrote:
> led_trigger_set() is the only caller of the deactivate() callback,
> and it calls led_set_brightness(LED_OFF) anyway after deactivate().
> So we can remove the call here.
>
>
Applied, thanks!
[1/1] leds: trigger: netdev: Remove not needed call to led_set_brightness in deactivate
commit: b487c4e76657241197e056d06b4b73eab714f0e3
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2024-04-11 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 20:53 [PATCH] leds: trigger: netdev: Remove not needed call to led_set_brightness in deactivate Heiner Kallweit
2024-04-11 14:09 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171284458763.2404313.7196062951404890342.b4-ty@kernel.org \
--to=lee@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).