From: Lee Jones <lee@kernel.org>
To: pavel@ucw.cz, lee@kernel.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com,
ChiaEn Wu <chiaen_wu@richtek.com>
Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, peterwu.pub@gmail.com,
cy_huang@richtek.com
Subject: Re: (subset) [PATCH] leds: mt6360: Fix the second LED can not enable torch mode by V4L2
Date: Thu, 11 Apr 2024 17:48:37 +0100 [thread overview]
Message-ID: <171285411780.2498946.3824215880975158305.b4-ty@kernel.org> (raw)
In-Reply-To: <28FE6F1712799128000.chiaen_wu@richtek.com>
On Tue, 09 Apr 2024 18:21:54 +0800, ChiaEn Wu wrote:
> V4L2 will disable strobe mode of the LED device when enable torch mode,
> but this logic will conflict with the "priv->fled_torch_used"
> in "mt6360_strobe_set()". So after enabling torch mode of the first
> LED, the second LED will not be able to enable torch mode correctly.
>
> Therefore, at the beginning of "mt6360_strobe_set()", check whether the
> state of the upcoming change and the current LED device state are the
> same, so as to avoid the above problem.
>
> [...]
Applied, thanks!
[1/1] leds: mt6360: Fix the second LED can not enable torch mode by V4L2
commit: 0dcd0488a7a5b8762256b393a8bd0c21e5e4e0fb
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2024-04-11 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 10:21 [PATCH] leds: mt6360: Fix the second LED can not enable torch mode by V4L2 ChiaEn Wu
2024-04-11 16:48 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171285411780.2498946.3824215880975158305.b4-ty@kernel.org \
--to=lee@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chiaen_wu@richtek.com \
--cc=cy_huang@richtek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=peterwu.pub@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).