From: Lee Jones <lee@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: "Pavel Machek" <pavel@ucw.cz>, "Marek Behún" <kabel@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Daniel Golle" <daniel@makrotopia.org>,
"David S. Miller" <davem@davemloft.net>,
"Li Zetao" <lizetao1@huawei.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v6 2/2] docs: ABI: sysfs-class-led-trigger-netdev: Document now hidable link_*
Date: Thu, 11 Jan 2024 11:26:38 +0000 [thread overview]
Message-ID: <20240111112638.GG1678981@google.com> (raw)
In-Reply-To: <20231221171125.1732-2-ansuelsmth@gmail.com>
On Thu, 21 Dec 2023, Christian Marangi wrote:
> Document now hidable link speed modes for the LED netdev trigger.
>
> Link speed modes are now showed only if the named network device
> supports them and are hidden if not.
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> Reviewed-by: Marek Behún <kabel@kernel.org>
> ---
> Changes v6:
> - Add Reviewed-by tag
> Changes v2:
> - Add this patch
>
> .../ABI/testing/sysfs-class-led-trigger-netdev | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
Reviewed-by: Lee Jones <lee@kernel.org>
> diff --git a/Documentation/ABI/testing/sysfs-class-led-trigger-netdev b/Documentation/ABI/testing/sysfs-class-led-trigger-netdev
> index a6c307c4befa..ed46b37ab8a2 100644
> --- a/Documentation/ABI/testing/sysfs-class-led-trigger-netdev
> +++ b/Documentation/ABI/testing/sysfs-class-led-trigger-netdev
> @@ -88,6 +88,8 @@ Description:
> speed of 10MBps of the named network device.
> Setting this value also immediately changes the LED state.
>
> + Present only if the named network device supports 10Mbps link speed.
> +
> What: /sys/class/leds/<led>/link_100
> Date: Jun 2023
> KernelVersion: 6.5
> @@ -101,6 +103,8 @@ Description:
> speed of 100Mbps of the named network device.
> Setting this value also immediately changes the LED state.
>
> + Present only if the named network device supports 100Mbps link speed.
> +
> What: /sys/class/leds/<led>/link_1000
> Date: Jun 2023
> KernelVersion: 6.5
> @@ -114,6 +118,8 @@ Description:
> speed of 1000Mbps of the named network device.
> Setting this value also immediately changes the LED state.
>
> + Present only if the named network device supports 1000Mbps link speed.
> +
> What: /sys/class/leds/<led>/link_2500
> Date: Nov 2023
> KernelVersion: 6.8
> @@ -127,6 +133,8 @@ Description:
> speed of 2500Mbps of the named network device.
> Setting this value also immediately changes the LED state.
>
> + Present only if the named network device supports 2500Mbps link speed.
> +
> What: /sys/class/leds/<led>/link_5000
> Date: Nov 2023
> KernelVersion: 6.8
> @@ -140,6 +148,8 @@ Description:
> speed of 5000Mbps of the named network device.
> Setting this value also immediately changes the LED state.
>
> + Present only if the named network device supports 5000Mbps link speed.
> +
> What: /sys/class/leds/<led>/link_10000
> Date: Nov 2023
> KernelVersion: 6.8
> @@ -153,6 +163,8 @@ Description:
> speed of 10000Mbps of the named network device.
> Setting this value also immediately changes the LED state.
>
> + Present only if the named network device supports 10000Mbps link speed.
> +
> What: /sys/class/leds/<led>/half_duplex
> Date: Jun 2023
> KernelVersion: 6.5
> --
> 2.40.1
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-01-11 11:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 17:11 [PATCH v6 1/2] leds: trigger: netdev: display only supported link speed attribute Christian Marangi
2023-12-21 17:11 ` [PATCH v6 2/2] docs: ABI: sysfs-class-led-trigger-netdev: Document now hidable link_* Christian Marangi
2024-01-11 11:26 ` Lee Jones [this message]
2024-01-10 12:06 ` [PATCH v6 1/2] leds: trigger: netdev: display only supported link speed attribute Christian Marangi
2024-01-10 12:54 ` Lee Jones
2024-01-11 11:25 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240111112638.GG1678981@google.com \
--to=lee@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).