From: Lee Jones <lee@kernel.org>
To: Amitesh Singh <singh.amitesh@gmail.com>
Cc: pavel@ucw.cz, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds/pca963x: implement power management
Date: Thu, 25 Jan 2024 13:29:28 +0000 [thread overview]
Message-ID: <20240125132928.GI74950@google.com> (raw)
In-Reply-To: <20240116072457.383438-1-singh.amitesh@gmail.com>
On Tue, 16 Jan 2024, Amitesh Singh wrote:
> This implements power management in upstream driver
This *is* the upstream driver. No need to mention that.
> for pca9633 which enables device sleep and resume
> on system-wide sleep/hibernation
>
> Signed-off-by: Amitesh Singh <singh.amitesh@gmail.com>
> ---
> drivers/leds/leds-pca963x.c | 38 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
>
> diff --git a/drivers/leds/leds-pca963x.c b/drivers/leds/leds-pca963x.c
> index 47223c850e4b..2474e40d8479 100644
> --- a/drivers/leds/leds-pca963x.c
> +++ b/drivers/leds/leds-pca963x.c
> @@ -39,6 +39,7 @@
> #define PCA963X_LED_PWM 0x2 /* Controlled through PWM */
> #define PCA963X_LED_GRP_PWM 0x3 /* Controlled through PWM/GRPPWM */
>
> +#define PCA963X_MODE1_SLEEP 0x04 /* Normal mode or Low Power mode, oscillator off */
> #define PCA963X_MODE2_OUTDRV 0x04 /* Open-drain or totem pole */
> #define PCA963X_MODE2_INVRT 0x10 /* Normal or inverted direction */
> #define PCA963X_MODE2_DMBLNK 0x20 /* Enable blinking */
> @@ -380,6 +381,42 @@ static int pca963x_register_leds(struct i2c_client *client,
> return ret;
> }
>
> +#ifdef CONFIG_PM_SLEEP
> +static int pca963x_suspend(struct device *dev)
> +{
> + struct pca963x *chip;
> + u8 reg;
> +
> + chip = dev_get_drvdata(dev);
Do the assignment during declaration.
> + reg = i2c_smbus_read_byte_data(chip->client, PCA963X_MODE1);
> + reg = reg | (1 << PCA963X_MODE1_SLEEP);
BIT()
> + i2c_smbus_write_byte_data(chip->client, PCA963X_MODE1, reg);
> +
> + return 0;
> +}
> +
> +static int pca963x_resume(struct device *dev)
> +{
> + struct pca963x *chip;
> + u8 reg;
> +
> + chip = dev_get_drvdata(dev);
As above.
> + reg = i2c_smbus_read_byte_data(chip->client, PCA963X_MODE1);
> + reg = reg & ~(1 << PCA963X_MODE1_SLEEP);
As above.
> + i2c_smbus_write_byte_data(chip->client, PCA963X_MODE1, reg);
> +
> + return 0;
> +}
> +#endif
> +
> +static const struct dev_pm_ops pca963x_pmops = {
> + SET_SYSTEM_SLEEP_PM_OPS(pca963x_suspend, pca963x_resume)
> +};
> +
Remove this line.
> +static SIMPLE_DEV_PM_OPS(pca963x_pm, pca963x_suspend, pca963x_resume);
> +
> static const struct of_device_id of_pca963x_match[] = {
> { .compatible = "nxp,pca9632", },
> { .compatible = "nxp,pca9633", },
> @@ -430,6 +467,7 @@ static struct i2c_driver pca963x_driver = {
> .driver = {
> .name = "leds-pca963x",
> .of_match_table = of_pca963x_match,
> + .pm = &pca963x_pmops
> },
> .probe = pca963x_probe,
> .id_table = pca963x_id,
> --
> 2.43.0
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-01-25 13:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 7:24 [PATCH] leds/pca963x: implement power management Amitesh Singh
2024-01-25 13:29 ` Lee Jones [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-01-16 7:34 Amitesh Singh
2024-01-25 13:30 ` Lee Jones
2024-01-29 11:32 ` Amitesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125132928.GI74950@google.com \
--to=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=singh.amitesh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).