From: Andrew Lunn <andrew@lunn.ch>
To: "Marek Behún" <kabel@kernel.org>
Cc: Christian Marangi <ansuelsmth@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Daniel Golle <daniel@makrotopia.org>,
"David S. Miller" <davem@davemloft.net>,
Li Zetao <lizetao1@huawei.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v5 1/2] leds: trigger: netdev: display only supported link speed attribute
Date: Fri, 22 Dec 2023 10:02:25 +0100 [thread overview]
Message-ID: <626aedab-99b5-4fe1-a55e-4c7649a4e214@lunn.ch> (raw)
In-Reply-To: <20231221100848.4a7da2df@dellmb>
> I am also wondering if this sysfs ABI could be extended for multi-color
> LEDs.
>
> For example:
> echo green >link_1000
> echo yellow >link_100
>
> Or something like that. But that is a completely different discussion.
I've not looked at how the LED core code supports this.
You do see bi-colour LEDs. They are basically two LEDs head to
tail. You positively bias them and they are one colour, you negatively
bias them and they are a second colour. The two colours are mutually
exclusive.
It is also possible to have two LEDs co-located. That should already
supported, since you can control each LED independently.
It would be good to describe your hardware. We can then figure out how
they LED subsystem should support it.
Andrew
prev parent reply other threads:[~2023-12-22 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 22:48 [PATCH v5 1/2] leds: trigger: netdev: display only supported link speed attribute Christian Marangi
2023-12-20 22:48 ` [PATCH v5 2/2] docs: ABI: sysfs-class-led-trigger-netdev: Document now hidable link_* Christian Marangi
2023-12-21 9:08 ` [PATCH v5 1/2] leds: trigger: netdev: display only supported link speed attribute Marek Behún
2023-12-22 9:02 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=626aedab-99b5-4fe1-a55e-4c7649a4e214@lunn.ch \
--to=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).