From: Andrew Lunn <andrew@lunn.ch>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: "Pavel Machek" <pavel@ucw.cz>, "Lee Jones" <lee@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"William Zhang" <william.zhang@broadcom.com>,
"Anand Gore" <anand.gore@broadcom.com>,
"Kursad Oney" <kursad.oney@broadcom.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
"Fernández Rojas" <noltari@gmail.com>,
"Sven Schwermer" <sven.schwermer@disruptive-technologies.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [net-next PATCH v8 3/5] net: phy: add support for PHY LEDs polarity modes
Date: Fri, 5 Jan 2024 03:25:30 +0100 [thread overview]
Message-ID: <957df01b-bb92-4f8a-9f2b-aacd3de1208d@lunn.ch> (raw)
In-Reply-To: <6597286c.050a0220.4684a.182e@mx.google.com>
> > > + * @dev: PHY device which has the LED
> > > + * @index: Which LED of the PHY device or -1
> > > + * @modes: bitmap of LED polarity modes
> > > + *
> > > + * Configure LED with all the required polarity modes in @modes
> > > + * to make it correctly turn ON or OFF.
> >
> > index == -1 should be explained.
> >
>
> If you are referring to the special way of setting the LED globally,
> that is not a thing anymore. Rob pointed out that having the double
> reference in DT is problematic and PHY driver should handle that
> internally.
So it sounds like you need to change
> > > + * @index: Which LED of the PHY device or -1
to remove the 'or -1'
Andrew
next prev parent reply other threads:[~2024-01-05 2:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 11:01 [net-next PATCH v8 0/5] net: phy: generic polarity + LED support for qca808x Christian Marangi
2024-01-04 11:01 ` [net-next PATCH v8 1/5] dt-bindings: net: phy: Make LED active-low property common Christian Marangi
2024-01-04 11:01 ` [net-next PATCH v8 2/5] dt-bindings: net: phy: Document LED inactive high impedance mode Christian Marangi
2024-01-04 11:01 ` [net-next PATCH v8 3/5] net: phy: add support for PHY LEDs polarity modes Christian Marangi
2024-01-04 13:20 ` Andrew Lunn
2024-01-04 21:42 ` Christian Marangi
2024-01-05 2:25 ` Andrew Lunn [this message]
2024-01-04 11:01 ` [net-next PATCH v8 4/5] dt-bindings: net: Document QCA808x PHYs Christian Marangi
2024-01-04 11:01 ` [net-next PATCH v8 5/5] net: phy: at803x: add LED support for qca808x Christian Marangi
2024-01-04 11:48 ` Maxime Chevallier
2024-01-04 13:11 ` Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=957df01b-bb92-4f8a-9f2b-aacd3de1208d@lunn.ch \
--to=andrew@lunn.ch \
--cc=anand.gore@broadcom.com \
--cc=ansuelsmth@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=kursad.oney@broadcom.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=pabeni@redhat.com \
--cc=pavel@ucw.cz \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=sven.schwermer@disruptive-technologies.com \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).