From: Kate Hsuan <hpa@redhat.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Pavel Machek" <pavel@ucw.cz>, "Lee Jones" <lee@kernel.org>,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
"Hans de Goede" <hdegoede@redhat.com>,
"André Apitzsch" <git@apitzsch.eu>
Subject: Re: [PATCH v2 0/3] KTD2026 indicator LED for X86 Xiaomi Pad2
Date: Tue, 20 Feb 2024 12:34:55 +0800 [thread overview]
Message-ID: <CAEth8oE1=JKSskNG3HKxRyc8p=OXtgMskO7w4NV=stxCdmWhHw@mail.gmail.com> (raw)
In-Reply-To: <2dd3ead1-1066-3564-7c6b-9d366dc6e1e9@linux.intel.com>
Hi llpo,
On Mon, Feb 19, 2024 at 9:57 PM Ilpo Järvinen
<ilpo.jarvinen@linux.intel.com> wrote:
>
> On Sat, 17 Feb 2024, Kate Hsuan wrote:
>
> > The v2 patch includes:
> > 1. Typo and style fixes.
> > 2. The patch 0003 skips all the regulator setup for Xiaomi pad2 since
> > KTD2026 on Xiaomi pad2 is already powered by BP25890RTWR. So, the
> > sleep can be removed when removing the module.
> >
> > Kate Hsuan (3):
> > platform: x86-android-tablets: other: Add swnode for Xiaomi pad2
> > indicator LED
> > leds: rgb: leds-ktd202x: Get device properties through fwnode to
> > support ACPI
> > leds: rgb: leds-ktd202x: Skip requlator settings for Xiaomi pad2
>
> So what's the expectation here?
Thank you for reviewing it.
Sorry for the confusion.
This patch enabled the KTD2026 LED controller on a Xiaomi Pad2. The
controller controls an indicator LED which indicates the status of the
charging or other events.
Since it is an x86-based Android tablet, we need to set the device
information through swnode and revise the driver to use fwnode APIs.
> I take the first patch and the two other
> go through the LED subsys?
Yes. the first patch is for platform-driver-x86 and the second is for
the LED subsystem. If someone would like to test it, they could easily
get the necessary part of this work.
>
> --
> i.
>
--
BR,
Kate
prev parent reply other threads:[~2024-02-20 4:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 16:05 [PATCH v2 0/3] KTD2026 indicator LED for X86 Xiaomi Pad2 Kate Hsuan
2024-02-16 16:05 ` [PATCH v2 1/3] platform: x86-android-tablets: other: Add swnode for Xiaomi pad2 indicator LED Kate Hsuan
2024-02-19 14:07 ` Hans de Goede
2024-02-20 3:22 ` Kate Hsuan
2024-02-16 16:05 ` [PATCH v2 2/3] leds: rgb: leds-ktd202x: Get device properties through fwnode to support ACPI Kate Hsuan
2024-02-16 16:05 ` [PATCH v2 3/3] leds: rgb: leds-ktd202x: Skip regulator settings for Xiaomi pad2 Kate Hsuan
2024-02-19 13:28 ` Ilpo Järvinen
2024-02-19 14:04 ` Hans de Goede
2024-02-20 4:21 ` Kate Hsuan
2024-02-19 13:57 ` [PATCH v2 0/3] KTD2026 indicator LED for X86 Xiaomi Pad2 Ilpo Järvinen
2024-02-20 4:34 ` Kate Hsuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEth8oE1=JKSskNG3HKxRyc8p=OXtgMskO7w4NV=stxCdmWhHw@mail.gmail.com' \
--to=hpa@redhat.com \
--cc=git@apitzsch.eu \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).