From: Kate Hsuan <hpa@redhat.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: "Pavel Machek" <pavel@ucw.cz>, "Lee Jones" <lee@kernel.org>,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"André Apitzsch" <git@apitzsch.eu>,
linux-kernel@vger.kernel.org,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v5 RESEND 5/6] power: supply: power-supply-leds: Add charging_red_full_green trigger for RGB LED
Date: Mon, 1 Apr 2024 09:39:51 +0800 [thread overview]
Message-ID: <CAEth8oE21tdcEgb9K_d7cY=nBaazkVvcBg2piQeALwRiB2eY+w@mail.gmail.com> (raw)
In-Reply-To: <nakbogrilul6skiab5opfsqhhqfotfgmb47wyd3xbgbpf6hurc@6xshfz3obj7m>
Hi
On Sat, Mar 30, 2024 at 12:24 AM Sebastian Reichel <sre@kernel.org> wrote:
>
> Hello Kate,
>
> On Sun, Mar 24, 2024 at 11:01:06PM +0800, Kate Hsuan wrote:
> > Add a charging_red_full_green LED trigger and the trigger is based on
> > led_mc_trigger_event() which can set an RGB LED when the trigger is
> > triggered. The LED will show red when the battery status is charging.
> > The LED will show green when the battery status is full.
> >
> > Link: https://lore.kernel.org/linux-leds/f40a0b1a-ceac-e269-c2dd-0158c5b4a1ad@gmail.com/T/#t
> > Signed-off-by: Kate Hsuan <hpa@redhat.com>
> > ---
>
> Have you considered using orange instead of red? Using orange as
> charging indicator seems to be more common nowadays and allows
Sounds good.
I'll change the color for them.
Thank you
>
> green = battery full
> orange = battery charging
> red = battery empty / battery dead / error
>
> Greetings,
>
> -- Sebastian
>
> > drivers/power/supply/power_supply_leds.c | 25 ++++++++++++++++++++++++
> > include/linux/power_supply.h | 2 ++
> > 2 files changed, 27 insertions(+)
> >
> > diff --git a/drivers/power/supply/power_supply_leds.c b/drivers/power/supply/power_supply_leds.c
> > index c7db29d5fcb8..bd9c8fec5870 100644
> > --- a/drivers/power/supply/power_supply_leds.c
> > +++ b/drivers/power/supply/power_supply_leds.c
> > @@ -22,6 +22,8 @@
> > static void power_supply_update_bat_leds(struct power_supply *psy)
> > {
> > union power_supply_propval status;
> > + unsigned int intensity_green[3] = {255, 0, 0};
> > + unsigned int intensity_red[3] = {0, 0, 255};
> >
> > if (power_supply_get_property(psy, POWER_SUPPLY_PROP_STATUS, &status))
> > return;
> > @@ -36,12 +38,20 @@ static void power_supply_update_bat_leds(struct power_supply *psy)
> > /* Going from blink to LED on requires a LED_OFF event to stop blink */
> > led_trigger_event(psy->charging_blink_full_solid_trig, LED_OFF);
> > led_trigger_event(psy->charging_blink_full_solid_trig, LED_FULL);
> > + led_mc_trigger_event(psy->charging_red_full_green_trig,
> > + intensity_green,
> > + 3,
> > + LED_FULL);
> > break;
> > case POWER_SUPPLY_STATUS_CHARGING:
> > led_trigger_event(psy->charging_full_trig, LED_FULL);
> > led_trigger_event(psy->charging_trig, LED_FULL);
> > led_trigger_event(psy->full_trig, LED_OFF);
> > led_trigger_blink(psy->charging_blink_full_solid_trig, 0, 0);
> > + led_mc_trigger_event(psy->charging_red_full_green_trig,
> > + intensity_red,
> > + 3,
> > + LED_FULL);
> > break;
> > default:
> > led_trigger_event(psy->charging_full_trig, LED_OFF);
> > @@ -49,6 +59,10 @@ static void power_supply_update_bat_leds(struct power_supply *psy)
> > led_trigger_event(psy->full_trig, LED_OFF);
> > led_trigger_event(psy->charging_blink_full_solid_trig,
> > LED_OFF);
> > + led_mc_trigger_event(psy->charging_red_full_green_trig,
> > + intensity_red,
> > + 3,
> > + LED_OFF);
> > break;
> > }
> > }
> > @@ -74,6 +88,11 @@ static int power_supply_create_bat_triggers(struct power_supply *psy)
> > if (!psy->charging_blink_full_solid_trig_name)
> > goto charging_blink_full_solid_failed;
> >
> > + psy->charging_red_full_green_trig_name = kasprintf(GFP_KERNEL,
> > + "%s-charging-red-full-green", psy->desc->name);
> > + if (!psy->charging_red_full_green_trig_name)
> > + goto charging_red_full_green_failed;
> > +
> > led_trigger_register_simple(psy->charging_full_trig_name,
> > &psy->charging_full_trig);
> > led_trigger_register_simple(psy->charging_trig_name,
> > @@ -82,9 +101,13 @@ static int power_supply_create_bat_triggers(struct power_supply *psy)
> > &psy->full_trig);
> > led_trigger_register_simple(psy->charging_blink_full_solid_trig_name,
> > &psy->charging_blink_full_solid_trig);
> > + led_trigger_register_simple(psy->charging_red_full_green_trig_name,
> > + &psy->charging_red_full_green_trig);
> >
> > return 0;
> >
> > +charging_red_full_green_failed:
> > + kfree(psy->charging_blink_full_solid_trig_name);
> > charging_blink_full_solid_failed:
> > kfree(psy->full_trig_name);
> > full_failed:
> > @@ -101,10 +124,12 @@ static void power_supply_remove_bat_triggers(struct power_supply *psy)
> > led_trigger_unregister_simple(psy->charging_trig);
> > led_trigger_unregister_simple(psy->full_trig);
> > led_trigger_unregister_simple(psy->charging_blink_full_solid_trig);
> > + led_trigger_unregister_simple(psy->charging_red_full_green_trig);
> > kfree(psy->charging_blink_full_solid_trig_name);
> > kfree(psy->full_trig_name);
> > kfree(psy->charging_trig_name);
> > kfree(psy->charging_full_trig_name);
> > + kfree(psy->charging_red_full_green_trig_name);
> > }
> >
> > /* Generated power specific LEDs triggers. */
> > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> > index c0992a77feea..1d7c0b43070f 100644
> > --- a/include/linux/power_supply.h
> > +++ b/include/linux/power_supply.h
> > @@ -318,6 +318,8 @@ struct power_supply {
> > char *online_trig_name;
> > struct led_trigger *charging_blink_full_solid_trig;
> > char *charging_blink_full_solid_trig_name;
> > + struct led_trigger *charging_red_full_green_trig;
> > + char *charging_red_full_green_trig_name;
> > #endif
> > };
> >
> > --
> > 2.44.0
> >
> >
--
BR,
Kate
next prev parent reply other threads:[~2024-04-01 1:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 15:01 [PATCH v5 RESEND 0/6] KTD2026 indicator LED for X86 Xiaomi Pad2 Kate Hsuan
2024-03-24 15:01 ` [PATCH v5 RESEND 1/6] platform: x86-android-tablets: other: Add swnode for Xiaomi pad2 indicator LED Kate Hsuan
2024-03-24 19:29 ` Andy Shevchenko
2024-03-27 7:57 ` Kate Hsuan
2024-03-27 11:05 ` Andy Shevchenko
2024-03-27 11:18 ` Hans de Goede
2024-03-27 11:21 ` Andy Shevchenko
2024-03-28 9:14 ` Kate Hsuan
2024-03-24 15:01 ` [PATCH v5 RESEND 2/6] leds: rgb: leds-ktd202x: Get device properties through fwnode to support ACPI Kate Hsuan
2024-03-24 19:57 ` Andy Shevchenko
2024-03-27 6:53 ` Kate Hsuan
2024-03-27 11:07 ` Andy Shevchenko
2024-03-28 9:16 ` Kate Hsuan
2024-03-24 15:01 ` [PATCH v5 RESEND 3/6] leds: core: Add led_mc_set_brightness() function Kate Hsuan
2024-03-24 20:07 ` Andy Shevchenko
2024-03-24 15:01 ` [PATCH v5 RESEND 4/6] leds: trigger: Add led_mc_trigger_event() function Kate Hsuan
2024-03-24 15:01 ` [PATCH v5 RESEND 5/6] power: supply: power-supply-leds: Add charging_red_full_green trigger for RGB LED Kate Hsuan
2024-03-24 20:10 ` Andy Shevchenko
2024-03-27 6:32 ` Kate Hsuan
2024-03-29 16:23 ` Sebastian Reichel
2024-04-01 1:39 ` Kate Hsuan [this message]
2024-03-24 15:01 ` [PATCH v5 RESEND 6/6] platform: x86-android-tablets: others: Set the LED trigger to charging_red_full_green for Xiaomi pad2 Kate Hsuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEth8oE21tdcEgb9K_d7cY=nBaazkVvcBg2piQeALwRiB2eY+w@mail.gmail.com' \
--to=hpa@redhat.com \
--cc=andy.shevchenko@gmail.com \
--cc=git@apitzsch.eu \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).