From: Kate Hsuan <hpa@redhat.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Pavel Machek" <pavel@ucw.cz>, "Lee Jones" <lee@kernel.org>,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
"Hans de Goede" <hdegoede@redhat.com>,
"André Apitzsch" <git@apitzsch.eu>
Subject: Re: [PATCH v3 2/2] leds: rgb: leds-ktd202x: Get device properties through fwnode to support ACPI
Date: Tue, 5 Mar 2024 14:07:57 +0800 [thread overview]
Message-ID: <CAEth8oGEB8rhEhGu2ws8UnmpmsOV3VFnGtO98cf=1m4h=REh=A@mail.gmail.com> (raw)
In-Reply-To: <7dc47181-af26-6d46-d34f-57be0fdc8421@linux.intel.com>
Hi,
On Fri, Mar 1, 2024 at 6:59 PM Ilpo Järvinen
<ilpo.jarvinen@linux.intel.com> wrote:
>
> On Fri, 1 Mar 2024, Kate Hsuan wrote:
>
> > This LED controller also installed on a Xiaomi pad2 and it is a x86
> > platform. The original driver is based on device tree and can't be
> > used for this ACPI based system. This patch migrated the driver to
> > use fwnode to access the properties. Moreover, the fwnode API
> > supports device tree so this work won't effect the original
> > implementations.
> >
> > Signed-off-by: Kate Hsuan <hpa@redhat.com>
>
> > @@ -568,6 +574,8 @@ static int ktd202x_probe(struct i2c_client *client)
> > return ret;
> > }
> >
> > + chip->num_leds = (int) (unsigned long)i2c_get_match_data(client);
>
> Casting twice.
>
Thank you for reviewing it.
I'll fix it and propose the v4 patch.
> --
> i.
>
--
BR,
Kate
prev parent reply other threads:[~2024-03-05 6:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 3:36 [PATCH v3 0/2] KTD2026 indicator LED for X86 Xiaomi Pad2 Kate Hsuan
2024-03-01 3:36 ` [PATCH v3 1/2] platform: x86-android-tablets: other: Add swnode for Xiaomi pad2 indicator LED Kate Hsuan
2024-03-01 3:36 ` [PATCH v3 2/2] leds: rgb: leds-ktd202x: Get device properties through fwnode to support ACPI Kate Hsuan
2024-03-01 10:58 ` Ilpo Järvinen
2024-03-05 6:07 ` Kate Hsuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEth8oGEB8rhEhGu2ws8UnmpmsOV3VFnGtO98cf=1m4h=REh=A@mail.gmail.com' \
--to=hpa@redhat.com \
--cc=git@apitzsch.eu \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).