From: Pavel Machek <pavel@ucw.cz>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Frank Wunderlich <linux@fw-web.de>, Lee Jones <lee@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Frank Wunderlich <frank-w@public-files.de>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: mark label as depected to match description
Date: Thu, 9 May 2024 18:55:02 +0200 [thread overview]
Message-ID: <Zjz/5slQk6XVy3us@duo.ucw.cz> (raw)
In-Reply-To: <fdce3c08-a3cb-4d5b-ad1a-0eeb8761778f@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]
On Thu 2024-05-09 14:39:36, AngeloGioacchino Del Regno wrote:
> Il 09/05/24 13:46, Krzysztof Kozlowski ha scritto:
> > On 09/05/2024 13:05, Frank Wunderlich wrote:
> > > From: Frank Wunderlich <frank-w@public-files.de>
> > >
> > > The description for property 'label' describes it as deprected, so
> >
> > Typos here and in subject.
> >
> >
> > > add a option to mark it like that. Future devicetrees should use
> > > function and color properties.
> > >
> > > Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > > Fixes: 24a71afe05a8 ("dt-bindings: leds: Convert common LED binding to schema")
> >
> > Nooo, that's not a fix.
> >
> > I don't think there was conclusion to make it deprecated on last attempt:
> >
> > https://lore.kernel.org/all/20221122111124.6828-1-cniedermaier@dh-electronics.com/
> >
>
> It's not a fix, agreed.
>
> But that property being deprecated deserves to be marked as deprecated, anyway.
> Otherwise the documentation shouldn't say in words that it is such.
Fix the docs. We are not ready to deprecate that.
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2024-05-09 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 11:05 [PATCH] dt-bindings: leds: mark label as depected to match description Frank Wunderlich
2024-05-09 11:46 ` Krzysztof Kozlowski
2024-05-09 12:39 ` AngeloGioacchino Del Regno
2024-05-09 16:55 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zjz/5slQk6XVy3us@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@fw-web.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).