From: Aren <aren@peacevolution.org>
To: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Cc: linux-kernel@vger.kernel.org, Miles Alan <m@milesalan.com>,
Ondrej Jirman <megi@xff.cz>, Lee Jones <lee@kernel.org>,
Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend
Date: Wed, 31 Jan 2024 20:39:56 -0500 [thread overview]
Message-ID: <oq4zwh56l5zzhvrrvpqrhhb3ghuo5trnezkxhgb63wquhjkhhx@wajib2nwytxf> (raw)
In-Reply-To: <05f9c78d-b398-420e-bc0f-fb642e76efdc@traphandler.com>
On Wed, Jan 31, 2024 at 08:39:01AM +0100, Jean-Jacques Hiblot wrote:
>
>
> On 28/01/2024 21:45, Aren Moynihan wrote:
> > If none of the managed leds enable LED_CORE_SUSPENDRESUME, then we
> > shouldn't need to set it here. This makes it possible to use multicolor
> > groups with gpio leds that enable retain-state-suspended in the device
> > tree.
> >
> > Signed-off-by: Aren Moynihan <aren@peacevolution.org>
> > ---
> >
> > drivers/leds/rgb/leds-group-multicolor.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/leds/rgb/leds-group-multicolor.c b/drivers/leds/rgb/leds-group-multicolor.c
> > index 39f58be32af5..194c6a33640b 100644
> > --- a/drivers/leds/rgb/leds-group-multicolor.c
> > +++ b/drivers/leds/rgb/leds-group-multicolor.c
> > @@ -69,7 +69,7 @@ static int leds_gmc_probe(struct platform_device *pdev)
> > struct mc_subled *subled;
> > struct leds_multicolor *priv;
> > unsigned int max_brightness = 0;
> > - int i, ret, count = 0;
> > + int i, ret, count, common_flags = 0;
>
> count is not initialized anymore. Isn't it a problem ?
Yes, good catch, thanks!
I'm not sure how I missed that when I tested this, I must've gotten
(un)lucky with the value that was in ram before.
- Aren
> > priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> > if (!priv)
> > @@ -91,6 +91,7 @@ static int leds_gmc_probe(struct platform_device *pdev)
> > if (!priv->monochromatics)
> > return -ENOMEM;
> > + common_flags |= led_cdev->flags;
> > priv->monochromatics[count] = led_cdev;
> > max_brightness = max(max_brightness, led_cdev->max_brightness);
> > @@ -114,12 +115,15 @@ static int leds_gmc_probe(struct platform_device *pdev)
> > /* Initialise the multicolor's LED class device */
> > cdev = &priv->mc_cdev.led_cdev;
> > - cdev->flags = LED_CORE_SUSPENDRESUME;
> > cdev->brightness_set_blocking = leds_gmc_set;
> > cdev->max_brightness = max_brightness;
> > cdev->color = LED_COLOR_ID_MULTI;
> > priv->mc_cdev.num_colors = count;
> > + /* we only need suspend/resume if a sub-led requests it */
> > + if (common_flags & LED_CORE_SUSPENDRESUME)
> > + cdev->flags = LED_CORE_SUSPENDRESUME;
> > +
> > init_data.fwnode = dev_fwnode(dev);
> > ret = devm_led_classdev_multicolor_register_ext(dev, &priv->mc_cdev, &init_data);
> > if (ret)
prev parent reply other threads:[~2024-02-01 1:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 20:45 [PATCH 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend Aren Moynihan
2024-01-31 7:39 ` Jean-Jacques Hiblot
2024-02-01 1:39 ` Aren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=oq4zwh56l5zzhvrrvpqrhhb3ghuo5trnezkxhgb63wquhjkhhx@wajib2nwytxf \
--to=aren@peacevolution.org \
--cc=jjhiblot@traphandler.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=m@milesalan.com \
--cc=megi@xff.cz \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).