Linux-LVM Archive mirror
 help / color / mirror / Atom feed
From: Martin Wilck <martin.wilck@suse.com>
To: "teigland@redhat.com" <teigland@redhat.com>
Cc: Heming Zhao <heming.zhao@suse.com>,
	"zkabelac@redhat.com" <zkabelac@redhat.com>,
	Glass Su <glass.su@suse.com>, "hare@suse.de" <hare@suse.de>,
	"bmarzins@redhat.com" <bmarzins@redhat.com>,
	"linux-lvm@lists.linux.dev" <linux-lvm@lists.linux.dev>
Subject: Re: discuss about commit 3b0f9ce: filter-mpath: get wwids from sysfs vpd_pg83
Date: Tue, 21 Nov 2023 20:35:00 +0000	[thread overview]
Message-ID: <6b7fd83b3f785b18cf77bf01519812db57f6e955.camel@suse.com> (raw)
In-Reply-To: <ZVz2LgBbiWrzLSgZ@redhat.com>

On Tue, 2023-11-21 at 12:25 -0600, David Teigland wrote:
> On Tue, Nov 21, 2023 at 06:10:12PM +0000, Martin Wilck wrote:
> > But I wonder if this is required. You could create a script that
> > calls pvscan, and then systemd-run / vgchange with the output of
> > the
> > pvscan command, and execute this script in RUN. That was roughly my
> > idea. That way you wouldn't loose any DEVLINKS added after 69-dm-
> > lvm.rules.
> 
> I don't see any immediate problem with that idea, although using a
> script
> doesn't sound nice if it can be avoided.  It seems academic since I'm
> not
> seeing a problem with the current method.

It's sort of academic, agreed. It would be easy to construct a case
where the DEVLINKS approach would fail, but that's unlikely to occur in
practice.

Martin


      reply	other threads:[~2023-11-21 20:35 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-11 12:51 discuss about commit 3b0f9ce: filter-mpath: get wwids from sysfs vpd_pg83 Heming Zhao
2023-11-13 11:52 ` Martin Wilck
2023-11-13 13:52   ` Peter Rajnoha
2023-11-13 18:38     ` David Teigland
2023-11-14  7:55       ` Peter Rajnoha
2023-11-14 16:30         ` David Teigland
2023-11-15  8:51           ` Peter Rajnoha
2023-11-15 11:36             ` Heming Zhao
2023-11-15 19:12               ` David Teigland
2023-11-16 13:37                 ` Zdenek Kabelac
2023-11-16 13:46                   ` Martin Wilck
2023-11-16 14:03                     ` Zdenek Kabelac
2023-11-16 15:29                       ` Martin Wilck
2023-11-16 17:13                         ` David Teigland
2023-11-16 15:10                   ` David Teigland
2023-11-16 15:40                     ` Martin Wilck
2023-11-16 15:48                       ` Zdenek Kabelac
2023-11-16 17:27                         ` David Teigland
2023-11-16 15:59                     ` Zdenek Kabelac
2023-11-17  1:47                   ` Demi Marie Obenour
2023-11-17 15:25                     ` David Teigland
2023-11-17 19:57                       ` Demi Marie Obenour
2023-11-17 20:16                         ` David Teigland
2023-11-17 21:03                           ` Demi Marie Obenour
2023-11-17 21:05                             ` Martin Wilck
2023-11-20 10:13                               ` Zdenek Kabelac
2023-11-15 21:02             ` David Teigland
2023-11-15 21:46               ` Martin Wilck
2023-11-16 16:11                 ` David Teigland
2023-11-14 10:44       ` Martin Wilck
2023-11-14 12:18         ` Heming Zhao
2023-11-14 17:16           ` David Teigland
2023-11-14 17:00         ` David Teigland
2023-11-14 17:48           ` Martin Wilck
2023-11-14 17:58             ` Martin Wilck
2023-11-14 21:02               ` David Teigland
2023-11-15  7:35                 ` Martin Wilck
2023-11-16 16:34                   ` David Teigland
2023-11-16 20:22                     ` Benjamin Marzinski
2023-11-14 20:51             ` David Teigland
2023-11-15  5:15               ` Heming Zhao
2023-11-15  7:39                 ` Martin Wilck
2023-11-21 14:39   ` Martin Wilck
2023-11-21 17:56     ` David Teigland
2023-11-21 18:10       ` Martin Wilck
2023-11-21 18:25         ` David Teigland
2023-11-21 20:35           ` Martin Wilck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b7fd83b3f785b18cf77bf01519812db57f6e955.camel@suse.com \
    --to=martin.wilck@suse.com \
    --cc=bmarzins@redhat.com \
    --cc=glass.su@suse.com \
    --cc=hare@suse.de \
    --cc=heming.zhao@suse.com \
    --cc=linux-lvm@lists.linux.dev \
    --cc=teigland@redhat.com \
    --cc=zkabelac@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).