From: Svetly Todorov <svetly.todorov@memverge.com>
To: Alejandro Colomar <alx@kernel.org>
Cc: linux-man@vger.kernel.org, gregory.price@memverge.com,
ying.huang@intel.com
Subject: Re: [PATCH v5] man2: add MPOL_WEIGHTED_INTERLEAVE documentation
Date: Wed, 20 Mar 2024 11:40:31 -0700 [thread overview]
Message-ID: <4803b837-73d3-4ac0-b00c-ad272eb092d6@memverge.com> (raw)
In-Reply-To: <ZfomvYUh18tiZF3d@debian>
Hi Alex,
>> index 5248f04ba..00ce287c9 100644
>> --- a/man2/get_mempolicy.2
>> +++ b/man2/get_mempolicy.2
>> @@ -137,7 +137,11 @@ specifies
>> but not
>> .BR MPOL_F_ADDR ,
>> and the thread's current policy is
>> -.BR MPOL_INTERLEAVE ,
>> +.B MPOL_INTERLEAVE
>> +or
>> +.B MPOL_WEIGHTED_INTERLEAVE
>> +(available since Linux 6.9),
> For consistency, I try to use the same phrase everywhere:
>
> (since Linux x.y)
>
> But, in simple mentions, we usually don't specify when a flag was added.
> That's already documented in the proper documentation of the flag. So
> here, I'd just remove that (and the comment below).
Got it. This was one of those things I was unsure of.
I think I was referencing
> If
> .I flags
> specifies
> .B MPOL_F_MEMS_ALLOWED
> (available since Linux 2.6.24)
from earlier in the file.
>> +.\" commit fa3bea4e1f8202d787709b7e3654eb0a99aed758
>> then
>> .BR get_mempolicy ()
>> will return in the location pointed to by a non-NULL
>> @@ -206,7 +210,11 @@ specified
>> but not
>> .B MPOL_F_ADDR
>> and the current thread policy is not
>> -.BR MPOL_INTERLEAVE .
>> +.B MPOL_INTERLEAVE
>> +or
> I prefer "nor".
Sure, will change to neither/nor.
>> +.B MPOL_WEIGHTED_INTERLEAVE
>> +(added in Linux 6.9).
> Same here.
I'll drop this one, too.
>> +.\" commit fa3bea4e1f8202d787709b7e3654eb0a99aed758
>> Or,
>> .I flags
>> specified
>> diff --git a/man2/mbind.2 b/man2/mbind.2
>> index b0e961f9c..6f2449946 100644
>> --- a/man2/mbind.2
>> +++ b/man2/mbind.2
>> @@ -105,6 +105,7 @@ argument must specify one of
>> .BR MPOL_DEFAULT ,
>> .BR MPOL_BIND ,
>> .BR MPOL_INTERLEAVE ,
>> +.BR MPOL_WEIGHTED_INTERLEAVE ,
>> .BR MPOL_PREFERRED ,
>> or
>> .B MPOL_LOCAL
>> @@ -243,6 +244,23 @@ at least 1\ MB or bigger with a fairly uniform access pattern.
>> Accesses to a single page of the area will still be limited to
>> the memory bandwidth of a single node.
>> .TP
>> +.BR MPOL_WEIGHTED_INTERLEAVE " (since Linux 6.9)"
>> +.\" commit fa3bea4e1f8202d787709b7e3654eb0a99aed758
> Here is where we usually document the kernel versions. So here (and
> in set_mempolicy.2) is good, and enough, I think.
>
> Have a lovely night!
> Alex
Sounds good. Yeah, get_mempolicy was getting pretty crowded with the
extra parentheticals, and the hash comments felt out of place.
I'm glad we're OK to drop them outright.
Svetly
prev parent reply other threads:[~2024-03-20 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 16:32 [PATCH v5] man2: add MPOL_WEIGHTED_INTERLEAVE documentation Svetly Todorov
2024-03-19 23:58 ` Alejandro Colomar
2024-03-20 18:40 ` Svetly Todorov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4803b837-73d3-4ac0-b00c-ad272eb092d6@memverge.com \
--to=svetly.todorov@memverge.com \
--cc=alx@kernel.org \
--cc=gregory.price@memverge.com \
--cc=linux-man@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).