Linux-man Archive mirror
 help / color / mirror / Atom feed
From: Alejandro Colomar <alx@kernel.org>
To: Jonny Grant <jg@jguk.org>
Cc: linux-man <linux-man@vger.kernel.org>
Subject: Re: posix_memalign(3)
Date: Fri, 24 Nov 2023 23:15:42 +0100	[thread overview]
Message-ID: <ZWEgjh04AoNijJmL@debian> (raw)
In-Reply-To: <221a5e66-cf73-4342-a610-3e1b247b14c4@jguk.org>

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

Hi Jonny,

On Fri, Nov 17, 2023 at 10:03:58PM +0000, Jonny Grant wrote:
> Hello
> 
> Some feedback, suggestions.
> 
> https://man7.org/linux/man-pages/man3/posix_memalign.3.html
> "ENOMEM There was insufficient memory to fulfill the allocation request."
> 
> Rather wordy, how about "ENOMEM Out of memory" ? that would match malloc(3)

LGTM

> 
> 
> There are quite a few extra words in the description, how about simplifying:
> 
> Orig:
> "The function posix_memalign() allocates size bytes and places the
> address of the allocated memory in *memptr. "
> 
> Simplification:
> "posix_memalign() allocates size bytes and places the

LGTM

> allocated memory address in *memptr."

This doesn't convince me.  I've applied patches for all the other
suggestions.

> 
> Another one.
> Orig:
> "The function aligned_alloc() is the same as memalign(), except
> for the added restriction that size should be a multiple of
> alignment."
> 
> simplification:
> 
> "aligned_alloc() is the same as memalign(), except

LGTM

> for the added restriction that size should be a multiple of
> alignment.
> 
> Kind regards, Jonny

Thanks,
Alex

-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2023-11-24 22:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-17 22:03 posix_memalign(3) Jonny Grant
2023-11-24 22:15 ` Alejandro Colomar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZWEgjh04AoNijJmL@debian \
    --to=alx@kernel.org \
    --cc=jg@jguk.org \
    --cc=linux-man@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).