* [PATCH v2 0/8] MediaTek UFS fixes and cleanups - Part 1
@ 2024-04-11 11:42 AngeloGioacchino Del Regno
2024-04-11 11:42 ` [PATCH v2 1/8] scsi: ufs: ufs-mediatek: Remove useless mediatek,ufs-support-va09 property AngeloGioacchino Del Regno
` (7 more replies)
0 siblings, 8 replies; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-04-11 11:42 UTC (permalink / raw
To: linux-scsi
Cc: alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg,
angelogioacchino.delregno, stanley.chu, devicetree, linux-kernel,
linux-mediatek, linux-arm-kernel
Changes in v2:
- Rebased over next-20240409 (because of merge issue for patch 1)
- Added ufs: prefix to patch 1
- Added forgotten ufs-rx-symbol clock to the binding
This series performs some fixes and cleanups for the MediaTek UFSHCI
controller driver.
In particular, while adding the MT8195 compatible to the mediatek,ufs
binding, I noticed that it was allowing just one clock, completely
ignoring the optional ones, including the crypt-xxx clocks, all of
the optional regulators, and other properties.
Between all the other properties, two are completely useless, as they
are there just to activate features that, on SoCs that don't support
these, won't anyway be activated because of missing clocks or missing
regulators, or missing other properties;
as for the other vendor-specific properties, like ufs-disable-ah8,
ufs-broken-vcc, ufs-pmc-via-fastauto, since the current merge window
is closing, I didn't do extensive research so I've left them in place
but didn't add them to the devicetree binding yet.
The plan is to check those later and eventually give them a removal
treatment, or add them to the bindings in a part two series.
For now, at least, this is already a big improvement.
P.S.: The only SoC having UFSHCI upstream is MT8183, which only has
just one clock, and *nothing else* uses properties, clocks, etc that
were renamed in this cleanup.
Cheers!
AngeloGioacchino Del Regno (8):
scsi: ufs: ufs-mediatek: Remove useless mediatek,ufs-support-va09 property
scsi: ufs: ufs-mediatek: Fix property name for crypt boost voltage
scsi: ufs: ufs-mediatek: Remove useless mediatek,ufs-boost-crypt
property
scsi: ufs: ufs-mediatek: Avoid underscores in crypt clock names
dt-bindings: ufs: mediatek,ufs: Document MT8192 compatible with MT8183
dt-bindings: ufs: mediatek,ufs: Document MT8195 compatible
dt-bindings: ufs: mediatek,ufs: Document additional clocks
dt-bindings: ufs: mediatek,ufs: Document optional dvfsrc/va09
regulators
.../devicetree/bindings/ufs/mediatek,ufs.yaml | 29 +++++-
drivers/ufs/host/ufs-mediatek.c | 91 +++++++++++--------
2 files changed, 80 insertions(+), 40 deletions(-)
--
2.44.0
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 1/8] scsi: ufs: ufs-mediatek: Remove useless mediatek,ufs-support-va09 property
2024-04-11 11:42 [PATCH v2 0/8] MediaTek UFS fixes and cleanups - Part 1 AngeloGioacchino Del Regno
@ 2024-04-11 11:42 ` AngeloGioacchino Del Regno
2024-04-11 11:42 ` [PATCH v2 2/8] scsi: ufs: ufs-mediatek: Fix property name for crypt boost voltage AngeloGioacchino Del Regno
` (6 subsequent siblings)
7 siblings, 0 replies; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-04-11 11:42 UTC (permalink / raw
To: linux-scsi
Cc: alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg,
angelogioacchino.delregno, stanley.chu, devicetree, linux-kernel,
linux-mediatek, linux-arm-kernel
Remove checking the mediatek,ufs-support-va09 property to decide
whether to try to support the VA09 regulator handling and change
the ufs_mtk_init_va09_pwr_ctrl() function to make it call
devm_regulator_get_optional(): if the regulator is present, then
we set the UFS_MTK_CAP_VA09_PWR_CTRL, effectively enabling the
handling of the VA09 regulator based on that.
Also, make sure to pass the return value of the call to
devm_regulator_get_optional() to the probe function, so that
if it returns a probe deferral, the appropriate action will be
taken.
While at it, remove the error print (disguised as info...) when
the va09 regulator was not found.
Fixes: ac8c2459091c ("scsi: ufs-mediatek: Decouple features from platform bindings")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/ufs/host/ufs-mediatek.c | 34 +++++++++++++++++++++++----------
1 file changed, 24 insertions(+), 10 deletions(-)
diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
index 0b0c923b1d7b..e4643ac49033 100644
--- a/drivers/ufs/host/ufs-mediatek.c
+++ b/drivers/ufs/host/ufs-mediatek.c
@@ -622,27 +622,38 @@ static void ufs_mtk_init_boost_crypt(struct ufs_hba *hba)
return;
}
-static void ufs_mtk_init_va09_pwr_ctrl(struct ufs_hba *hba)
+static int ufs_mtk_init_va09_pwr_ctrl(struct ufs_hba *hba)
{
struct ufs_mtk_host *host = ufshcd_get_variant(hba);
+ int ret;
- host->reg_va09 = regulator_get(hba->dev, "va09");
- if (IS_ERR(host->reg_va09))
- dev_info(hba->dev, "failed to get va09");
- else
- host->caps |= UFS_MTK_CAP_VA09_PWR_CTRL;
+ host->reg_va09 = devm_regulator_get_optional(hba->dev, "va09");
+ if (IS_ERR(host->reg_va09)) {
+ ret = PTR_ERR(host->reg_va09);
+
+ /* Return an error only if this is a deferral */
+ if (ret == -EPROBE_DEFER)
+ return ret;
+
+ return 0;
+ }
+
+ host->caps |= UFS_MTK_CAP_VA09_PWR_CTRL;
+ return 0;
}
-static void ufs_mtk_init_host_caps(struct ufs_hba *hba)
+static int ufs_mtk_init_host_caps(struct ufs_hba *hba)
{
struct ufs_mtk_host *host = ufshcd_get_variant(hba);
struct device_node *np = hba->dev->of_node;
+ int ret;
if (of_property_read_bool(np, "mediatek,ufs-boost-crypt"))
ufs_mtk_init_boost_crypt(hba);
- if (of_property_read_bool(np, "mediatek,ufs-support-va09"))
- ufs_mtk_init_va09_pwr_ctrl(hba);
+ ret = ufs_mtk_init_va09_pwr_ctrl(hba);
+ if (ret)
+ return ret;
if (of_property_read_bool(np, "mediatek,ufs-disable-ah8"))
host->caps |= UFS_MTK_CAP_DISABLE_AH8;
@@ -663,6 +674,7 @@ static void ufs_mtk_init_host_caps(struct ufs_hba *hba)
host->caps |= UFS_MTK_CAP_RTFF_MTCMOS;
dev_info(hba->dev, "caps: 0x%x", host->caps);
+ return 0;
}
static void ufs_mtk_scale_perf(struct ufs_hba *hba, bool scale_up)
@@ -985,7 +997,9 @@ static int ufs_mtk_init(struct ufs_hba *hba)
}
/* Initialize host capability */
- ufs_mtk_init_host_caps(hba);
+ err = ufs_mtk_init_host_caps(hba);
+ if (err)
+ goto out;
ufs_mtk_init_mcq_irq(hba);
--
2.44.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 2/8] scsi: ufs: ufs-mediatek: Fix property name for crypt boost voltage
2024-04-11 11:42 [PATCH v2 0/8] MediaTek UFS fixes and cleanups - Part 1 AngeloGioacchino Del Regno
2024-04-11 11:42 ` [PATCH v2 1/8] scsi: ufs: ufs-mediatek: Remove useless mediatek,ufs-support-va09 property AngeloGioacchino Del Regno
@ 2024-04-11 11:42 ` AngeloGioacchino Del Regno
2024-04-11 11:42 ` [PATCH v2 3/8] scsi: ufs: ufs-mediatek: Remove useless mediatek,ufs-boost-crypt property AngeloGioacchino Del Regno
` (5 subsequent siblings)
7 siblings, 0 replies; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-04-11 11:42 UTC (permalink / raw
To: linux-scsi
Cc: alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg,
angelogioacchino.delregno, stanley.chu, devicetree, linux-kernel,
linux-mediatek, linux-arm-kernel
Rename "boost-crypt-vcore-min" to "mediatek,boost-crypt-microvolt":
this is a vendor specific property and needs the "mediatek," prefix,
moreover, this is not defining a minimum voltage per-se;
Even if technically a call to regulator_set_voltage() does indeed
internally set a VMIN for a regulator, the API also supports other
calls to set VMIN-VMAX constraints, so this "vcore-min"->"microvolt"
rename is performed in order to avoid confusion, other than adding
the "microvolt" suffix to it (as this does take microvolts!).
Fixes: 590b0d2372fe ("scsi: ufs-mediatek: Support performance mode for inline encryption engine")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/ufs/host/ufs-mediatek.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
index e4643ac49033..688d85909ad6 100644
--- a/drivers/ufs/host/ufs-mediatek.c
+++ b/drivers/ufs/host/ufs-mediatek.c
@@ -595,9 +595,9 @@ static void ufs_mtk_init_boost_crypt(struct ufs_hba *hba)
goto disable_caps;
}
- if (of_property_read_u32(dev->of_node, "boost-crypt-vcore-min",
+ if (of_property_read_u32(dev->of_node, "mediatek,boost-crypt-microvolt",
&volt)) {
- dev_info(dev, "failed to get boost-crypt-vcore-min");
+ dev_info(dev, "failed to get mediatek,boost-crypt-microvolt");
goto disable_caps;
}
--
2.44.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 3/8] scsi: ufs: ufs-mediatek: Remove useless mediatek,ufs-boost-crypt property
2024-04-11 11:42 [PATCH v2 0/8] MediaTek UFS fixes and cleanups - Part 1 AngeloGioacchino Del Regno
2024-04-11 11:42 ` [PATCH v2 1/8] scsi: ufs: ufs-mediatek: Remove useless mediatek,ufs-support-va09 property AngeloGioacchino Del Regno
2024-04-11 11:42 ` [PATCH v2 2/8] scsi: ufs: ufs-mediatek: Fix property name for crypt boost voltage AngeloGioacchino Del Regno
@ 2024-04-11 11:42 ` AngeloGioacchino Del Regno
2024-04-11 11:42 ` [PATCH v2 4/8] scsi: ufs: ufs-mediatek: Avoid underscores in crypt clock names AngeloGioacchino Del Regno
` (4 subsequent siblings)
7 siblings, 0 replies; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-04-11 11:42 UTC (permalink / raw
To: linux-scsi
Cc: alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg,
angelogioacchino.delregno, stanley.chu, devicetree, linux-kernel,
linux-mediatek, linux-arm-kernel
There is no need to have a property that activates the inline crypto
boost feature, as this needs many things: a regulator, three clocks,
and the mediatek,boost-crypt-microvolt property to be set.
If any one of these is missing, the feature won't be activated,
hence, it is useless to have yet one more property to enable that.
While at it, also address another two issues:
1. Give back the return value to the caller and make sure to fail
probing if we get an -EPROBE_DEFER or -ENOMEM; and
2. Free the ufs_mtk_crypt_cfg structure allocated in the crypto
boost function if said functionality could not be enabled because
it's not supported, as that'd be only wasted memory.
Last but not least, move the devm_kzalloc() call for ufs_mtk_crypt_cfg
to after getting the dvfsrc-vcore regulator and the boost microvolt
property, as if those fail there's no reason to even allocate that.
Fixes: ac8c2459091c ("scsi: ufs-mediatek: Decouple features from platform bindings")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/ufs/host/ufs-mediatek.c | 55 ++++++++++++++++++---------------
1 file changed, 30 insertions(+), 25 deletions(-)
diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
index 688d85909ad6..47f16e6720f4 100644
--- a/drivers/ufs/host/ufs-mediatek.c
+++ b/drivers/ufs/host/ufs-mediatek.c
@@ -575,51 +575,55 @@ static int ufs_mtk_init_host_clk(struct ufs_hba *hba, const char *name,
return ret;
}
-static void ufs_mtk_init_boost_crypt(struct ufs_hba *hba)
+static int ufs_mtk_init_boost_crypt(struct ufs_hba *hba)
{
struct ufs_mtk_host *host = ufshcd_get_variant(hba);
struct ufs_mtk_crypt_cfg *cfg;
struct device *dev = hba->dev;
struct regulator *reg;
u32 volt;
-
- host->crypt = devm_kzalloc(dev, sizeof(*(host->crypt)),
- GFP_KERNEL);
- if (!host->crypt)
- goto disable_caps;
+ int ret;
reg = devm_regulator_get_optional(dev, "dvfsrc-vcore");
if (IS_ERR(reg)) {
- dev_info(dev, "failed to get dvfsrc-vcore: %ld",
- PTR_ERR(reg));
- goto disable_caps;
+ ret = PTR_ERR(reg);
+ if (ret == -EPROBE_DEFER)
+ return ret;
+
+ return 0;
}
- if (of_property_read_u32(dev->of_node, "mediatek,boost-crypt-microvolt",
- &volt)) {
+ ret = of_property_read_u32(dev->of_node, "mediatek,boost-crypt-microvolt", &volt);
+ if (ret) {
dev_info(dev, "failed to get mediatek,boost-crypt-microvolt");
- goto disable_caps;
+ return 0;
}
+ host->crypt = devm_kzalloc(dev, sizeof(*host->crypt), GFP_KERNEL);
+ if (!host->crypt)
+ return -ENOMEM;
+
cfg = host->crypt;
- if (ufs_mtk_init_host_clk(hba, "crypt_mux",
- &cfg->clk_crypt_mux))
- goto disable_caps;
+ ret = ufs_mtk_init_host_clk(hba, "crypt_mux", &cfg->clk_crypt_mux);
+ if (ret)
+ goto out;
- if (ufs_mtk_init_host_clk(hba, "crypt_lp",
- &cfg->clk_crypt_lp))
- goto disable_caps;
+ ret = ufs_mtk_init_host_clk(hba, "crypt_lp", &cfg->clk_crypt_lp);
+ if (ret)
+ goto out;
- if (ufs_mtk_init_host_clk(hba, "crypt_perf",
- &cfg->clk_crypt_perf))
- goto disable_caps;
+ ret = ufs_mtk_init_host_clk(hba, "crypt_perf", &cfg->clk_crypt_perf);
+ if (ret)
+ goto out;
cfg->reg_vcore = reg;
cfg->vcore_volt = volt;
host->caps |= UFS_MTK_CAP_BOOST_CRYPT_ENGINE;
-disable_caps:
- return;
+out:
+ if (ret)
+ devm_kfree(dev, host->crypt);
+ return 0;
}
static int ufs_mtk_init_va09_pwr_ctrl(struct ufs_hba *hba)
@@ -648,8 +652,9 @@ static int ufs_mtk_init_host_caps(struct ufs_hba *hba)
struct device_node *np = hba->dev->of_node;
int ret;
- if (of_property_read_bool(np, "mediatek,ufs-boost-crypt"))
- ufs_mtk_init_boost_crypt(hba);
+ ret = ufs_mtk_init_boost_crypt(hba);
+ if (ret)
+ return ret;
ret = ufs_mtk_init_va09_pwr_ctrl(hba);
if (ret)
--
2.44.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 4/8] scsi: ufs: ufs-mediatek: Avoid underscores in crypt clock names
2024-04-11 11:42 [PATCH v2 0/8] MediaTek UFS fixes and cleanups - Part 1 AngeloGioacchino Del Regno
` (2 preceding siblings ...)
2024-04-11 11:42 ` [PATCH v2 3/8] scsi: ufs: ufs-mediatek: Remove useless mediatek,ufs-boost-crypt property AngeloGioacchino Del Regno
@ 2024-04-11 11:42 ` AngeloGioacchino Del Regno
2024-04-11 11:42 ` [PATCH v2 5/8] dt-bindings: ufs: mediatek,ufs: Document MT8192 compatible with MT8183 AngeloGioacchino Del Regno
` (3 subsequent siblings)
7 siblings, 0 replies; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-04-11 11:42 UTC (permalink / raw
To: linux-scsi
Cc: alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg,
angelogioacchino.delregno, stanley.chu, devicetree, linux-kernel,
linux-mediatek, linux-arm-kernel
Change all of crypt_{mux,lp,perf} clock names to crypt-{mux,lp-perf}:
retaining compatibility with the old names is ignored as there is no
user of this driver declaring any of those clocks, and the binding
also doesn't allow these ones at all.
Fixes: 590b0d2372fe ("scsi: ufs-mediatek: Support performance mode for inline encryption engine")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/ufs/host/ufs-mediatek.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
index 47f16e6720f4..5db6d27f75af 100644
--- a/drivers/ufs/host/ufs-mediatek.c
+++ b/drivers/ufs/host/ufs-mediatek.c
@@ -604,15 +604,15 @@ static int ufs_mtk_init_boost_crypt(struct ufs_hba *hba)
return -ENOMEM;
cfg = host->crypt;
- ret = ufs_mtk_init_host_clk(hba, "crypt_mux", &cfg->clk_crypt_mux);
+ ret = ufs_mtk_init_host_clk(hba, "crypt-mux", &cfg->clk_crypt_mux);
if (ret)
goto out;
- ret = ufs_mtk_init_host_clk(hba, "crypt_lp", &cfg->clk_crypt_lp);
+ ret = ufs_mtk_init_host_clk(hba, "crypt-lp", &cfg->clk_crypt_lp);
if (ret)
goto out;
- ret = ufs_mtk_init_host_clk(hba, "crypt_perf", &cfg->clk_crypt_perf);
+ ret = ufs_mtk_init_host_clk(hba, "crypt-perf", &cfg->clk_crypt_perf);
if (ret)
goto out;
--
2.44.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 5/8] dt-bindings: ufs: mediatek,ufs: Document MT8192 compatible with MT8183
2024-04-11 11:42 [PATCH v2 0/8] MediaTek UFS fixes and cleanups - Part 1 AngeloGioacchino Del Regno
` (3 preceding siblings ...)
2024-04-11 11:42 ` [PATCH v2 4/8] scsi: ufs: ufs-mediatek: Avoid underscores in crypt clock names AngeloGioacchino Del Regno
@ 2024-04-11 11:42 ` AngeloGioacchino Del Regno
2024-04-11 15:07 ` Conor Dooley
2024-04-11 11:42 ` [PATCH v2 6/8] dt-bindings: ufs: mediatek,ufs: Document MT8195 compatible AngeloGioacchino Del Regno
` (2 subsequent siblings)
7 siblings, 1 reply; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-04-11 11:42 UTC (permalink / raw
To: linux-scsi
Cc: alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg,
angelogioacchino.delregno, stanley.chu, devicetree, linux-kernel,
linux-mediatek, linux-arm-kernel
The MT8192 UFS controller is compatible with the MT8183 one:
document this by allowing to assign both compatible strings
"mediatek,mt8192-ufshci", "mediatek,mt8183-ufshci" to the UFSHCI node.
In preparation for adding MT8195 to the mix, the MT8192 compatible
was added as enum instead of const.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../devicetree/bindings/ufs/mediatek,ufs.yaml | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
index 32fd535a514a..adcd13023866 100644
--- a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
@@ -14,9 +14,15 @@ allOf:
properties:
compatible:
- enum:
- - mediatek,mt8183-ufshci
- - mediatek,mt8192-ufshci
+ oneOf:
+ - items:
+ - enum:
+ - mediatek,mt8183-ufshci
+ - mediatek,mt8192-ufshci
+ - items:
+ - enum:
+ - mediatek,mt8192-ufshci
+ - const: mediatek,mt8183-ufshci
clocks:
maxItems: 1
--
2.44.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 6/8] dt-bindings: ufs: mediatek,ufs: Document MT8195 compatible
2024-04-11 11:42 [PATCH v2 0/8] MediaTek UFS fixes and cleanups - Part 1 AngeloGioacchino Del Regno
` (4 preceding siblings ...)
2024-04-11 11:42 ` [PATCH v2 5/8] dt-bindings: ufs: mediatek,ufs: Document MT8192 compatible with MT8183 AngeloGioacchino Del Regno
@ 2024-04-11 11:42 ` AngeloGioacchino Del Regno
2024-04-11 15:07 ` Conor Dooley
2024-04-11 11:42 ` [PATCH v2 7/8] dt-bindings: ufs: mediatek,ufs: Document additional clocks AngeloGioacchino Del Regno
2024-04-11 11:43 ` [PATCH v2 8/8] dt-bindings: ufs: mediatek,ufs: Document optional dvfsrc/va09 regulators AngeloGioacchino Del Regno
7 siblings, 1 reply; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-04-11 11:42 UTC (permalink / raw
To: linux-scsi
Cc: alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg,
angelogioacchino.delregno, stanley.chu, devicetree, linux-kernel,
linux-mediatek, linux-arm-kernel
Add the new mediatek,mt8195-ufshci string.
This SoC's UFSHCI controller is compatible with MT8183.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
index adcd13023866..e2c276da3f2c 100644
--- a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
@@ -22,6 +22,7 @@ properties:
- items:
- enum:
- mediatek,mt8192-ufshci
+ - mediatek,mt8195-ufshci
- const: mediatek,mt8183-ufshci
clocks:
--
2.44.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 7/8] dt-bindings: ufs: mediatek,ufs: Document additional clocks
2024-04-11 11:42 [PATCH v2 0/8] MediaTek UFS fixes and cleanups - Part 1 AngeloGioacchino Del Regno
` (5 preceding siblings ...)
2024-04-11 11:42 ` [PATCH v2 6/8] dt-bindings: ufs: mediatek,ufs: Document MT8195 compatible AngeloGioacchino Del Regno
@ 2024-04-11 11:42 ` AngeloGioacchino Del Regno
2024-04-11 15:10 ` Conor Dooley
2024-04-11 11:43 ` [PATCH v2 8/8] dt-bindings: ufs: mediatek,ufs: Document optional dvfsrc/va09 regulators AngeloGioacchino Del Regno
7 siblings, 1 reply; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-04-11 11:42 UTC (permalink / raw
To: linux-scsi
Cc: alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg,
angelogioacchino.delregno, stanley.chu, devicetree, linux-kernel,
linux-mediatek, linux-arm-kernel
Add additional clocks, used on all MediaTek SoCs' UFSHCI controllers:
some of these clocks are optional and used only for scaling purposes
to save power, or to improve performance in the case of the crypt
clocks.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../devicetree/bindings/ufs/mediatek,ufs.yaml | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
index e2c276da3f2c..21b038db100c 100644
--- a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
@@ -26,11 +26,23 @@ properties:
- const: mediatek,mt8183-ufshci
clocks:
- maxItems: 1
+ minItems: 1
clock-names:
+ minItems: 1
items:
- const: ufs
+ - const: ufs-aes
+ - const: ufs-tick
+ - const: unipro-sys
+ - const: unipro-tick
+ - const: ufs-sap
+ - const: ufs-tx-symbol
+ - const: ufs-rx-symbol
+ - const: ufs-mem
+ - const: crypt-mux
+ - const: crypt-lp
+ - const: crypt-perf
phys:
maxItems: 1
--
2.44.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 8/8] dt-bindings: ufs: mediatek,ufs: Document optional dvfsrc/va09 regulators
2024-04-11 11:42 [PATCH v2 0/8] MediaTek UFS fixes and cleanups - Part 1 AngeloGioacchino Del Regno
` (6 preceding siblings ...)
2024-04-11 11:42 ` [PATCH v2 7/8] dt-bindings: ufs: mediatek,ufs: Document additional clocks AngeloGioacchino Del Regno
@ 2024-04-11 11:43 ` AngeloGioacchino Del Regno
2024-04-11 15:11 ` Conor Dooley
7 siblings, 1 reply; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-04-11 11:43 UTC (permalink / raw
To: linux-scsi
Cc: alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg,
angelogioacchino.delregno, stanley.chu, devicetree, linux-kernel,
linux-mediatek, linux-arm-kernel
Document the optional dvfsrc-vcore and va09 regulators used for,
respectively, crypt boost and internal MPHY power management in
when powering on/off the (external) MediaTek UFS PHY.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
index 21b038db100c..2ee8bb7d5aac 100644
--- a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
@@ -50,6 +50,8 @@ properties:
reg:
maxItems: 1
+ dvfsrc-vcore-supply: true
+ va09-supply: true
vcc-supply: true
required:
--
2.44.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v2 5/8] dt-bindings: ufs: mediatek,ufs: Document MT8192 compatible with MT8183
2024-04-11 11:42 ` [PATCH v2 5/8] dt-bindings: ufs: mediatek,ufs: Document MT8192 compatible with MT8183 AngeloGioacchino Del Regno
@ 2024-04-11 15:07 ` Conor Dooley
2024-04-11 15:11 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 18+ messages in thread
From: Conor Dooley @ 2024-04-11 15:07 UTC (permalink / raw
To: AngeloGioacchino Del Regno
Cc: linux-scsi, alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg, stanley.chu,
devicetree, linux-kernel, linux-mediatek, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]
On Thu, Apr 11, 2024 at 01:42:57PM +0200, AngeloGioacchino Del Regno wrote:
> The MT8192 UFS controller is compatible with the MT8183 one:
> document this by allowing to assign both compatible strings
> "mediatek,mt8192-ufshci", "mediatek,mt8183-ufshci" to the UFSHCI node.
>
> In preparation for adding MT8195 to the mix, the MT8192 compatible
> was added as enum instead of const.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../devicetree/bindings/ufs/mediatek,ufs.yaml | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> index 32fd535a514a..adcd13023866 100644
> --- a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> @@ -14,9 +14,15 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - mediatek,mt8183-ufshci
> - - mediatek,mt8192-ufshci
> + oneOf:
> + - items:
> + - enum:
> + - mediatek,mt8183-ufshci
> + - mediatek,mt8192-ufshci
> + - items:
> + - enum:
> + - mediatek,mt8192-ufshci
> + - const: mediatek,mt8183-ufshci
It's a bit more distruptive since you'll have to modify a dts, but why
permit both of these ways of describing the mt8192? Could we drop it
from the original enum and no longer allow it in isolation? There
shouldn't be any compatibility concerns with doing so.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 6/8] dt-bindings: ufs: mediatek,ufs: Document MT8195 compatible
2024-04-11 11:42 ` [PATCH v2 6/8] dt-bindings: ufs: mediatek,ufs: Document MT8195 compatible AngeloGioacchino Del Regno
@ 2024-04-11 15:07 ` Conor Dooley
0 siblings, 0 replies; 18+ messages in thread
From: Conor Dooley @ 2024-04-11 15:07 UTC (permalink / raw
To: AngeloGioacchino Del Regno
Cc: linux-scsi, alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg, stanley.chu,
devicetree, linux-kernel, linux-mediatek, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
On Thu, Apr 11, 2024 at 01:42:58PM +0200, AngeloGioacchino Del Regno wrote:
> Add the new mediatek,mt8195-ufshci string.
> This SoC's UFSHCI controller is compatible with MT8183.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 7/8] dt-bindings: ufs: mediatek,ufs: Document additional clocks
2024-04-11 11:42 ` [PATCH v2 7/8] dt-bindings: ufs: mediatek,ufs: Document additional clocks AngeloGioacchino Del Regno
@ 2024-04-11 15:10 ` Conor Dooley
2024-04-11 15:14 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 18+ messages in thread
From: Conor Dooley @ 2024-04-11 15:10 UTC (permalink / raw
To: AngeloGioacchino Del Regno
Cc: linux-scsi, alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg, stanley.chu,
devicetree, linux-kernel, linux-mediatek, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]
On Thu, Apr 11, 2024 at 01:42:59PM +0200, AngeloGioacchino Del Regno wrote:
> Add additional clocks, used on all MediaTek SoCs' UFSHCI controllers:
I appreciate being told they're on all, rather than it being unsaid and
having to ask.
> some of these clocks are optional and used only for scaling purposes
> to save power, or to improve performance in the case of the crypt
> clocks.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../devicetree/bindings/ufs/mediatek,ufs.yaml | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> index e2c276da3f2c..21b038db100c 100644
> --- a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> @@ -26,11 +26,23 @@ properties:
> - const: mediatek,mt8183-ufshci
>
> clocks:
> - maxItems: 1
> + minItems: 1
Could you add an itemised list to the clocks property please?
>
> clock-names:
> + minItems: 1
> items:
> - const: ufs
> + - const: ufs-aes
> + - const: ufs-tick
> + - const: unipro-sys
> + - const: unipro-tick
> + - const: ufs-sap
> + - const: ufs-tx-symbol
> + - const: ufs-rx-symbol
> + - const: ufs-mem
> + - const: crypt-mux
> + - const: crypt-lp
> + - const: crypt-perf
>
> phys:
> maxItems: 1
> --
> 2.44.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 5/8] dt-bindings: ufs: mediatek,ufs: Document MT8192 compatible with MT8183
2024-04-11 15:07 ` Conor Dooley
@ 2024-04-11 15:11 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-04-11 15:11 UTC (permalink / raw
To: Conor Dooley
Cc: linux-scsi, alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg, stanley.chu,
devicetree, linux-kernel, linux-mediatek, linux-arm-kernel
Il 11/04/24 17:07, Conor Dooley ha scritto:
> On Thu, Apr 11, 2024 at 01:42:57PM +0200, AngeloGioacchino Del Regno wrote:
>> The MT8192 UFS controller is compatible with the MT8183 one:
>> document this by allowing to assign both compatible strings
>> "mediatek,mt8192-ufshci", "mediatek,mt8183-ufshci" to the UFSHCI node.
>>
>> In preparation for adding MT8195 to the mix, the MT8192 compatible
>> was added as enum instead of const.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>> .../devicetree/bindings/ufs/mediatek,ufs.yaml | 12 +++++++++---
>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
>> index 32fd535a514a..adcd13023866 100644
>> --- a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
>> +++ b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
>> @@ -14,9 +14,15 @@ allOf:
>>
>> properties:
>> compatible:
>> - enum:
>> - - mediatek,mt8183-ufshci
>> - - mediatek,mt8192-ufshci
>> + oneOf:
>> + - items:
>> + - enum:
>> + - mediatek,mt8183-ufshci
>> + - mediatek,mt8192-ufshci
>> + - items:
>> + - enum:
>> + - mediatek,mt8192-ufshci
>> + - const: mediatek,mt8183-ufshci
>
> It's a bit more distruptive since you'll have to modify a dts, but why
> permit both of these ways of describing the mt8192? Could we drop it
> from the original enum and no longer allow it in isolation? There
> shouldn't be any compatibility concerns with doing so.
Yes, will remove that in v3 :-)
Thanks!
Angelo
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 8/8] dt-bindings: ufs: mediatek,ufs: Document optional dvfsrc/va09 regulators
2024-04-11 11:43 ` [PATCH v2 8/8] dt-bindings: ufs: mediatek,ufs: Document optional dvfsrc/va09 regulators AngeloGioacchino Del Regno
@ 2024-04-11 15:11 ` Conor Dooley
2024-04-11 15:15 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 18+ messages in thread
From: Conor Dooley @ 2024-04-11 15:11 UTC (permalink / raw
To: AngeloGioacchino Del Regno
Cc: linux-scsi, alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg, stanley.chu,
devicetree, linux-kernel, linux-mediatek, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
On Thu, Apr 11, 2024 at 01:43:00PM +0200, AngeloGioacchino Del Regno wrote:
> Document the optional dvfsrc-vcore and va09 regulators used for,
> respectively, crypt boost and internal MPHY power management in
> when powering on/off the (external) MediaTek UFS PHY.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
btw:
<stanley.chu@mediatek.com>: host mailgw01.mediatek.com[216.200.240.184] said:
550 Relaying mail to stanley.chu@mediatek.com is not allowed (in reply to
RCPT TO command)
We should probably delete them from the binding (and maybe add yourself).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 7/8] dt-bindings: ufs: mediatek,ufs: Document additional clocks
2024-04-11 15:10 ` Conor Dooley
@ 2024-04-11 15:14 ` AngeloGioacchino Del Regno
2024-04-11 15:18 ` Conor Dooley
0 siblings, 1 reply; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-04-11 15:14 UTC (permalink / raw
To: Conor Dooley
Cc: linux-scsi, alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg, stanley.chu,
devicetree, linux-kernel, linux-mediatek, linux-arm-kernel
Il 11/04/24 17:10, Conor Dooley ha scritto:
> On Thu, Apr 11, 2024 at 01:42:59PM +0200, AngeloGioacchino Del Regno wrote:
>> Add additional clocks, used on all MediaTek SoCs' UFSHCI controllers:
>
> I appreciate being told they're on all, rather than it being unsaid and
> having to ask.
>
You're welcome :-)
>> some of these clocks are optional and used only for scaling purposes
>> to save power, or to improve performance in the case of the crypt
>> clocks.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>> .../devicetree/bindings/ufs/mediatek,ufs.yaml | 14 +++++++++++++-
>> 1 file changed, 13 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
>> index e2c276da3f2c..21b038db100c 100644
>> --- a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
>> +++ b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
>> @@ -26,11 +26,23 @@ properties:
>> - const: mediatek,mt8183-ufshci
>>
>> clocks:
>> - maxItems: 1
>> + minItems: 1
>
> Could you add an itemised list to the clocks property please?
>
Not really... Honestly, I'm not confident that the description will be 100%
correct for all of them... can we do that at a later time, when I will be
really that much confident in writing down a proper description for each
of them?
The only thing that I'm really sure of is exactly what I wrote in this commit,
nothing less, nothing more... for now :')
Cheers,
Angelo
>>
>> clock-names:
>> + minItems: 1
>> items:
>> - const: ufs
>> + - const: ufs-aes
>
>
>> + - const: ufs-tick
>> + - const: unipro-sys
>> + - const: unipro-tick
>> + - const: ufs-sap
>> + - const: ufs-tx-symbol
>> + - const: ufs-rx-symbol
>> + - const: ufs-mem
>> + - const: crypt-mux
>> + - const: crypt-lp
>> + - const: crypt-perf
>>
>> phys:
>> maxItems: 1
>> --
>> 2.44.0
>>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 8/8] dt-bindings: ufs: mediatek,ufs: Document optional dvfsrc/va09 regulators
2024-04-11 15:11 ` Conor Dooley
@ 2024-04-11 15:15 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-04-11 15:15 UTC (permalink / raw
To: Conor Dooley
Cc: linux-scsi, alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg, stanley.chu,
devicetree, linux-kernel, linux-mediatek, linux-arm-kernel
Il 11/04/24 17:11, Conor Dooley ha scritto:
> On Thu, Apr 11, 2024 at 01:43:00PM +0200, AngeloGioacchino Del Regno wrote:
>> Document the optional dvfsrc-vcore and va09 regulators used for,
>> respectively, crypt boost and internal MPHY power management in
>> when powering on/off the (external) MediaTek UFS PHY.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> btw:
> <stanley.chu@mediatek.com>: host mailgw01.mediatek.com[216.200.240.184] said:
> 550 Relaying mail to stanley.chu@mediatek.com is not allowed (in reply to
> RCPT TO command)
>
> We should probably delete them from the binding (and maybe add yourself).
Yeah, count that done for v3 (tomorrow)!
Cheers
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 7/8] dt-bindings: ufs: mediatek,ufs: Document additional clocks
2024-04-11 15:14 ` AngeloGioacchino Del Regno
@ 2024-04-11 15:18 ` Conor Dooley
2024-04-11 15:23 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 18+ messages in thread
From: Conor Dooley @ 2024-04-11 15:18 UTC (permalink / raw
To: AngeloGioacchino Del Regno
Cc: linux-scsi, alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg, stanley.chu,
devicetree, linux-kernel, linux-mediatek, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 2656 bytes --]
On Thu, Apr 11, 2024 at 05:14:34PM +0200, AngeloGioacchino Del Regno wrote:
> Il 11/04/24 17:10, Conor Dooley ha scritto:
> > On Thu, Apr 11, 2024 at 01:42:59PM +0200, AngeloGioacchino Del Regno wrote:
> > > Add additional clocks, used on all MediaTek SoCs' UFSHCI controllers:
> >
> > I appreciate being told they're on all, rather than it being unsaid and
> > having to ask.
> >
>
> You're welcome :-)
>
> > > some of these clocks are optional and used only for scaling purposes
> > > to save power, or to improve performance in the case of the crypt
> > > clocks.
> > >
> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > > ---
> > > .../devicetree/bindings/ufs/mediatek,ufs.yaml | 14 +++++++++++++-
> > > 1 file changed, 13 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> > > index e2c276da3f2c..21b038db100c 100644
> > > --- a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> > > +++ b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> > > @@ -26,11 +26,23 @@ properties:
> > > - const: mediatek,mt8183-ufshci
> > > clocks:
> > > - maxItems: 1
> > > + minItems: 1
> >
> > Could you add an itemised list to the clocks property please?
> >
>
> Not really... Honestly, I'm not confident that the description will be 100%
> correct for all of them... can we do that at a later time, when I will be
> really that much confident in writing down a proper description for each
> of them?
>
> The only thing that I'm really sure of is exactly what I wrote in this commit,
> nothing less, nothing more... for now :')
fwiw, my motivation here was a better explanation for what "ufs" means
as a clock. When the block has some "ufs" clock and a "axi" clock it's
kinda clear what they do, but with 7 ufs clocks now, it's not really
clear what the bare "ufs" one actually does.
If you can't provide an itemised list, please set maxitems.
> > > clock-names:
> > > + minItems: 1
> > > items:
> > > - const: ufs
> > > + - const: ufs-aes
> >
> >
> > > + - const: ufs-tick
> > > + - const: unipro-sys
> > > + - const: unipro-tick
> > > + - const: ufs-sap
> > > + - const: ufs-tx-symbol
> > > + - const: ufs-rx-symbol
> > > + - const: ufs-mem
> > > + - const: crypt-mux
> > > + - const: crypt-lp
> > > + - const: crypt-perf
> > > phys:
> > > maxItems: 1
> > > --
> > > 2.44.0
> > >
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 7/8] dt-bindings: ufs: mediatek,ufs: Document additional clocks
2024-04-11 15:18 ` Conor Dooley
@ 2024-04-11 15:23 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-04-11 15:23 UTC (permalink / raw
To: Conor Dooley
Cc: linux-scsi, alim.akhtar, avri.altman, bvanassche, robh,
krzysztof.kozlowski+dt, conor+dt, peter.wang, chu.stanley, jejb,
martin.petersen, lgirdwood, broonie, matthias.bgg, stanley.chu,
devicetree, linux-kernel, linux-mediatek, linux-arm-kernel
Il 11/04/24 17:18, Conor Dooley ha scritto:
> On Thu, Apr 11, 2024 at 05:14:34PM +0200, AngeloGioacchino Del Regno wrote:
>> Il 11/04/24 17:10, Conor Dooley ha scritto:
>>> On Thu, Apr 11, 2024 at 01:42:59PM +0200, AngeloGioacchino Del Regno wrote:
>>>> Add additional clocks, used on all MediaTek SoCs' UFSHCI controllers:
>>>
>>> I appreciate being told they're on all, rather than it being unsaid and
>>> having to ask.
>>>
>>
>> You're welcome :-)
>>
>>>> some of these clocks are optional and used only for scaling purposes
>>>> to save power, or to improve performance in the case of the crypt
>>>> clocks.
>>>>
>>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>>> ---
>>>> .../devicetree/bindings/ufs/mediatek,ufs.yaml | 14 +++++++++++++-
>>>> 1 file changed, 13 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
>>>> index e2c276da3f2c..21b038db100c 100644
>>>> --- a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
>>>> +++ b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
>>>> @@ -26,11 +26,23 @@ properties:
>>>> - const: mediatek,mt8183-ufshci
>>>> clocks:
>>>> - maxItems: 1
>>>> + minItems: 1
>>>
>>> Could you add an itemised list to the clocks property please?
>>>
>>
>> Not really... Honestly, I'm not confident that the description will be 100%
>> correct for all of them... can we do that at a later time, when I will be
>> really that much confident in writing down a proper description for each
>> of them?
>>
>> The only thing that I'm really sure of is exactly what I wrote in this commit,
>> nothing less, nothing more... for now :')
>
> fwiw, my motivation here was a better explanation for what "ufs" means
> as a clock. When the block has some "ufs" clock and a "axi" clock it's
> kinda clear what they do, but with 7 ufs clocks now, it's not really
> clear what the bare "ufs" one actually does.
>
> If you can't provide an itemised list, please set maxitems.
>
Not exactly right now, as I said. I will set maxItems instead.
By the way, "ufs" == "core", I didn't want to rename that one to avoid
breaking changes, of course.
>>>> clock-names:
>>>> + minItems: 1
>>>> items:
>>>> - const: ufs
>>>> + - const: ufs-aes
>>>
>>>
>>>> + - const: ufs-tick
>>>> + - const: unipro-sys
>>>> + - const: unipro-tick
>>>> + - const: ufs-sap
>>>> + - const: ufs-tx-symbol
>>>> + - const: ufs-rx-symbol
>>>> + - const: ufs-mem
>>>> + - const: crypt-mux
>>>> + - const: crypt-lp
>>>> + - const: crypt-perf
>>>> phys:
>>>> maxItems: 1
>>>> --
>>>> 2.44.0
>>>>
>>
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2024-04-11 15:23 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-11 11:42 [PATCH v2 0/8] MediaTek UFS fixes and cleanups - Part 1 AngeloGioacchino Del Regno
2024-04-11 11:42 ` [PATCH v2 1/8] scsi: ufs: ufs-mediatek: Remove useless mediatek,ufs-support-va09 property AngeloGioacchino Del Regno
2024-04-11 11:42 ` [PATCH v2 2/8] scsi: ufs: ufs-mediatek: Fix property name for crypt boost voltage AngeloGioacchino Del Regno
2024-04-11 11:42 ` [PATCH v2 3/8] scsi: ufs: ufs-mediatek: Remove useless mediatek,ufs-boost-crypt property AngeloGioacchino Del Regno
2024-04-11 11:42 ` [PATCH v2 4/8] scsi: ufs: ufs-mediatek: Avoid underscores in crypt clock names AngeloGioacchino Del Regno
2024-04-11 11:42 ` [PATCH v2 5/8] dt-bindings: ufs: mediatek,ufs: Document MT8192 compatible with MT8183 AngeloGioacchino Del Regno
2024-04-11 15:07 ` Conor Dooley
2024-04-11 15:11 ` AngeloGioacchino Del Regno
2024-04-11 11:42 ` [PATCH v2 6/8] dt-bindings: ufs: mediatek,ufs: Document MT8195 compatible AngeloGioacchino Del Regno
2024-04-11 15:07 ` Conor Dooley
2024-04-11 11:42 ` [PATCH v2 7/8] dt-bindings: ufs: mediatek,ufs: Document additional clocks AngeloGioacchino Del Regno
2024-04-11 15:10 ` Conor Dooley
2024-04-11 15:14 ` AngeloGioacchino Del Regno
2024-04-11 15:18 ` Conor Dooley
2024-04-11 15:23 ` AngeloGioacchino Del Regno
2024-04-11 11:43 ` [PATCH v2 8/8] dt-bindings: ufs: mediatek,ufs: Document optional dvfsrc/va09 regulators AngeloGioacchino Del Regno
2024-04-11 15:11 ` Conor Dooley
2024-04-11 15:15 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).