Linux-mediatek Archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: devicetree@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
	 Lorenzo Bianconi <lorenzo@kernel.org>,
	Ryder Lee <ryder.lee@mediatek.com>,
	 Shayne Chen <shayne.chen@mediatek.com>,
	Sean Wang <sean.wang@mediatek.com>,
	 Johannes Berg <johannes@sipsolutions.net>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Matthias Brugger <matthias.bgg@gmail.com>,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	 "open list:MEDIATEK MT76 WIRELESS LAN DRIVER"
	<linux-wireless@vger.kernel.org>,
	 "open list:ARM/Mediatek SoC support"
	<linux-kernel@vger.kernel.org>,
	 "moderated list:ARM/Mediatek SoC support"
	<linux-arm-kernel@lists.infradead.org>,
	 "moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	"open list:MIPS" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH 2/3] dt-bindings: net: wireless: mt76: remove mediatek,mtd-eeprom
Date: Tue, 28 Apr 2026 09:33:00 +0200	[thread overview]
Message-ID: <20260428-mustang-of-therapeutic-upgrade-a95f9a@quoll> (raw)
In-Reply-To: <20260427034427.881389-3-rosenp@gmail.com>

On Sun, Apr 26, 2026 at 08:44:26PM -0700, Rosen Penev wrote:
> mediatek,mtd-eeprom is a widely unused binding that predates and has

I clearly see a user. Please use `git grep`.
 
> been replaced by NVMEM. As there are no users, remove it.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  .../bindings/net/wireless/mediatek,mt76.yaml  | 19 ++-----------------
>  1 file changed, 2 insertions(+), 17 deletions(-)
> 

Wrong order of patches, you have undocumented ABI.

Best regards,
Krzysztof



  reply	other threads:[~2026-04-28  7:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27  3:44 [PATCH 0/3] wifi: mt76: remove mediatek,mtd-eeprom Rosen Penev
2026-04-27  3:44 ` [PATCH 1/3] MIPS: dts: ralink: gardena_smart_gateway_mt7688: use nvmem for EEPROM Rosen Penev
2026-04-27  3:44 ` [PATCH 2/3] dt-bindings: net: wireless: mt76: remove mediatek,mtd-eeprom Rosen Penev
2026-04-28  7:33   ` Krzysztof Kozlowski [this message]
2026-04-27  3:44 ` [PATCH 3/3] wifi: mt76: remove mt76_get_of_data_from_mtd Rosen Penev
2026-04-27 19:09   ` Conor Dooley
2026-04-27 19:17     ` Rosen Penev
2026-04-27 20:02       ` Conor Dooley
2026-04-27 20:04         ` Conor Dooley
2026-04-28  7:32   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260428-mustang-of-therapeutic-upgrade-a95f9a@quoll \
    --to=krzk@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nbd@nbd.name \
    --cc=robh@kernel.org \
    --cc=rosenp@gmail.com \
    --cc=ryder.lee@mediatek.com \
    --cc=sean.wang@mediatek.com \
    --cc=shayne.chen@mediatek.com \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).