From: Krzysztof Kozlowski <krzk@kernel.org>
To: mtk20898 <zhengnan.chen@mediatek.com>
Cc: Yong Wu <yong.wu@mediatek.com>, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [RESEND,v2 1/2] dt-bindings: memory-controllers: mtk-smi: Add support for mt8189
Date: Tue, 28 Apr 2026 08:26:07 +0200 [thread overview]
Message-ID: <20260428-topaz-turtle-of-support-f5b9ec@quoll> (raw)
In-Reply-To: <20260427070444.20247-2-zhengnan.chen@mediatek.com>
On Mon, Apr 27, 2026 at 03:04:28PM +0800, mtk20898 wrote:
> properties:
> compatible:
> oneOf:
> @@ -40,6 +55,8 @@ properties:
> - mediatek,mt8186-smi-common
> - mediatek,mt8188-smi-common-vdo
> - mediatek,mt8188-smi-common-vpp
> + - mediatek,mt8189-smi-common
> + - mediatek,mt8189-smi-sub-common
> - mediatek,mt8192-smi-common
> - mediatek,mt8195-smi-common-vdo
> - mediatek,mt8195-smi-common-vpp
> @@ -108,19 +125,23 @@ allOf:
> compatible:
> contains:
> enum:
> + - mediatek,mt8189-smi-sub-common
> - mediatek,mt8195-smi-sub-common
> then:
> required:
> - mediatek,smi
> properties:
> clocks:
> - minItems: 3
> + minItems: 2
Same problem as v2 before resend.
Please explain me how mt8195 requires three clocks. You can prove it by
trying a malformed DTS (past here the snippet/diff) and pasting here the
validation error.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-28 6:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 7:04 [RESEND,v2 0/2] MT8189 SMI SUPPORT mtk20898
2026-04-27 7:04 ` [RESEND,v2 1/2] dt-bindings: memory-controllers: mtk-smi: Add support for mt8189 mtk20898
2026-04-28 6:26 ` Krzysztof Kozlowski [this message]
2026-04-30 7:22 ` Zhengnan Chen (陈征南)
2026-05-24 19:08 ` Krzysztof Kozlowski
2026-06-06 8:06 ` Zhengnan Chen (陈征南)
2026-04-27 7:04 ` [RESEND,v2 2/2] memory: mtk-smi: Add mt8189 support mtk20898
2026-05-09 8:00 ` Yong Wu (吴勇)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428-topaz-turtle-of-support-f5b9ec@quoll \
--to=krzk@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=yong.wu@mediatek.com \
--cc=zhengnan.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).