From: Krzysztof Kozlowski <krzk@kernel.org>
To: Zhi Mao <zhi.mao@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Heiko Stuebner <heiko@sntech.de>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Hans de Goede <hdegoede@redhat.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Alain Volmat <alain.volmat@foss.st.com>,
Paul Elder <paul.elder@ideasonboard.com>,
Mehdi Djait <mehdi.djait@bootlin.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Bingbu Cao <bingbu.cao@intel.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, shengnan.wang@mediatek.com,
yaya.chang@mediatek.com, yunkec@chromium.org, 10572168@qq.com
Subject: Re: [PATCH v1 1/2] media: dt-bindings: i2c: add Giantec GT97xx VCM
Date: Mon, 22 Apr 2024 05:26:02 +0200 [thread overview]
Message-ID: <ce03bc0c-b113-44c3-8243-0fa22b8a95bf@kernel.org> (raw)
In-Reply-To: <20240420011840.23148-2-zhi.mao@mediatek.com>
On 20/04/2024 03:18, Zhi Mao wrote:
> Add YAML device tree binding for GT9768 & GT8769 VCM,
> and the relevant MAINTAINERS entries.
>
> Signed-off-by: Zhi Mao <zhi.mao@mediatek.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
If there is going to be any new version, then:
> .../bindings/media/i2c/giantec,gt9769.yaml | 56 +++++++++++++++++++
> 1 file changed, 56 insertions(+)
> +title: Giantec Semiconductor, Crop. GT9768 & GT9769 Voice Coil Motor (VCM)
> +
> +maintainers:
> + - Zhi Mao <zhi.mao@mediatek.com>
> +
> +description: |-
Drop |-
> + The Giantec GT9768 & GT9768 is a 10-bit DAC with current sink capability.
> + The DAC is controlled via I2C bus that operates at clock rates up to 1MHz.
> + This chip integrates Advanced Actuator Control (AAC) technology
> + and is intended for driving voice coil lens in camera modules.
> +
> +properties:
> + compatible:
> + enum:
> + - giantec,gt9768
> + - giantec,gt9769
> +
> + reg:
> + maxItems: 1
> +
> + vin-supply: true
> +
> + vdd-supply: true
> +
> +required:
> + - compatible
> + - reg
> + - vin-supply
> + - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +
Drop blank line
> + i2c {
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-22 3:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 1:18 [PATCH v1 0/2] media: i2c: Add support for GT97xx VCM Zhi Mao
2024-04-20 1:18 ` [PATCH v1 1/2] media: dt-bindings: i2c: add Giantec " Zhi Mao
2024-04-20 11:21 ` Krzysztof Kozlowski
2024-04-20 12:53 ` Kieran Bingham
2024-04-21 11:35 ` Kieran Bingham
2024-04-21 14:00 ` Krzysztof Kozlowski
2024-04-22 1:49 ` Zhi Mao (毛智)
2024-04-22 3:18 ` Krzysztof Kozlowski
2024-04-22 3:26 ` Krzysztof Kozlowski [this message]
2024-04-20 1:18 ` [PATCH v1 2/2] media: i2c: Add GT97xx VCM driver Zhi Mao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce03bc0c-b113-44c3-8243-0fa22b8a95bf@kernel.org \
--to=krzk@kernel.org \
--cc=10572168@qq.com \
--cc=alain.volmat@foss.st.com \
--cc=andy.shevchenko@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bingbu.cao@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=heiko@sntech.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=mehdi.djait@bootlin.com \
--cc=p.zabel@pengutronix.de \
--cc=paul.elder@ideasonboard.com \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shengnan.wang@mediatek.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=yaya.chang@mediatek.com \
--cc=yunkec@chromium.org \
--cc=zhi.mao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).