From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-metag@vger.kernel.org, James Hogan <james.hogan@imgtec.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH] metag-TCM: Delete an error message for a failed memory allocation in tcm_add_region()
Date: Thu, 11 May 2017 16:23:31 +0200 [thread overview]
Message-ID: <39aa4ad5-ba12-ee30-1ca9-8699acde521b@users.sourceforge.net> (raw)
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 11 May 2017 16:16:32 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/metag/kernel/tcm.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/metag/kernel/tcm.c b/arch/metag/kernel/tcm.c
index 5d102b31ce84..6c9985591cf1 100644
--- a/arch/metag/kernel/tcm.c
+++ b/arch/metag/kernel/tcm.c
@@ -115,10 +115,8 @@ int __init tcm_add_region(struct tcm_region *reg)
struct tcm_pool *pool;
pool = kmalloc(sizeof(*pool), GFP_KERNEL);
- if (!pool) {
- pr_err("Failed to alloc memory for TCM pool!\n");
+ if (!pool)
return -ENOMEM;
- }
pool->tag = reg->tag;
pool->start = reg->res.start;
--
2.12.3
reply other threads:[~2017-05-11 14:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39aa4ad5-ba12-ee30-1ca9-8699acde521b@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=james.hogan@imgtec.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).