From: Nicolas Schier <nsc@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Arnd Bergmann <arnd@arndb.de>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nsc@kernel.org>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v2 3/3] checksyscalls: move instance functionality into generic code
Date: Thu, 02 Apr 2026 16:18:50 +0200 [thread overview]
Message-ID: <177513953036.3276215.12313311452820248264.b4-review@b4> (raw)
In-Reply-To: <20260324-kbuild-missing-syscalls-v2-3-651b8beb0bfd@weissschuh.net>
On Tue, 24 Mar 2026 18:16:47 +0100, Thomas Weißschuh <linux@weissschuh.net> wrote:
> diff --git a/Kbuild b/Kbuild
> index 515cc6a27477..fb547bc5ff41 100644
> --- a/Kbuild
> +++ b/Kbuild
> @@ -47,11 +47,11 @@ $(rq-offsets-file): kernel/sched/rq-offsets.s FORCE
>
> # Check for missing system calls
>
> -missing-syscalls-file := .tmp_missing-syscalls
> +missing-syscalls-file := .tmp_missing-syscalls$(missing_syscalls_instance)
>
> targets += $(missing-syscalls-file)
>
> -quiet_cmd_syscalls = CALL $<
> +quiet_cmd_syscalls = CALL $< $(if $(missing_syscalls_instance),for $(missing_syscalls_instance))
Nice solution!
$(addprefix) shortens a bit here:
quiet_cmd_syscalls = CALL $< $(addprefix for ,$(missing_syscalls_instance))
--
Nicolas
next prev parent reply other threads:[~2026-04-02 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 17:16 [PATCH v2 0/3] checksyscalls: only run when necessary Thomas Weißschuh
2026-03-24 17:16 ` [PATCH v2 1/3] checksyscalls: move path to reference table to a variable Thomas Weißschuh
2026-03-24 17:16 ` [PATCH v2 2/3] checksyscalls: only run when necessary Thomas Weißschuh
2026-03-24 17:16 ` [PATCH v2 3/3] checksyscalls: move instance functionality into generic code Thomas Weißschuh
2026-04-02 14:18 ` Nicolas Schier [this message]
2026-03-24 17:29 ` [PATCH v2 0/3] checksyscalls: only run when necessary Arnd Bergmann
2026-04-02 14:18 ` Nicolas Schier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177513953036.3276215.12313311452820248264.b4-review@b4 \
--to=nsc@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=nathan@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).