Linux-MIPS Archive mirror
 help / color / mirror / Atom feed

From: Pengpeng Hou <pengpeng@iscas.ac.cn>
To: Sergey Shtylyov <sergei.shtylyov@gmail.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	"Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	pengpeng@iscas.ac.cn
Subject: Re: [PATCH 7/8] MIPS: malta-init: bound default console command-line append
Date: Mon, 6 Apr 2026 13:30:00 +0800	[thread overview]
Message-ID: <20260406133000.1-mips-malta-init-reply-pengpeng@iscas.ac.cn> (raw)
In-Reply-To: <20260405102007.7-mips-cmdline-pengpeng@iscas.ac.cn>

Hi Sergey,

Thanks, you're right.

There is no intended control-flow change here. The only intended
functional change in this hunk is replacing the unchecked

  strcat(fw_getcmdline(), console_string);

with a bounded append.

The surrounding brace movement is accidental diff noise, and it makes the
patch much harder to read than it should be. I will clean this up in the
next revision so the hunk only shows the actual append change.

Thanks,
Pengpeng

next prev parent reply	other threads:[~2026-04-06  0:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-05  2:20 [PATCH 0/8] MIPS: bound early command-line construction Pengpeng Hou
2026-04-04 14:06 ` [PATCH 1/8] MIPS: dec: bound PROM command-line appends Pengpeng Hou
2026-04-04 14:06 ` [PATCH 3/8] MIPS: lemote-2f: bound machtype command-line append Pengpeng Hou
2026-04-04 14:06 ` [PATCH 2/8] MIPS: sni: bound PROM command-line appends Pengpeng Hou
2026-04-04 14:06 ` [PATCH 6/8] MIPS: cavium-octeon: bound default console command-line append Pengpeng Hou
2026-04-04 14:06 ` [PATCH 7/8] MIPS: malta-init: " Pengpeng Hou
2026-04-05 16:08   ` Sergey Shtylyov
2026-04-06  5:30   ` Pengpeng Hou [this message]
2026-04-04 14:06 ` [PATCH 8/8] MIPS: malta-setup: bound pci_clock " Pengpeng Hou
2026-04-04 14:06 ` [PATCH 5/8] MIPS: arc: bound firmware command-line construction Pengpeng Hou
2026-04-04 14:06 ` [PATCH 4/8] MIPS: txx9: bound command-line reconstruction Pengpeng Hou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260406133000.1-mips-malta-init-reply-pengpeng@iscas.ac.cn \
    --to=pengpeng@iscas.ac.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=macro@orcam.me.uk \
    --cc=sergei.shtylyov@gmail.com \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).