From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>, Lee Jones <lee@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"paulburton@kernel.org" <paulburton@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: mfd: syscon: Add img,boston-platform-regs
Date: Fri, 17 May 2024 10:58:38 +0200 [thread overview]
Message-ID: <2245e750-0b5d-49d1-88f3-7c1c75f275e7@kernel.org> (raw)
In-Reply-To: <61445fe0-9137-44a6-ab36-ffb8985254df@app.fastmail.com>
On 15/05/2024 23:44, Jiaxun Yang wrote:
>
>
> 在2024年5月14日五月 上午10:11，Krzysztof Kozlowski写道：
>> On 14/05/2024 11:08, Krzysztof Kozlowski wrote:
>>> On 13/05/2024 20:58, Jiaxun Yang wrote:
>>>> This compatible has been used in arch/mips/boot/dts/img/boston.dts
>>>> for a while but never documented properly.
>>>>
>>>> Add it to simple syscon binding.
>>>>
>>>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>>>> ---
>>>> Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>>>
>>> It is documented in clock/img,boston-clock.txt. Please fix/convert/work
>>> on that.
>>
>> No, that's different device.
>>
>> Anyway, this is wrong - does no work with your second patch. Please test
>> them before sending.
>
> Hi Krzysztof,
>
> Do you mind telling dumb as me how to test bindings properly?
>
> I tried to run make check_dtbs after applying this patch and that's all
> the warnings I got:
> ```
> arch/mips/boot/dts/img/boston.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'
> /home/flygoat/linux-next/arch/mips/boot/dts/img/boston.dtb: /: 'model' is a required property
> from schema $id: http://devicetree.org/schemas/root-node.yaml#
> arch/mips/boot/dts/img/boston.dtb: /: failed to match any schema with compatible: ['img,boston']
> arch/mips/boot/dts/img/boston.dtb: /cpus/cpu@0: failed to match any schema with compatible: ['img,mips']
> arch/mips/boot/dts/img/boston.dtb: /system-controller@17ffd000/clock: failed to match any schema with compatible: ['img,boston-clock']
> /home/flygoat/linux-next/arch/mips/boot/dts/img/boston.dtb: uart@17ffe000: $nodename:0: 'uart@17ffe000' does not match '^serial(@.*)?$'
> from schema $id: http://devicetree.org/schemas/serial/8250.yaml#
> ```
>
> I think there is no new warning introduced by this patch.
> Did I miss anything here?
Indeed there might be no warning for this, because syscon allows a lot,
including children. You need custom binding anyway.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-17 8:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 18:58 [PATCH 0/2] MIPS: Boston: Fix syscon devicetree binding and node Jiaxun Yang
2024-05-13 18:58 ` [PATCH 1/2] dt-bindings: mfd: syscon: Add img,boston-platform-regs Jiaxun Yang
2024-05-14 9:08 ` Krzysztof Kozlowski
2024-05-14 9:11 ` Krzysztof Kozlowski
2024-05-15 21:44 ` Jiaxun Yang
2024-05-17 8:58 ` Krzysztof Kozlowski [this message]
2024-05-17 10:15 ` Jiaxun Yang
2024-05-18 19:26 ` Krzysztof Kozlowski
2024-05-13 18:58 ` [PATCH 2/2] MIPS: dts: Boston: Add simple-mfd compatible Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2245e750-0b5d-49d1-88f3-7c1c75f275e7@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=robh@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).