From: Mark Brown <broonie@kernel.org>
To: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
Cc: paul@crapouillou.net, linux-mips@vger.kernel.org,
lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: jz4725b: Convert to devm_clk_get_enabled()
Date: Mon, 23 Mar 2026 16:46:02 +0000 [thread overview]
Message-ID: <6ea39b8f-289e-4327-9495-384f30866d4f@sirena.org.uk> (raw)
In-Reply-To: <20260323161551.47181-2-jihed.chaibi.dev@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
On Mon, Mar 23, 2026 at 05:15:49PM +0100, Jihed Chaibi wrote:
> Use devm_clk_get_enabled() instead, which combines the get, prepare and
> enable operations into one call whose lifetime is tied to the device.
> This removes the need for explicit enable/disable in the component
> probe/remove callbacks, and ensures that clock enable failures are
> propagated as errors rather than silently ignored.
This will increase power consumption a little bit in the case where we
don't actually instantiate a sound card, the clocks will be turned on at
device probe time. How often these systems don't have a sound card, and
how noticable the additional power consumption from running the clocks
is, are separate questions - it might not be worth worrying about.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-03-23 16:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 16:15 [PATCH 0/3] ASoC: jz47xx: Convert to devm_clk_get_enabled() Jihed Chaibi
2026-03-23 16:15 ` [PATCH 1/3] ASoC: jz4725b: " Jihed Chaibi
2026-03-23 16:46 ` Mark Brown [this message]
2026-03-23 16:15 ` [PATCH 2/3] ASoC: jz4760: " Jihed Chaibi
2026-03-23 16:15 ` [PATCH 3/3] ASoC: jz4770: " Jihed Chaibi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ea39b8f-289e-4327-9495-384f30866d4f@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jihed.chaibi.dev@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).