From: Huacai Chen <chenhuacai@kernel.org>
To: Binbin Zhou <zhoubb.aaron@gmail.com>
Cc: Frank Li <Frank.li@nxp.com>, Binbin Zhou <zhoubinbin@loongson.cn>,
Huacai Chen <chenhuacai@loongson.cn>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org,
Xiaochuang Mao <maoxiaochuan@loongson.cn>,
Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev, devicetree@vger.kernel.org,
Keguang Zhang <keguang.zhang@gmail.com>,
linux-mips@vger.kernel.org, jeffbai@aosc.io
Subject: Re: [PATCH v2 1/4] dmaengine: loongson: New directory for Loongson DMA controllers drivers
Date: Thu, 26 Feb 2026 16:07:17 +0800 [thread overview]
Message-ID: <CAAhV-H5ODRYLC=cmhWzkkxAMNJK1SRT9b-L+eQEqzhJKtmENhQ@mail.gmail.com> (raw)
In-Reply-To: <CAMpQs4+NHVQTcxdsBYp6H7c4FZpsuTo=QpKKY09sgpppDEiuNA@mail.gmail.com>
Hi, Binbin.
On Tue, Feb 10, 2026 at 9:27 AM Binbin Zhou <zhoubb.aaron@gmail.com> wrote:
>
> Hi Frank:
>
> On Tue, Feb 10, 2026 at 12:48 AM Frank Li <Frank.li@nxp.com> wrote:
> >
> > On Mon, Feb 09, 2026 at 11:04:18AM +0800, Binbin Zhou wrote:
> > > Gather the Loongson DMA controllers under drivers/dma/loongson/
> > >
> > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> > > ---
> > > MAINTAINERS | 3 +-
> > > drivers/dma/Kconfig | 25 ++---------------
> > > drivers/dma/Makefile | 3 +-
> > > drivers/dma/loongson/Kconfig | 28 +++++++++++++++++++
> > > drivers/dma/loongson/Makefile | 3 ++
> > > .../dma/{ => loongson}/loongson1-apb-dma.c | 4 +--
> > > .../dma/{ => loongson}/loongson2-apb-dma.c | 4 +--
> > > 7 files changed, 40 insertions(+), 30 deletions(-)
> > > create mode 100644 drivers/dma/loongson/Kconfig
> > > create mode 100644 drivers/dma/loongson/Makefile
> > > rename drivers/dma/{ => loongson}/loongson1-apb-dma.c (99%)
> > > rename drivers/dma/{ => loongson}/loongson2-apb-dma.c (99%)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index f630328ca6ae..27f77b68d596 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -14777,7 +14777,7 @@ M: Binbin Zhou <zhoubinbin@loongson.cn>
> > > L: dmaengine@vger.kernel.org
> > > S: Maintained
> > > F: Documentation/devicetree/bindings/dma/loongson,ls2x-apbdma.yaml
> > > -F: drivers/dma/loongson2-apb-dma.c
> > > +F: drivers/dma/loongson/loongson2-apb-dma.c
> > >
> > > LOONGSON LS2X I2C DRIVER
> > > M: Binbin Zhou <zhoubinbin@loongson.cn>
> > > @@ -17515,6 +17515,7 @@ F: arch/mips/boot/dts/loongson/loongson1*
> > > F: arch/mips/configs/loongson1_defconfig
> > > F: arch/mips/loongson32/
> > > F: drivers/*/*loongson1*
> > > +F: drivers/dma/loongson/loongson1-apb-dma.c
> > > F: drivers/mtd/nand/raw/loongson-nand-controller.c
> > > F: drivers/net/ethernet/stmicro/stmmac/dwmac-loongson1.c
> > > F: sound/soc/loongson/loongson1_ac97.c
> > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> > > index 66cda7cc9f7a..1b84c5b11654 100644
> > > --- a/drivers/dma/Kconfig
> > > +++ b/drivers/dma/Kconfig
> > > @@ -376,29 +376,6 @@ config K3_DMA
> > > Support the DMA engine for Hisilicon K3 platform
> > > devices.
> > >
> > > -config LOONGSON1_APB_DMA
> > > - tristate "Loongson1 APB DMA support"
> > > - depends on MACH_LOONGSON32 || COMPILE_TEST
> > > - select DMA_ENGINE
> > > - select DMA_VIRTUAL_CHANNELS
> > > - help
> > > - This selects support for the APB DMA controller in Loongson1 SoCs,
> > > - which is required by Loongson1 NAND and audio support.
> > > -
> > > -config LOONGSON2_APB_DMA
> > > - tristate "Loongson2 APB DMA support"
> > > - depends on LOONGARCH || COMPILE_TEST
> > > - select DMA_ENGINE
> > > - select DMA_VIRTUAL_CHANNELS
> > > - help
> > > - Support for the Loongson2 APB DMA controller driver. The
> > > - DMA controller is having single DMA channel which can be
> > > - configured for different peripherals like audio, nand, sdio
> > > - etc which is in APB bus.
> > > -
> > > - This DMA controller transfers data from memory to peripheral fifo.
> > > - It does not support memory to memory data transfer.
> > > -
> > > config LPC18XX_DMAMUX
> > > bool "NXP LPC18xx/43xx DMA MUX for PL080"
> > > depends on ARCH_LPC18XX || COMPILE_TEST
> > > @@ -774,6 +751,8 @@ source "drivers/dma/fsl-dpaa2-qdma/Kconfig"
> > >
> > > source "drivers/dma/lgm/Kconfig"
> > >
> > > +source "drivers/dma/loongson/Kconfig"
> > > +
> > > source "drivers/dma/stm32/Kconfig"
> > >
> > > # clients
> > > diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
> > > index a54d7688392b..a1c73415b79f 100644
> > > --- a/drivers/dma/Makefile
> > > +++ b/drivers/dma/Makefile
> > > @@ -49,8 +49,6 @@ obj-$(CONFIG_INTEL_IDMA64) += idma64.o
> > > obj-$(CONFIG_INTEL_IOATDMA) += ioat/
> > > obj-y += idxd/
> > > obj-$(CONFIG_K3_DMA) += k3dma.o
> > > -obj-$(CONFIG_LOONGSON1_APB_DMA) += loongson1-apb-dma.o
> > > -obj-$(CONFIG_LOONGSON2_APB_DMA) += loongson2-apb-dma.o
> > > obj-$(CONFIG_LPC18XX_DMAMUX) += lpc18xx-dmamux.o
> > > obj-$(CONFIG_LPC32XX_DMAMUX) += lpc32xx-dmamux.o
> > > obj-$(CONFIG_MILBEAUT_HDMAC) += milbeaut-hdmac.o
> > > @@ -88,6 +86,7 @@ obj-$(CONFIG_INTEL_LDMA) += lgm/
> > >
> > > obj-y += amd/
> > > obj-y += mediatek/
> > > +obj-y += loongson/
> >
> > keep alphabet order
>
> Sorry, I'll fix it in the next version.
> >
> > Frank
> > > obj-y += qcom/
> > > obj-y += stm32/
> > > obj-y += ti/
> > > diff --git a/drivers/dma/loongson/Kconfig b/drivers/dma/loongson/Kconfig
> > > new file mode 100644
> > > index 000000000000..9dbdaef5a59f
> > > --- /dev/null
> > > +++ b/drivers/dma/loongson/Kconfig
> > > @@ -0,0 +1,28 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only
> > > +#
> > > +# Loongson DMA controllers drivers
> > > +#
> > > +if MACH_LOONGSON32 || MACH_LOONGSON64 || COMPILE_TEST
> > > +
> > > +config LOONGSON1_APB_DMA
> > > + tristate "Loongson1 APB DMA support"
> > > + select DMA_ENGINE
> > > + select DMA_VIRTUAL_CHANNELS
I think "depends on MACH_LOONGSON32 || COMPILE_TEST" is still needed,
otherwise it can be compiled for MACH_LOONGSON64.
> > > + help
> > > + This selects support for the APB DMA controller in Loongson1 SoCs,
> > > + which is required by Loongson1 NAND and audio support.
> > > +
> > > +config LOONGSON2_APB_DMA
> > > + tristate "Loongson2 APB DMA support"
> > > + select DMA_ENGINE
> > > + select DMA_VIRTUAL_CHANNELS
The same, "depends on MACH_LOONGSON64 || COMPILE_TEST" is needed.
Huacai
> > > + help
> > > + Support for the Loongson2 APB DMA controller driver. The
> > > + DMA controller is having single DMA channel which can be
> > > + configured for different peripherals like audio, nand, sdio
> > > + etc which is in APB bus.
> > > +
> > > + This DMA controller transfers data from memory to peripheral fifo.
> > > + It does not support memory to memory data transfer.
> > > +
> > > +endif
> > > diff --git a/drivers/dma/loongson/Makefile b/drivers/dma/loongson/Makefile
> > > new file mode 100644
> > > index 000000000000..6cdd08065e92
> > > --- /dev/null
> > > +++ b/drivers/dma/loongson/Makefile
> > > @@ -0,0 +1,3 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only
> > > +obj-$(CONFIG_LOONGSON1_APB_DMA) += loongson1-apb-dma.o
> > > +obj-$(CONFIG_LOONGSON2_APB_DMA) += loongson2-apb-dma.o
> > > diff --git a/drivers/dma/loongson1-apb-dma.c b/drivers/dma/loongson/loongson1-apb-dma.c
> > > similarity index 99%
> > > rename from drivers/dma/loongson1-apb-dma.c
> > > rename to drivers/dma/loongson/loongson1-apb-dma.c
> > > index 255fe7eca212..e99247cf90c1 100644
> > > --- a/drivers/dma/loongson1-apb-dma.c
> > > +++ b/drivers/dma/loongson/loongson1-apb-dma.c
> > > @@ -16,8 +16,8 @@
> > > #include <linux/platform_device.h>
> > > #include <linux/slab.h>
> > >
> > > -#include "dmaengine.h"
> > > -#include "virt-dma.h"
> > > +#include "../dmaengine.h"
> > > +#include "../virt-dma.h"
> > >
> > > /* Loongson-1 DMA Control Register */
> > > #define LS1X_DMA_CTRL 0x0
> > > diff --git a/drivers/dma/loongson2-apb-dma.c b/drivers/dma/loongson/loongson2-apb-dma.c
> > > similarity index 99%
> > > rename from drivers/dma/loongson2-apb-dma.c
> > > rename to drivers/dma/loongson/loongson2-apb-dma.c
> > > index c528f02b9f84..0cb607595d04 100644
> > > --- a/drivers/dma/loongson2-apb-dma.c
> > > +++ b/drivers/dma/loongson/loongson2-apb-dma.c
> > > @@ -17,8 +17,8 @@
> > > #include <linux/platform_device.h>
> > > #include <linux/slab.h>
> > >
> > > -#include "dmaengine.h"
> > > -#include "virt-dma.h"
> > > +#include "../dmaengine.h"
> > > +#include "../virt-dma.h"
> > >
> > > /* Global Configuration Register */
> > > #define LDMA_ORDER_ERG 0x0
> > > --
> > > 2.52.0
> > >
>
> --
> Thanks.
> Binbin
next prev parent reply other threads:[~2026-02-26 8:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 3:04 [PATCH v2 0/4] dmaengine: Add Loongson Multi-Channel DMA controller support Binbin Zhou
2026-02-09 3:04 ` [PATCH v2 1/4] dmaengine: loongson: New directory for Loongson DMA controllers drivers Binbin Zhou
2026-02-09 16:48 ` Frank Li
2026-02-10 1:27 ` Binbin Zhou
2026-02-26 8:07 ` Huacai Chen [this message]
2026-02-09 3:04 ` [PATCH v2 2/4] dmaengine: loongson: loongson2-apb: Convert to dmaenginem_async_device_register() Binbin Zhou
2026-02-09 16:51 ` Frank Li
2026-02-09 3:04 ` [PATCH v2 3/4] dt-bindings: dmaengine: Add Loongson Multi-Channel DMA controller Binbin Zhou
2026-02-10 3:03 ` Rob Herring
2026-02-10 6:02 ` Binbin Zhou
2026-02-09 3:04 ` [PATCH v2 4/4] dmaengine: loongson: New driver for the " Binbin Zhou
2026-02-09 17:04 ` Frank Li
2026-02-10 7:41 ` Binbin Zhou
2026-02-10 12:02 ` Binbin Zhou
2026-02-10 15:27 ` Frank Li
2026-02-24 12:59 ` Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAhV-H5ODRYLC=cmhWzkkxAMNJK1SRT9b-L+eQEqzhJKtmENhQ@mail.gmail.com' \
--to=chenhuacai@kernel.org \
--cc=Frank.li@nxp.com \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jeffbai@aosc.io \
--cc=keguang.zhang@gmail.com \
--cc=kernel@xen0n.name \
--cc=krzk+dt@kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=maoxiaochuan@loongson.cn \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).