From: Huacai Chen <chenhuacai@kernel.org>
To: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Cc: Rob Herring <robh@kernel.org>, Thomas Gleixner <tglx@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: Re: [PATCH 2/8] dt-bindings: interrupt-controller: add LS7A PCH LPC
Date: Tue, 10 Feb 2026 20:47:17 +0800 [thread overview]
Message-ID: <CAAhV-H5foQQFakDCYRDSM3vePZh-kECpTM+rwvs3jBvLgsjChQ@mail.gmail.com> (raw)
In-Reply-To: <1f7b645328fb86d1097a80b224c39ca3ed07a4b2.camel@iscas.ac.cn>
On Tue, Feb 10, 2026 at 6:51 PM Icenowy Zheng <zhengxingda@iscas.ac.cn> wrote:
>
> 在 2026-02-09星期一的 17:48 -0600，Rob Herring写道：
> > On Sat, Jan 31, 2026 at 05:45:41PM +0800, Icenowy Zheng wrote:
> > > Loongson 7A series PCH contains an LPC controller with an interrupt
> > > controller.
> > >
> > > Add the device tree binding for the interrupt controller.
> > >
> > > Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> > > ---
> > > .../loongson,pch-lpc.yaml | 52
> > > +++++++++++++++++++
> > > 1 file changed, 52 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/interrupt-
> > > controller/loongson,pch-lpc.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/interrupt-
> > > controller/loongson,pch-lpc.yaml
> > > b/Documentation/devicetree/bindings/interrupt-
> > > controller/loongson,pch-lpc.yaml
> > > new file mode 100644
> > > index 0000000000000..c00fbf31f47f0
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/interrupt-
> > > controller/loongson,pch-lpc.yaml
> > > @@ -0,0 +1,52 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id:
> > > http://devicetree.org/schemas/interrupt-controller/loongson,pch-lpc.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Loongson PCH LPC Controller
> > > +
> > > +maintainers:
> > > + - Jiaxun Yang <jiaxun.yang@flygoat.com>
> > > +
> > > +description:
> > > + This interrupt controller is found in the Loongson LS7A family
> > > of PCH for
> > > + accepting interrupts sent by LPC-connected peripherals and
> > > signalling PIC
> > > + via a single interrupt line when interrupts are available.
> > > +
> > > +properties:
> > > + compatible:
> > > + const: loongson,pch-lpc-1.0
> >
> > Where does 1.0 come from? We don't do version numbers generally
> > unless
> > you define where the versions come from (e.g. Soft IP releases for
> > FPGAs). I would have expected "ls7a" in the compatible instead.
>
> I originally followed the behavior of PCH PIC; however after asking
> Jiaxun offlist, I was noticed about a register on the 7A1000 user
> manual in the PIC that identifies the PIC version number; such version
> number register does not exist for LPC part.
>
> I will switch to ls7a-lpc or ls7a1000-lpc. Newer compatible strings in
> the 2K series (LoongArch ones) come with the whole model number, I
> don't know whether this is needed for 7A1000 (although it looks like
> that 7A2000 has the same
Yes, they are the same, so I think ls7a-lpc is just OK.
Huacai
> >
> > Rob
> >
>
next prev parent reply other threads:[~2026-02-10 12:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 9:45 [PATCH 0/8] Add support for LS7A LPC IRQ for MIPS Loongson systems Icenowy Zheng
2026-01-31 9:45 ` [PATCH 1/8] genirq: reserve NR_IRQS_LEGACY IRQs in dynirq by default Icenowy Zheng
2026-01-31 9:45 ` [PATCH 2/8] dt-bindings: interrupt-controller: add LS7A PCH LPC Icenowy Zheng
2026-02-09 23:48 ` Rob Herring
2026-02-10 6:33 ` Icenowy Zheng
2026-02-10 10:51 ` Icenowy Zheng
2026-02-10 12:47 ` Huacai Chen [this message]
2026-01-31 9:45 ` [PATCH 3/8] irqchip/loongson-pch-lpc: extract non-ACPI-related code from ACPI init Icenowy Zheng
2026-01-31 14:05 ` kernel test robot
2026-02-01 16:15 ` Thomas Gleixner
2026-01-31 9:45 ` [PATCH 4/8] irqchip/loongson-pch-lpc: guard ACPI init code with CONFIG_ACPI Icenowy Zheng
2026-01-31 9:45 ` [PATCH 5/8] irqchip/loongson-pch-lpc: add OF init code Icenowy Zheng
2026-01-31 19:59 ` kernel test robot
2026-02-01 2:33 ` Huacai Chen
2026-02-01 16:17 ` Thomas Gleixner
2026-02-01 16:19 ` Thomas Gleixner
2026-02-02 5:50 ` Icenowy Zheng
2026-02-02 9:55 ` Thomas Gleixner
2026-02-02 1:12 ` kernel test robot
2026-01-31 9:45 ` [PATCH 6/8] irqchip/loongson-pch-lpc: enable building on MIPS Loongson64 Icenowy Zheng
2026-01-31 9:45 ` [PATCH 7/8] MIPS: Loongson64: dts: sort nodes Icenowy Zheng
2026-01-31 9:45 ` [PATCH 8/8] MIPS: Loongson64: dts: add node for LS7A PCH LPC Icenowy Zheng
2026-02-01 9:57 ` [PATCH 0/8] Add support for LS7A LPC IRQ for MIPS Loongson systems Yao Zi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAhV-H5foQQFakDCYRDSM3vePZh-kECpTM+rwvs3jBvLgsjChQ@mail.gmail.com \
--to=chenhuacai@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tglx@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=zhengxingda@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).