From: Maxwell Doose <m32285159@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: tsbogend@alpha.franken.de, gregkh@linuxfoundation.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] mips: cavium-octeon: remove cmd queue state and related typedefs
Date: Fri, 17 Apr 2026 08:16:37 -0500 [thread overview]
Message-ID: <CAKqfh0HaG1fQw2_g9P7wHPyqib05CeyPcTVQREYyz4u2xRgbQw@mail.gmail.com> (raw)
In-Reply-To: <aeHERE58gSbAe795@stanley.mountain>
On Fri, Apr 17, 2026 at 12:25 AM Dan Carpenter <error27@gmail.com> wrote:
>
> This should be two different patches. Is there no way to move the
> variable declarations around first and then get rid of the typedef?
>
> regards,
> dan carpenter
>
When I was test-compiling the patch yesterday, sparse raised
a "should it be static?" error, and that was resolved by moving
the extern for the __cvmx_queue_state_ptr in the header to the
top of the file.
best regards,
maxwell doose
next prev parent reply other threads:[~2026-04-17 13:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 2:36 [PATCH] mips: cavium-octeon: remove cmd queue state and related typedefs Maxwell Doose
2026-04-17 5:25 ` Dan Carpenter
2026-04-17 13:16 ` Maxwell Doose [this message]
2026-04-17 14:02 ` Dan Carpenter
2026-04-17 14:45 ` Maxwell Doose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKqfh0HaG1fQw2_g9P7wHPyqib05CeyPcTVQREYyz4u2xRgbQw@mail.gmail.com \
--to=m32285159@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).