From: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Linus Walleij <linusw@kernel.org>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Sean Wang <sean.wang@kernel.org>,
Paul Cercueil <paul@crapouillou.net>,
Tony Lindgren <tony@atomide.com>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH 5/7] pinctrl: renesas: rzg2l: Fix type in .pin_config_group_get() callback
Date: Tue, 5 May 2026 10:48:57 +0000 [thread overview]
Message-ID: <OSCPR01MB143159AA54CC67CA063A153C9AA3E2@OSCPR01MB14315.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <6befae30f129daffd94f7a9507d874443e444a21.1777562725.git.geert+renesas@glider.be>
> From: Geert Uytterhoeven <geert+renesas@glider.be>
> Sent: 30 April 2026 16:33
> To: Linus Walleij <linusw@kernel.org>; Lorenzo Bianconi
> <lorenzo@kernel.org>; Sean Wang <sean.wang@kernel.org>; Paul Cercueil
> <paul@crapouillou.net>; Tony Lindgren <tony@atomide.com>; Haojian Zhuang
> <haojian.zhuang@linaro.org>; Matthias Brugger <matthias.bgg@gmail.com>;
> AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>;
> Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: linux-gpio@vger.kernel.org; linux-mediatek@lists.infradead.org; linux-
> kernel@vger.kernel.org; linux-mips@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-omap@vger.kernel.org; linux-renesas-
> soc@vger.kernel.org; Geert Uytterhoeven <geert+renesas@glider.be>
> Subject: [PATCH 5/7] pinctrl: renesas: rzg2l: Fix type in
> .pin_config_group_get() callback
>
> On 64-bit platforms, "unsigned long" is 64-bit. Hence checking if all
> "unsigned long" configuration values are equal should be done using an
> "unsigned long" temporary.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/pinctrl/renesas/pinctrl-rzg2l.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cheers,
Prabhakar
> diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> index bc2154b695149809..5b0f23af5a6cc9de 100644
> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -1647,8 +1647,9 @@ static int rzg2l_pinctrl_pinconf_group_get(struct
> pinctrl_dev *pctldev,
> unsigned int group,
> unsigned long *config)
> {
> + unsigned long prev_config = 0;
> const unsigned int *pins;
> - unsigned int i, npins, prev_config = 0;
> + unsigned int i, npins;
> int ret;
>
> ret = pinctrl_generic_get_group_pins(pctldev, group, &pins, &npins);
> --
> 2.43.0
next prev parent reply other threads:[~2026-05-05 10:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 15:33 [PATCH 0/7] pinctrl: Fix types in .pin_config_group_get() callbacks Geert Uytterhoeven
2026-04-30 15:33 ` [PATCH 1/7] pinctrl: airoha: Fix type in .pin_config_group_get() callback Geert Uytterhoeven
2026-04-30 15:33 ` [PATCH 2/7] pinctrl: equilibrium: " Geert Uytterhoeven
2026-04-30 15:33 ` [PATCH 3/7] pinctrl: ingenic: " Geert Uytterhoeven
2026-05-02 14:48 ` H. Nikolaus Schaller
2026-05-04 10:26 ` Paul Cercueil
2026-04-30 15:33 ` [PATCH 4/7] pinctrl: mediatek: moore: " Geert Uytterhoeven
2026-04-30 15:33 ` [PATCH 5/7] pinctrl: renesas: rzg2l: " Geert Uytterhoeven
2026-05-05 10:48 ` Prabhakar Mahadev Lad [this message]
2026-04-30 15:33 ` [PATCH 6/7] pinctrl: renesas: rzv2m: " Geert Uytterhoeven
2026-04-30 15:33 ` [PATCH 7/7] pinctrl: single: " Geert Uytterhoeven
2026-05-05 10:45 ` [PATCH 0/7] pinctrl: Fix types in .pin_config_group_get() callbacks Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSCPR01MB143159AA54CC67CA063A153C9AA3E2@OSCPR01MB14315.jpnprd01.prod.outlook.com \
--to=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=geert+renesas@glider.be \
--cc=haojian.zhuang@linaro.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=paul@crapouillou.net \
--cc=sean.wang@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).