From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A275FEB64D9 for ; Mon, 19 Jun 2023 13:40:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 171B88D0002; Mon, 19 Jun 2023 09:40:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FB448D0001; Mon, 19 Jun 2023 09:40:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB6418D0002; Mon, 19 Jun 2023 09:40:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D90E98D0001 for ; Mon, 19 Jun 2023 09:40:43 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9BDB11404AD for ; Mon, 19 Jun 2023 13:40:43 +0000 (UTC) X-FDA: 80919607566.22.5DE9EE2 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf07.hostedemail.com (Postfix) with ESMTP id 361F940027 for ; Mon, 19 Jun 2023 13:40:40 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=MjZrI2Pb; dkim=pass header.d=alien8.de header.s=alien8 header.b=Hhjq4sAw; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf07.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687182041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NQcQ+a91rnEmxFtS6KIZWR6r/nd+aTVNBSnx9bM3XZo=; b=ukNaocoLF28HjXjgyWmvEr5beeh/dw6/wZZgAPq0EvAQRrc1XCVfQeVL2ASH6J5sOdSS13 uysP+wuJT0OqOC0xpwSOdho8dudCkBJIqHoRMN+MbjgxN2+U/VBHhX08/CYm37p+dFA0xa nN1zizuYoMtL7uu6QfbEYykqz4XhplA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=MjZrI2Pb; dkim=pass header.d=alien8.de header.s=alien8 header.b=Hhjq4sAw; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf07.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687182041; a=rsa-sha256; cv=none; b=npWZlXRTH5UrgTViKfze7wLQbbcFPxjl3nxbbBnZP8LdKKlEgOzCIkGoB9Ny8GiK/8+Z+z saFWN2qoWIOSjK2bDBptC+qhyVrST95YtMGa/P0jaXZLeIX1iPZyFlAxE9XskbxeqbaiRR cv5wc86L3gas3riQKXd+/tDvUWbZYHM= Received: from mail.alien8.de (mail.alien8.de [IPv6:2a01:4f9:3051:3f93::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id DB3D31EC0102; Mon, 19 Jun 2023 15:40:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1687182038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=NQcQ+a91rnEmxFtS6KIZWR6r/nd+aTVNBSnx9bM3XZo=; b=MjZrI2Pb1EA97CsnjLQkLLYXnftqpz1BMSytwT2Fkcm79yTr7JlS3vbPHybZQGk2gNvBdV 7pJxq+Ljl/BYq/YNswcZLYfOeYT3BcOtdCS2ltKIotcJp6HYvURYcrmTpDMEIyanHuqgDd H+X68i3UAmnnIDktOVRK7Y5dvsc0MIs= X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id xyc2kN7e7SI6; Mon, 19 Jun 2023 13:40:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1687182035; bh=NQcQ+a91rnEmxFtS6KIZWR6r/nd+aTVNBSnx9bM3XZo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hhjq4sAwqpuXAjDZr0482mo+tJJ0h0offjDvdI0pCCoCQw2bDUcP8d1vbDkapw272 xVM5yjFjjoNovnJZSBbFHf8J20dy0BvYq3Lf5/6HRBdwil9v1Aobm+f2g/gfW4DXnM b4YK0b1ne/U38dROisrBRRDzRlbXtYjRrFji1OTpCkEAnk7c+RPW9lAtONuYgZRerJ I6+INtMP4DnSAZnjWraSMdu0T5EW08EU7cAYkC/Hha/niDr/F5MewITS/JqCLcCk2w M4fJW5oXMRz9hZQzxEsZOb+8GOiaXrEPRugbBe8sJyskrr6Nh7FJhJjuPcsFYYypTU hca7QInRQqaye2PTigrrCnFcm0WMOQp1goK0OxCGZ9Ing4TiGzBJOuvh74BZVr/Qmi DdSTA2frFGKVeHBbStTjaynkbdb1FjWeT4A2xGYIok+FY/MvJPPnX/bv72T9u8DOue fdyb1/BCxS9myr7OYuFisiuGoDRpYKpLCPZZzwC8xjY8OXaZXwAYoWmCwqI56wH0Js TfJMAZ4TNRorAeiEzc0gIHq0u0T5lPm4dt0t754mvHOYYJYEaoCsQqHeC4Dy2RGzS1 aqKVArwd+i9hfQZM7ZM3g53aGg9SoCzbpCl/YgirQxJXdSuW99oJN7wrICWB1/lnJP 63A8a5ZQ59tJNZlWhFgkbgVs= Received: from zn.tnic (p200300ea971dC5b2329c23fFFEA6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971d:c5b2:329c:23ff:fea6:a903]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 793DE40E0034; Mon, 19 Jun 2023 13:39:55 +0000 (UTC) Date: Mon, 19 Jun 2023 15:39:50 +0200 From: Borislav Petkov To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com Subject: Re: [PATCH RFC v9 02/51] KVM: x86: Add gmem hook for invalidating private memory Message-ID: <20230619133950.GBZJBapnJ3vD74ASAu@fat_crate.local> References: <20230612042559.375660-1-michael.roth@amd.com> <20230612042559.375660-3-michael.roth@amd.com> <20230612104905.GOZIb4ISN9gj9lWYNv@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230612104905.GOZIb4ISN9gj9lWYNv@fat_crate.local> X-Rspamd-Queue-Id: 361F940027 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: sh6r4zyitwjm35dzrob76xhfnwb45rba X-HE-Tag: 1687182040-717839 X-HE-Meta: U2FsdGVkX1/po9nNmUP8bKgmXiDb57qYZg3/AP7keuaf3nlwHx+DIVFfNnKW4JyijTCIBaWyIvg1GalyUlGaa2+xqLDWAffcTZd3uX5FqwBzocwkhEYHsYE2bCa3CZT0PjbLkQ35IsbvBlgDyh13y/8JEHPJbmAtXnO0cKXhPCvSvin823KDtG+4m5TUGvMcnFb4z+42w9eEH8rdzsTN1HPbiGFAyo7mumXXUS/RUqs5VgX/yNRddk6Z0RwkDjs3le8hjkhXRk42Nu1LaZNdPUBwu62AmS0DaFDS+5CeStfcsaG7RsyLYGNQE4RNPZLC/pmx9GUJwX3tyCdhPOTbXKWKg8AofFIAzTRKkkRrbEf62dv3uaSGNa8eeSNP9hWwVxudDKpanYLuCjzhVQFs2OgQSmjEIeI8mT+0LOl7VsslYSxrS/zoINY6e49tnkNWVjB1e4zOscEKRgnwFnvGjZD+H5TvHTu7Vkohp1G1c0heEG3FTqEP0Kx7lSypUUNKYHZgWT3oxxES8AvC8Nk91RGyJbMJvxBST4+fxsOkvPOdB2TSe4PJYuD6WFChe6ld2acSm/eaB965+Of8zqzq8iao35z9sfhUuxh3+zp5kDfutDMKqVo9FCpzdEqS0TQtyrObhuxFbmhNmRl/ZISTpbGpqnltUZ05iIlXcf3PxnYl89CSMqPU1yiOdZAouestvWWm8/3qQHqbS9ZFW5bAfZi1w0m/nzthAtWCpQmctbbw20KH6jIVzlD0gZvXJeOlUZSiVyN9YXeoWW84xsbu2RETE5+voxA15Y2mpt4FIfZsufodaPpp6sPpLpXwY+WoYv/DfNe1CffACUIM6+Cy2HUqX/L2CLlGpPL2jOVvkCTl5xfaPKxEBiJtG6+4/NkVkC3k5vAiL6GCixqfNeWICRo68e1Wy1EyT07PlF+8jSCUmY83Dc3ALNyvyTsq7or69PjUs2xfPRAKg5VMhiF LmcW/BOM cwm6U2mMIOplAPyAI7TcvycCqXhCOyoEZBA2nbdGsE7QD/cymnjq19H6vKdXgWymFAWgA+2iP6jMh/talCyjKmQlpR+M2x+J+tguDMcnJtqm2zNwzDLS1R9x36nFBrB2cCBw6aQp28gPIm/2LBuxp+3EOQSQnrVVRPYVseeE6dlbkKpkHJ/mCWrcf0lWv52mbO0c3piiUCbJ7zr4AsqQHWWhFspc7Zc4TZO8gLqiLL0E3dZGyT3DmVxHlNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 12:49:05PM +0200, Borislav Petkov wrote: > ld: arch/x86/kvm/../../../virt/kvm/eventfd.o: in function `kvm_arch_gmem_invalidate': > /home/boris/kernel/2nd/linux/./include/linux/kvm_host.h:2356: multiple definition of `kvm_arch_gmem_invalidate'; arch/x86/kvm/../../../virt/kvm/kvm_main.o:/home/boris/kernel/2nd/linux/./include/linux/kvm_host.h:2356: first defined here > ld: arch/x86/kvm/../../../virt/kvm/binary_stats.o: in function `kvm_arch_gmem_invalidate': Fix is trivial: --- diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index 7de06add2235..67fdfb683cb9 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -2353,7 +2353,7 @@ static inline int kvm_gmem_get_pfn(struct kvm *kvm, return -EIO; } -void kvm_arch_gmem_invalidate(struct kvm *kvm, kvm_pfn_t start, kvm_pfn_t end) { } +static inline void kvm_arch_gmem_invalidate(struct kvm *kvm, kvm_pfn_t start, kvm_pfn_t end) { } #endif /* CONFIG_KVM_PRIVATE_MEM */ #endif -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette