From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD898C4345F for ; Sat, 4 May 2024 01:31:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC0976B007B; Fri, 3 May 2024 21:31:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E49516B0083; Fri, 3 May 2024 21:31:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC2E46B0085; Fri, 3 May 2024 21:31:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ABC116B007B for ; Fri, 3 May 2024 21:31:18 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 40B3640117 for ; Sat, 4 May 2024 01:31:18 +0000 (UTC) X-FDA: 82078985436.10.136508E Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by imf30.hostedemail.com (Postfix) with ESMTP id 8562F80003 for ; Sat, 4 May 2024 01:31:14 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SUSu3DTi; spf=pass (imf30.hostedemail.com: domain of lkp@intel.com designates 198.175.65.12 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714786276; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uXBu5hd1HP7qH7J1wBdvTUwAydy3HN+Ph68C6q9fmGw=; b=8nyFmQAMirG6aic1useKtZHxYoClNrHVSiz9PORrsVsrF6G38KGB/jyE+Zd98ElHNYStmG cUoimsrVJAS5m9iro9H5Q1cwQBbcRzFITFWM0PpqMiiuUV+1H9lFPdwPPS+XifQdpbffqD IRlIdOh7PdXaL9UWsXd91fGk5aIntzI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SUSu3DTi; spf=pass (imf30.hostedemail.com: domain of lkp@intel.com designates 198.175.65.12 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714786276; a=rsa-sha256; cv=none; b=CnRKkptxZADNyi0urMahFG8L7yPq06MJR4Z/u0WGhw5kYMC9FZP1MT7itsxGZDJ0igNzqB rF65Gd5vWnbrq4m68uGqZbJfFZb+WD67m3QZtFzF4ajAqVWGdcUbL5j8E4sD8/zPJMc4tp yjh45umcTdVlJcGETFIjZDSTtW3L3hE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714786275; x=1746322275; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=PyxY0oE69hZ0c4dm+MXzuFqcMWQum1NUbC5k6H+O7Ys=; b=SUSu3DTiDlaNPz5fP8aVjTqyJKX6f7+z5I1d7dV3S5blgAWYI6wWm6mI TGPd9JSzTa1tjBxg8o3/UPO0hL6+6o1vEBviFe+sUCzfnkK+6fAr/VRch 5sfhWlAhN+xJHPDqSdfHOfsoyM4TJ9D9QNSO99pOp+uitfWLDbEghdZ6c PjzfB9cVUQh+xjXNq/glYvxrPSiaxna9qLsaUrXh57gwYk68YF1Z6HSBP sRNYN1wE/ks6bvGWpW+x8L956hQ8fE4watx7LgjrX3OUrXSQsI9c0x+Us Xe0thSmp3othaE2JI9I+WRmZSwexW/IYY+rGsFW8HbAeh/Acl4VTghflA Q==; X-CSE-ConnectionGUID: G+ezSi6LQGO2EMTM7XNXtg== X-CSE-MsgGUID: Z+OhbYs1S+GSRhY7RKN9Jw== X-IronPort-AV: E=McAfee;i="6600,9927,11063"; a="22019868" X-IronPort-AV: E=Sophos;i="6.07,252,1708416000"; d="scan'208";a="22019868" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2024 18:31:12 -0700 X-CSE-ConnectionGUID: CsKHDJlLRT26MVLiY1ayRA== X-CSE-MsgGUID: fosB1S7HTi2Sy+DTtD4eHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,252,1708416000"; d="scan'208";a="58812264" Received: from lkp-server01.sh.intel.com (HELO e434dd42e5a1) ([10.239.97.150]) by fmviesa001.fm.intel.com with ESMTP; 03 May 2024 18:31:09 -0700 Received: from kbuild by e434dd42e5a1 with local (Exim 4.96) (envelope-from ) id 1s34F0-000CIO-0z; Sat, 04 May 2024 01:31:06 +0000 Date: Sat, 4 May 2024 09:30:58 +0800 From: kernel test robot To: Allen Pais , linux-fsdevel@vger.kernel.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, ebiederm@xmission.com, keescook@chromium.org, mcgrof@kernel.org, j.granados@samsung.com, allen.lkml@gmail.com Subject: Re: [PATCH v3] fs/coredump: Enable dynamic configuration of max file note size Message-ID: <202405040817.bJeHlwXS-lkp@intel.com> References: <20240502235603.19290-1-apais@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240502235603.19290-1-apais@linux.microsoft.com> X-Stat-Signature: 5ukct1y7854ew7kw99k9u5knxkowgzwj X-Rspam-User: X-Rspamd-Queue-Id: 8562F80003 X-Rspamd-Server: rspam05 X-HE-Tag: 1714786274-997019 X-HE-Meta: U2FsdGVkX1/QewfMsPzGr5Fehf7iKn3Y5ERmIsFJT137WLh4loNP4z7bQ9rUwPYU6IXikwQnDOxe0el0Xv8hOFp12mYyBjT6XXCYF3Suu8+BiKwRj/HHZGGHi75v9FM3RLDWy/XC56zPSAwiWpg2NFvohpceegP8HjJdkH1fL9BcqcO8XiZAvq+/f/+2RIeNDnxFs50UB9P6i6aZ+BzPdgxAr4ofykH1n+Xi5Z6d9SnB6xbx/fxDh7xoQ6W3IX36jol71Rm4IRcN8tybr9eGkyR61EGFVS6GOmRBIt2oH4ntix49PluS5CfjaMuiEZHSUAuJJFLonXC9HUOd6nP4Oxrd1hLihIxqj2Wil9ACO/ksY66+YXEoKa65qDWl1qokFHeF4meAA71DIE6jGR/0SwUy5CC6/Rl9EtjollofdYJ94Pj+M8qoLEzQZbA+AVSlGEr9p+lSWN+D9tIf/k5kgcUukbOh9zhByBPBqBjkM6TVN8qfFg4g50XfdB/EYp4dztnkLlVTxuhHKqj9NZLEzoVtgR6YteXqdATdGq2yc4H8cpA1kXhrE2Gc884gT1HrxE9GBy/UrR2ulFRzQGqG1RMDg22pzJRkYquFsMSI0CsdLReNkkQkjgBU3lqeKExwdcXCauvyKLw8zHf54Can3m6V2Cp30BCtVH512g9ilv/EmpWBBF3G7dUqWdyDANw+kK42b6lBP+BBPbRQ0Kkk20gYrRo/bF+4Y0P3DHqJJz0oyNU7f8wd3DoC4O+31RLnauXPW4Dh9XYwSx6SIwqmBeyf3gl9I0MqjRYPpOpKhg6hgnEC195I0dPuZo8inFnwcjWbwT3KLWNyMGFXrCXoygxMZB1A6r5uTp3XJzYnDol60vIURw5HgR0Bdr7J7qQP5/S6mrZjJsauu62KZOPfgtSlTiZdWikttyvQ8zrMe2pjDkkXvB8Wqh6pPWlPREnKXyqbPRhEOV9sYzMKyJc Kw+FwTXU y9FgZ/GCibT1cPQ/IheuIY9Uno1YREPrWKl60gipWmvQhT2wg93ak7Fzz/0g0Ap8Fs3qY9etroUH223txHTnKn2o9P1q9FQ7j1TyX1SaXTvXVZax3KioCB/Jk6bOm+Ip5inqhjf2nJDfnDOwmUdW1fkpSGhuJ8EfKN8IQJDQkjn5EqSlsr+SceOgrjyr4lJhA8ES/PO7t/nkPxQCcqHFWBjIUWQBmCRpvzsVMOTMI2ix3U9QSOXYoordoOFOzweUGuDiJNdI6DfokGHG+L5nNFyMzZJnFq2McMTcoZ/qIyhvLLQEIfKqKdhnOveGVt5fgGDjpW8hoICnZ6iTmLg+Pz9T5Obl4saUWWgp5NY1VWEdW9QnrGfyT+Bb18Pu1Uz9egamCfyQq0QvTlLrEsCRWQ62weHzXjv4JOq1N3ZU8DENN8icDU0xyAdR9BFAB0fCEpSQTUu7WbFYSkqk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Allen, kernel test robot noticed the following build errors: [auto build test ERROR on kees/for-next/execve] [also build test ERROR on brauner-vfs/vfs.all linus/master v6.9-rc6 next-20240503] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Allen-Pais/fs-coredump-Enable-dynamic-configuration-of-max-file-note-size/20240503-075758 base: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/execve patch link: https://lore.kernel.org/r/20240502235603.19290-1-apais%40linux.microsoft.com patch subject: [PATCH v3] fs/coredump: Enable dynamic configuration of max file note size config: powerpc64-randconfig-001-20240504 (https://download.01.org/0day-ci/archive/20240504/202405040817.bJeHlwXS-lkp@intel.com/config) compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 37ae4ad0eef338776c7e2cffb3896153d43dcd90) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240504/202405040817.bJeHlwXS-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202405040817.bJeHlwXS-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from fs/compat_binfmt_elf.c:17: In file included from include/linux/elfcore-compat.h:6: In file included from include/linux/elfcore.h:11: In file included from include/linux/ptrace.h:10: In file included from include/linux/pid_namespace.h:7: In file included from include/linux/mm.h:2208: include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ In file included from fs/compat_binfmt_elf.c:144: >> fs/binfmt_elf.c:1598:14: error: use of undeclared identifier 'core_file_note_size_max' 1598 | if (size >= core_file_note_size_max) { | ^ 1 warning and 1 error generated. vim +/core_file_note_size_max +1598 fs/binfmt_elf.c 1569 1570 /* 1571 * Format of NT_FILE note: 1572 * 1573 * long count -- how many files are mapped 1574 * long page_size -- units for file_ofs 1575 * array of [COUNT] elements of 1576 * long start 1577 * long end 1578 * long file_ofs 1579 * followed by COUNT filenames in ASCII: "FILE1" NUL "FILE2" NUL... 1580 */ 1581 static int fill_files_note(struct memelfnote *note, struct coredump_params *cprm) 1582 { 1583 unsigned count, size, names_ofs, remaining, n; 1584 user_long_t *data; 1585 user_long_t *start_end_ofs; 1586 char *name_base, *name_curpos; 1587 int i; 1588 1589 /* *Estimated* file count and total data size needed */ 1590 count = cprm->vma_count; 1591 if (count > UINT_MAX / 64) 1592 return -EINVAL; 1593 size = count * 64; 1594 1595 names_ofs = (2 + 3 * count) * sizeof(data[0]); 1596 alloc: 1597 /* paranoia check */ > 1598 if (size >= core_file_note_size_max) { 1599 pr_warn_once("coredump Note size too large: %u " 1600 "(does kernel.core_file_note_size_max sysctl need adjustment?)\n", 1601 size); 1602 return -EINVAL; 1603 } 1604 size = round_up(size, PAGE_SIZE); 1605 /* 1606 * "size" can be 0 here legitimately. 1607 * Let it ENOMEM and omit NT_FILE section which will be empty anyway. 1608 */ 1609 data = kvmalloc(size, GFP_KERNEL); 1610 if (ZERO_OR_NULL_PTR(data)) 1611 return -ENOMEM; 1612 1613 start_end_ofs = data + 2; 1614 name_base = name_curpos = ((char *)data) + names_ofs; 1615 remaining = size - names_ofs; 1616 count = 0; 1617 for (i = 0; i < cprm->vma_count; i++) { 1618 struct core_vma_metadata *m = &cprm->vma_meta[i]; 1619 struct file *file; 1620 const char *filename; 1621 1622 file = m->file; 1623 if (!file) 1624 continue; 1625 filename = file_path(file, name_curpos, remaining); 1626 if (IS_ERR(filename)) { 1627 if (PTR_ERR(filename) == -ENAMETOOLONG) { 1628 kvfree(data); 1629 size = size * 5 / 4; 1630 goto alloc; 1631 } 1632 continue; 1633 } 1634 1635 /* file_path() fills at the end, move name down */ 1636 /* n = strlen(filename) + 1: */ 1637 n = (name_curpos + remaining) - filename; 1638 remaining = filename - name_curpos; 1639 memmove(name_curpos, filename, n); 1640 name_curpos += n; 1641 1642 *start_end_ofs++ = m->start; 1643 *start_end_ofs++ = m->end; 1644 *start_end_ofs++ = m->pgoff; 1645 count++; 1646 } 1647 1648 /* Now we know exact count of files, can store it */ 1649 data[0] = count; 1650 data[1] = PAGE_SIZE; 1651 /* 1652 * Count usually is less than mm->map_count, 1653 * we need to move filenames down. 1654 */ 1655 n = cprm->vma_count - count; 1656 if (n != 0) { 1657 unsigned shift_bytes = n * 3 * sizeof(data[0]); 1658 memmove(name_base - shift_bytes, name_base, 1659 name_curpos - name_base); 1660 name_curpos -= shift_bytes; 1661 } 1662 1663 size = name_curpos - (char *)data; 1664 fill_note(note, "CORE", NT_FILE, size, data); 1665 return 0; 1666 } 1667 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki