From: Wei Yang <richard.weiyang@gmail.com>
To: rppt@kernel.org, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, Wei Yang <richard.weiyang@gmail.com>
Subject: [Patch v3 7/7] mm/memblock: default region's nid may be MAX_NUMNODES
Date: Tue, 7 May 2024 07:58:33 +0000 [thread overview]
Message-ID: <20240507075833.6346-8-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20240507075833.6346-1-richard.weiyang@gmail.com>
On x86, the call flow looks like this:
numa_init()
memblock_set_node(..., MAX_NUMNODES)
numa_register_memblks()
memblock_validate_numa_coverage()
If there is a hole, the nid for this region would stay to be
MAX_NUMNODES. Then memblock_validate_numa_coverage() will miss to report
it.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
mm/memblock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memblock.c b/mm/memblock.c
index 33a8b6f7b626..e085de63688a 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -751,7 +751,7 @@ bool __init_memblock memblock_validate_numa_coverage(unsigned long threshold_byt
/* calculate lose page */
for_each_mem_pfn_range(i, MAX_NUMNODES, &start_pfn, &end_pfn, &nid) {
- if (nid == NUMA_NO_NODE)
+ if (nid == MAX_NUMNODES || nid == NUMA_NO_NODE)
nr_pages += end_pfn - start_pfn;
}
--
2.34.1
next prev parent reply other threads:[~2024-05-07 7:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 7:58 [Patch v3 0/7] memblock: cleanup Wei Yang
2024-05-07 7:58 ` [Patch v3 1/7] memblock tests: add memblock_reserve_all_locations_check() Wei Yang
2024-05-07 7:58 ` [Patch v3 2/7] memblock tests: add memblock_reserve_many_may_conflict_check() Wei Yang
2024-05-07 7:58 ` [Patch v3 3/7] mm/memblock: fix comment for memblock_isolate_range() Wei Yang
2024-05-07 7:58 ` [Patch v3 4/7] memblock tests: add memblock_overlaps_region_checks Wei Yang
2024-05-07 7:58 ` [Patch v3 5/7] mm/memblock: return true directly on finding overlap region Wei Yang
2024-05-07 7:58 ` [Patch v3 6/7] mm/memblock: use PAGE_ALIGN_DOWN to get pgend in free_memmap Wei Yang
2024-05-07 7:58 ` Wei Yang [this message]
2024-05-08 5:35 ` [Patch v3 0/7] memblock: cleanup Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507075833.6346-8-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).