From: Ryan Roberts <ryan.roberts@arm.com>
To: jeffxu@chromium.org, Aishwarya TCV <Aishwarya.TCV@arm.com>
Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org,
corbet@lwn.net, dave.hansen@intel.com, deraadt@openbsd.org,
gregkh@linuxfoundation.org, groeck@chromium.org,
jannh@google.com, jeffxu@google.com, jorgelo@chromium.org,
keescook@chromium.org, linux-hardening@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-mm@kvack.org, merimus@google.com, pedro.falcato@gmail.com,
rdunlap@infradead.org, sroettger@google.com, surenb@google.com,
torvalds@linux-foundation.org, usama.anjum@collabora.com,
willy@infradead.org
Subject: Re: [PATCH v1 1/1] selftest mm/mseal: fix arm build
Date: Fri, 3 May 2024 12:00:08 +0100 [thread overview]
Message-ID: <5f90431c-f27d-4b59-bf5a-32fd66101230@arm.com> (raw)
In-Reply-To: <20240502225331.3806279-2-jeffxu@chromium.org>
On 02/05/2024 23:53, jeffxu@chromium.org wrote:
> From: Jeff Xu <jeffxu@chromium.org>
>
> add include linux/mman.h to fix arm build
> fix a typo
>
> Signed-off-by: Jeff Xu <jeffxu@chromium.org>
> Suggested-by: Ryan Roberts <ryan.roberts@arm.com>
I confirm this has fixed our issue. Thanks!
Tested-by: Ryan Roberts <ryan.roberts@arm.com>
Reviewed-by: Ryan Roberts <ryan.roberts@arm.com>
> ---
> tools/testing/selftests/mm/mseal_test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c
> index ca8dbee0c612..41998cf1dcf5 100644
> --- a/tools/testing/selftests/mm/mseal_test.c
> +++ b/tools/testing/selftests/mm/mseal_test.c
> @@ -1,5 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> #define _GNU_SOURCE
> +#include <linux/mman.h>
> #include <sys/mman.h>
> #include <stdint.h>
> #include <unistd.h>
> @@ -29,7 +30,7 @@
> # define PKEY_DISABLE_WRITE 0x2
> #endif
>
> -#ifndef PKEY_BITS_PER_KEY
> +#ifndef PKEY_BITS_PER_PKEY
> #define PKEY_BITS_PER_PKEY 2
> #endif
>
prev parent reply other threads:[~2024-05-03 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 22:53 [PATCH v1 0/1] selftest/mseal fix arm build jeffxu
2024-05-02 22:53 ` [PATCH v1 1/1] selftest mm/mseal: " jeffxu
2024-05-03 11:00 ` Ryan Roberts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f90431c-f27d-4b59-bf5a-32fd66101230@arm.com \
--to=ryan.roberts@arm.com \
--cc=Aishwarya.TCV@arm.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=dave.hansen@intel.com \
--cc=deraadt@openbsd.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=jannh@google.com \
--cc=jeffxu@chromium.org \
--cc=jeffxu@google.com \
--cc=jorgelo@chromium.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=merimus@google.com \
--cc=pedro.falcato@gmail.com \
--cc=rdunlap@infradead.org \
--cc=sroettger@google.com \
--cc=surenb@google.com \
--cc=torvalds@linux-foundation.org \
--cc=usama.anjum@collabora.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).