From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8313DC25B74 for ; Tue, 14 May 2024 02:37:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D60916B02EC; Mon, 13 May 2024 22:37:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0FF86B02ED; Mon, 13 May 2024 22:37:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD7F26B02EE; Mon, 13 May 2024 22:37:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9E7266B02EC for ; Mon, 13 May 2024 22:37:50 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DDB79C0FAB for ; Tue, 14 May 2024 02:37:49 +0000 (UTC) X-FDA: 82115441058.16.DC70CFA Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf11.hostedemail.com (Postfix) with ESMTP id 161CE40005 for ; Tue, 14 May 2024 02:37:47 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YkPHzn59; spf=pass (imf11.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715654268; a=rsa-sha256; cv=none; b=1D51F+ncDMa74qWpraOlye6J0vYKALEp/adyvFfh33SypsrDz3OsIN1zlzc+WL1nfN57zY uwk0bSuGbL4pJBwJVrEVpgPx2OcJTiaKtboj/o7R7zYfOHxeW8qDsv/YJx86rPMhJ5v95j clSK5gklvh8dDFlbY0m/+mMhSto8ypg= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YkPHzn59; spf=pass (imf11.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715654268; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OYzw8FYz26q93IeZfDcCF7zSochl7yn4cVs5hUQhg0w=; b=40Mvjn62GwHsUzYO4JtaoMlJv538B/nmCbMAeJhpaFDaPzM7b3s5DOVg/Dx7uweYlKPMg9 9Q/mruL70Sw9kFP9cVGsGdFgDrRuf8oGn9SvJ5hBgkZJ0cgbb+7T9srfPN5mBAYzgXK4g2 4xYLJ3fAWDCXBAmK/+vozTsBG5Bf1IU= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-51aa6a8e49aso6940823e87.3 for ; Mon, 13 May 2024 19:37:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715654266; x=1716259066; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OYzw8FYz26q93IeZfDcCF7zSochl7yn4cVs5hUQhg0w=; b=YkPHzn59FDle4uYZyleD4qp7ATyr02rY9Lt1ARGlzVUk+9cwPnQNPp6UDbrkoV9rAm qy5zCGlgpFHGz8xmyeSlqrSuTvGBSwtjGSF+3o3g2km3iCP/m3Ou/UZQ8hYXUoRapG9S BAyLSjdA7DD36xbCUsgy77toj5ge+P5QqG0EEuWnx7jbZtbopOV7JNFDnXjnTZO+Cz9Q 0oqKgOKETh7SMEwIGYpw3LgNSij85y/nD/9u2B9cnvP52/d6+OIeYmllGifua/5LFS9w vopOIs5oON/FT1YJaR3ugiO7k2ylwRiNCqI4X6pony7dxVzM9QA43+g7MyLqG7qzmO6+ wGRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715654266; x=1716259066; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OYzw8FYz26q93IeZfDcCF7zSochl7yn4cVs5hUQhg0w=; b=pkvdPS+MeTKPY5kwppAKcsZSpHgOGL7xh9ozmP9FE2MnrXsUmfI6DeW1HUrFgEZvDH 7IdBBYihdItLj1f4GX/o0E9DVwQFSVzcelqXidunISPQdpCYYWyYDKyEHkn3PpoL3eG3 r7S5oI1cI6HeXMwGL48qjKw7jZkksllIvyT88PLphEAznEpMbZTz4HGGvndsqidQ0GIS EqswT/kJwpdq7Sl+rHhBmK6QHVb6yBer5iS5hdYdIfuxcOKw2iJ/K5SKAJ3GGgEePZHt YMgzyBGbqGP0+n1lwy4CFi/kTotzgJjNtlPo301VBcmhQnko42QMBG01xpPla69C8gGC I4Zg== X-Forwarded-Encrypted: i=1; AJvYcCXR4pTIoi+0Jl0CObtXwV3wOT+PCH1mPy+ODqUwUZLdt/xlBN4pE2PzfwY2Ns6O4gk99+m/bozAsfiH6nZ/b1HFS0s= X-Gm-Message-State: AOJu0YxYUe9C7rZkenHWuNWPyCpIIjNXRd06Pt1dYL4cYRq7eKRO+4TF JNYYNn0mGTFGz3zoeexszCVGFamJO3u3Q4JYGod/N2sk4GGdA2+xWxHSHP9S3I8fvIxBwzXbWbJ eDCC29VkB9zzqgSVkDGt44WG9i9w= X-Google-Smtp-Source: AGHT+IFNDspAwtyzoDLuNze7g9mcZhGYAjP0GU2W7ymEHWo1OP7lcHugnImIwqWWiKNTUnOO1zZoCH3B7ZuG5lEgDsE= X-Received: by 2002:a05:6512:1c8:b0:51c:3e9e:98ee with SMTP id 2adb3069b0e04-5220fb6b067mr6954023e87.23.1715654265932; Mon, 13 May 2024 19:37:45 -0700 (PDT) MIME-Version: 1.0 References: <20240509023937.1090421-1-zhaoyang.huang@unisoc.com> <20240509023937.1090421-3-zhaoyang.huang@unisoc.com> In-Reply-To: From: Zhaoyang Huang Date: Tue, 14 May 2024 10:37:34 +0800 Message-ID: Subject: Re: [RFC PATCH 2/2] mm: introduce budgt control in readahead To: Matthew Wilcox Cc: "zhaoyang.huang" , Andrew Morton , Jens Axboe , Tejun Heo , Josef Bacik , Baolin Wang , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, steve.kang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 161CE40005 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: 5h7xbgpructhoraerxjki3eknhaa6iq7 X-HE-Tag: 1715654267-387133 X-HE-Meta: U2FsdGVkX18NJtigGpi9oHabRCEZ0FWFHvNei8u8NkTBSvdOyWJQF1uVut4VOnPKrhaU/jo08qMuHJZZ91nFDSyrd1sfgb9otBMjDthNUSjPd0iUqfbdHrNUL9AaxIwsixDPzRwfLHnf9v+Ypm6WNYmef/Qte3H5u+7tQ7J3s6s3yavqR0biWGf7IalIyw+58+eHT1XLx7Ek7zC97f/AUma2X0aXFqTcwNDGFT03rohZCU5hyPm3tJAZ0R1aV2+irHn/bqehla6xPpUa8L05HG7p9ZYLDNewntlAtm7oR9RMPVqlorNNUyJz7OQncwn++H5+S8TnV1BUPp5szw0SnRHkCQAe38avYrUDSApvSdT/jqy67c55pOobvUd9ElWd+AX+E81Q+LWyc8NNsfjHJTpDvoPN31oRnVoM4vXJDFUIKdQb2GQceIgrj5owNI3H9Aaz7Zu6WOLT1gRpma7K2Q+HkoZhGMFGzL6dxgRcFBq9thrWpTFq9qALYONws+Rm4ERcyrJwolfKb3DbXhlDTHjn/z4J10cMfQilZo1too9U6N8zMFQf5uBuWVZXSCbIPxT4eK4h8I9suOL+T5y3Yucrt3XJCv0udYZ3judzFv7lBTrtn5T38h4Zkl8+/LytoFStEzafN4Olr9DSEFXYAf2w4iLv9o4g/Wn2S4HY2khpzZ2p183DAB06tHd7IgfD26sM6oMrZNYCX5Zm3giQ1+7rFE7ET5zfGBVlI1gQdu/1JWzdudG2LypBtBl26R48Fge1BpxTXred5SI3miYSrw05JBh59yVCFZFuMsmBXLXbFe6AONME8k7AVD5RcCciotjs0Ln4oWlz+ys/1Gmol/pTVvdSaEEWtQB0E3gsDDLAtbN/mxzNIsqOL92nczRaXgz1/cfepFz6cywWyQHKea/4FkaFWD9eR7XVJ4+lzygl+qU/sCWOfCcBV83hp3woBtrLscs9+JWVUDwBng9 P3x45te0 pGmcVELNyLf6rEs/e+khySs0HVFmrJm+GDSMnuD8oOMyoFWVzPN8IQEek+QArxwHv75v4yq9dnApkBaWd36hwuGM128CVy4+UW7i+uauRrfK3iiI2GCJwfQxqTI2/gCfqPndfSGdtT7VxymgJJ9bJOPQ7oqEGI7i0X3H1OFIHK7Jkhxr1rjgdDZfoindByair7oIM0dUD9650t7tIXxDnE3CNdUaUs4lHX98ZX4gArVYZQKO8nGlsou07p0P9TRFq9fF+4+CwWRRGD80r3NcGdERfw2uJm4j6MglnZS3uuxKeDzIEcianai1M8ok7hEl/3nyA+ortly3HmXpgk6p5gU+iP0bHEiBRhgW9KYVfMOp1ofvuIhytiEpReGcA6j1jYX/O6xRu4OSQwGnsQRWIfLNPEgP8HIQVGqXW2PHVLg3pqjFGK9qyuBWR7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, May 11, 2024 at 3:35=E2=80=AFPM Zhaoyang Huang wrote: > > On Fri, May 10, 2024 at 11:18=E2=80=AFAM Matthew Wilcox wrote: > > > > On Fri, May 10, 2024 at 10:43:20AM +0800, Zhaoyang Huang wrote: > > > Thanks for the prompt. I did some basic research on soft RAID and > > > wonder if applying the bps limit on /dev/md0 like below could make > > > this work. > > > > No. Look at btrfs' raid support, for example. it doesn't use md0. > If I understand the below command correctly, btrfs uses one of the > volumes within RAID as the mount block device, not /dev/md0. However, > I think this is a problem of blkio.throttle rather than this commit > which means this readahead budget control will work accordingly as > long as blkio.throttle's parameter is configured correctly(eg. 50/50 > on sdb and sdc) > > mkfs.btrfs -m raid0 -d raid0 /dev/sdb /dev/sdc > mount -t btrfs /dev/sdb /mnt/btr > > > > > > > > I didn't find information about 'RAID internally'. Could we set the > > > limit on the root device(the one used for mount) to manage the whole > > > partition without caring about where the bio finally goes? Or ask the > > > user to decide if to use by making sure the device they apply will no= t > > > do RAID? > > > > No. @all, Please find below for more test results where we can find this commit has the result meet the desired value more closely and enhance it by 3% than mainline. echo "254:48 20000000" > blkio.throttle.read_bps_device fio -filename=3D/data/ylog/ap/000-0101_000015_poweron.ylog -rw=3Dread -direct=3D0 -bs=3D4k -size=3D2000M -numjobs=3D8 -group_reporting -name=3Dmy= test before : IOPS=3D37.9k, BW=3D148MiB/s (155MB/s)(11.6GiB/80333msec) after : IOPS=3D39.0k, BW=3D153MiB/s (160MB/s)(15.6GiB/104914msec) before : clat (usec): min=3D4, max=3D1056.6k, avg=3D197.23, stdev=3D100= 80.69 after : clat (usec): min=3D4, max=3D193481, avg=3D188.83, stdev=3D4651= .29 before : lat (usec): min=3D5, max=3D1056.6k, avg=3D200.48, stdev=3D1008= 0.76 after : lat (usec): min=3D5, max=3D193483, avg=3D192.68, stdev=3D4651.= 87 echo "254:48 30000000" > blkio.throttle.read_bps_device fio -filename=3D/data/ylog/ap/000-0101_000015_poweron.ylog -rw=3Dread -direct=3D0 -bs=3D4k -size=3D2000M -numjobs=3D8 -group_reporting -name=3Dmy= test before : IOPS=3D57.2k, BW=3D224MiB/s (234MB/s)(15.6GiB/71561msec) after : IOPS=3D58.5k, BW=3D229MiB/s (240MB/s)(15.6GiB/69996msec) before : clat (usec): min=3D4, max=3D1105.5k, avg=3D126.20, stdev=3D641= 9.22 after : clat (usec): min=3D4, max=3D183956, avg=3D120.60, stdev=3D2957= .28 before : lat (usec): min=3D5, max=3D1105.5k, avg=3D129.45, stdev=3D6419= .29 after : lat (usec): min=3D5, max=3D183958, avg=3D124.40, stdev=3D2958.= 18