Linux-mm Archive mirror
 help / color / mirror / Atom feed
From: Yosry Ahmed <yosryahmed@google.com>
To: Usama Arif <usamaarif642@gmail.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, nphamcs@gmail.com,
	 chengming.zhou@linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,  kernel-team@meta.com
Subject: Re: [PATCH v2 0/1] cgroup: remove redundant addition of memory controller
Date: Thu, 2 May 2024 19:09:36 -0700	[thread overview]
Message-ID: <CAJD7tkYwAQQB_90S8_6YiAq-j3Ew0KKK+a4gnBn2XD+8ocnG4A@mail.gmail.com> (raw)
In-Reply-To: <20240502200529.4193651-1-usamaarif642@gmail.com>

On Thu, May 2, 2024 at 1:05 PM Usama Arif <usamaarif642@gmail.com> wrote:
>
> Memory controller is already added in main which invokes
> the test, hence this does not need to be done in
> test_no_kmem_bypass.

A cover letter is not required. In cases like this where providing
additional context to the commit log is not needed, it is better to
omit it. This especially applies when there is a single patch in the
series.

If you want to add version diff info or any additional context, you
can add it after "---" in the patch itself. Example:
https://lore.kernel.org/linux-mm/20240430133138.732088-1-ryan.roberts@arm.com/.

>
> v1 -> v2:
> - Add more description to commit message.
>
> Usama Arif (1):
>   selftests: cgroup: remove redundant addition of memory controller
>
>  tools/testing/selftests/cgroup/test_zswap.c | 2 --
>  1 file changed, 2 deletions(-)
>
> --
> 2.43.0
>


      parent reply	other threads:[~2024-05-03  2:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-02 20:04 [PATCH v2 0/1] cgroup: remove redundant addition of memory controller Usama Arif
2024-05-02 20:04 ` [PATCH v2 1/1] selftests: " Usama Arif
2024-05-03  2:06   ` Yosry Ahmed
2024-05-03  2:09 ` Yosry Ahmed [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJD7tkYwAQQB_90S8_6YiAq-j3Ew0KKK+a4gnBn2XD+8ocnG4A@mail.gmail.com \
    --to=yosryahmed@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=chengming.zhou@linux.dev \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=usamaarif642@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).