From: Allen <allen.lkml@gmail.com>
To: Kees Cook <keescook@chromium.org>
Cc: linux-fsdevel@vger.kernel.org,
Allen Pais <apais@linux.microsoft.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
ebiederm@xmission.com, mcgrof@kernel.org,
j.granados@samsung.com
Subject: Re: [PATCH v4] fs/coredump: Enable dynamic configuration of max file note size
Date: Tue, 7 May 2024 10:13:30 -0700 [thread overview]
Message-ID: <CAOMdWS+u5gBpkJyryge5mWt-eX6+OmkiSkS5zc-VZ=_uJQszLw@mail.gmail.com> (raw)
In-Reply-To: <171510137055.3977159.13112533071742599257.b4-ty@chromium.org>
> On Mon, 06 May 2024 19:37:00 +0000, Allen Pais wrote:
> > Introduce the capability to dynamically configure the maximum file
> > note size for ELF core dumps via sysctl.
> >
> > Why is this being done?
> > We have observed that during a crash when there are more than 65k mmaps
> > in memory, the existing fixed limit on the size of the ELF notes section
> > becomes a bottleneck. The notes section quickly reaches its capacity,
> > leading to incomplete memory segment information in the resulting coredump.
> > This truncation compromises the utility of the coredumps, as crucial
> > information about the memory state at the time of the crash might be
> > omitted.
> >
> > [...]
>
> I adjusted file names, but put it in -next. I had given some confusing
> feedback on v3, but I didn't realize until later; apologies for that! The
> end result is the sysctl is named kernel.core_file_note_size_limit and
> the internal const min/max variables have the _min and _max suffixes.
>
> Applied to for-next/execve, thanks!
>
> [1/1] fs/coredump: Enable dynamic configuration of max file note size
> https://git.kernel.org/kees/c/81e238b1299e
>
I should have put some thought into the feedback.
Thank you for reviewing and fixing the patch.
--
- Allen
prev parent reply other threads:[~2024-05-07 17:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 19:37 [PATCH v4] fs/coredump: Enable dynamic configuration of max file note size Allen Pais
2024-05-07 15:11 ` kernel test robot
2024-05-07 16:36 ` Allen
2024-05-07 16:55 ` kernel test robot
2024-05-07 17:02 ` Kees Cook
2024-05-07 17:13 ` Allen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMdWS+u5gBpkJyryge5mWt-eX6+OmkiSkS5zc-VZ=_uJQszLw@mail.gmail.com' \
--to=allen.lkml@gmail.com \
--cc=apais@linux.microsoft.com \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=j.granados@samsung.com \
--cc=jack@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).