* Re: [PATCH v3] mm/migrate_device: Try to handle swapcache pages
[not found] <20230606050149.25699-1-mpenttil@redhat.com>
@ 2023-06-07 14:10 ` Christoph Hellwig
2023-06-07 15:56 ` Mika Penttilä
2023-06-07 16:06 ` Mika Penttilä
0 siblings, 2 replies; 4+ messages in thread
From: Christoph Hellwig @ 2023-06-07 14:10 UTC (permalink / raw
To: mpenttil
Cc: linux-kernel, linux-mm, Alistair Popple, John Hubbard,
Ralph Campbell, Huang, Ying
On Tue, Jun 06, 2023 at 08:01:49AM +0300, mpenttil@redhat.com wrote:
> From: Mika Penttilä <mpenttil@redhat.com>
>
> Migrating file pages and swapcache pages into device memory is not supported.
> The decision is done based on page_mapping(). For now, swapcache pages are not migrated.
Please fix the commit log formatting, it should not exceed 7 lines.
> if (is_device_private_page(newpage) ||
> is_device_coherent_page(newpage)) {
> - /*
> - * For now only support anonymous memory migrating to
> - * device private or coherent memory.
> - */
> +
> if (mapping) {
Very nitpicky, but this empty line looks odd. Also isn't the comment
still (mostly) correct given that file backed memory is still not
supported?
> + /*
> + * For now only support anonymous memory migrating to
> + * device private or coherent memory.
> + *
> + * Try to get rid of swap cache if possible.
> + *
> + */
> + if (!folio_test_anon(folio) || !folio_free_swap(folio)) {
Please avoid the overly long lines.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] mm/migrate_device: Try to handle swapcache pages
2023-06-07 14:10 ` [PATCH v3] mm/migrate_device: Try to handle swapcache pages Christoph Hellwig
@ 2023-06-07 15:56 ` Mika Penttilä
2023-06-07 16:06 ` Mika Penttilä
1 sibling, 0 replies; 4+ messages in thread
From: Mika Penttilä @ 2023-06-07 15:56 UTC (permalink / raw
To: Christoph Hellwig
Cc: linux-kernel, linux-mm, Alistair Popple, John Hubbard,
Ralph Campbell, Huang, Ying
Hi,
On 7.6.2023 17.10, Christoph Hellwig wrote:
> On Tue, Jun 06, 2023 at 08:01:49AM +0300, mpenttil@redhat.com wrote:
>> From: Mika Penttilä <mpenttil@redhat.com>
>>
>> Migrating file pages and swapcache pages into device memory is not supported.
>> The decision is done based on page_mapping(). For now, swapcache pages are not migrated.
>
> Please fix the commit log formatting, it should not exceed 7 lines.
>
>> if (is_device_private_page(newpage) ||
>> is_device_coherent_page(newpage)) {
>> - /*
>> - * For now only support anonymous memory migrating to
>> - * device private or coherent memory.
>> - */
>> +
>> if (mapping) {
>
> Very nitpicky, but this empty line looks odd. Also isn't the comment
> still (mostly) correct given that file backed memory is still not
> supported?
Yes the comment is mostly correct and moved a few lines lower,
complemented with a comment about the swap cache.
>
>> + /*
>> + * For now only support anonymous memory migrating to
>> + * device private or coherent memory.
>> + *
>> + * Try to get rid of swap cache if possible.
>> + *
>> + */
>> + if (!folio_test_anon(folio) || !folio_free_swap(folio)) {
>
> Please avoid the overly long lines.
>
Thanks,
Mika
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] mm/migrate_device: Try to handle swapcache pages
2023-06-07 14:10 ` [PATCH v3] mm/migrate_device: Try to handle swapcache pages Christoph Hellwig
2023-06-07 15:56 ` Mika Penttilä
@ 2023-06-07 16:06 ` Mika Penttilä
2023-06-12 4:53 ` Christoph Hellwig
1 sibling, 1 reply; 4+ messages in thread
From: Mika Penttilä @ 2023-06-07 16:06 UTC (permalink / raw
To: Christoph Hellwig
Cc: linux-kernel, linux-mm, Alistair Popple, John Hubbard,
Ralph Campbell, Huang, Ying
On 7.6.2023 17.10, Christoph Hellwig wrote:
> On Tue, Jun 06, 2023 at 08:01:49AM +0300, mpenttil@redhat.com wrote:
>> From: Mika Penttilä <mpenttil@redhat.com>
>>
>> Migrating file pages and swapcache pages into device memory is not supported.
>> The decision is done based on page_mapping(). For now, swapcache pages are not migrated.
>
> Please fix the commit log formatting, it should not exceed 7 lines.
Not sure what you mean should not exceed 7 lines..?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] mm/migrate_device: Try to handle swapcache pages
2023-06-07 16:06 ` Mika Penttilä
@ 2023-06-12 4:53 ` Christoph Hellwig
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2023-06-12 4:53 UTC (permalink / raw
To: Mika Penttilä
Cc: Christoph Hellwig, linux-kernel, linux-mm, Alistair Popple,
John Hubbard, Ralph Campbell, Huang, Ying
On Wed, Jun 07, 2023 at 07:06:06PM +0300, Mika Penttilä wrote:
>
>
> On 7.6.2023 17.10, Christoph Hellwig wrote:
> > On Tue, Jun 06, 2023 at 08:01:49AM +0300, mpenttil@redhat.com wrote:
> > > From: Mika Penttilä <mpenttil@redhat.com>
> > >
> > > Migrating file pages and swapcache pages into device memory is not supported.
> > > The decision is done based on page_mapping(). For now, swapcache pages are not migrated.
> >
> > Please fix the commit log formatting, it should not exceed 7 lines.
>
> Not sure what you mean should not exceed 7 lines..?
Sorry, this should be 73.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-12 4:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230606050149.25699-1-mpenttil@redhat.com>
2023-06-07 14:10 ` [PATCH v3] mm/migrate_device: Try to handle swapcache pages Christoph Hellwig
2023-06-07 15:56 ` Mika Penttilä
2023-06-07 16:06 ` Mika Penttilä
2023-06-12 4:53 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).