From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kernel test robot <lkp@intel.com>, Song Liu <song@kernel.org>,
oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [akpm-mm:mm-nonmm-unstable 80/82] kernel/watchdog_perf.c:282: warning: Function parameter or struct member 'str' not described in 'hardlockup_config_perf_event'
Date: Sat, 4 May 2024 23:47:08 +0100 [thread overview]
Message-ID: <Zja67MQWDTh6JpNw@casper.infradead.org> (raw)
In-Reply-To: <20240504154455.2ddd2cbc523698a270cca9c2@linux-foundation.org>
On Sat, May 04, 2024 at 03:44:55PM -0700, Andrew Morton wrote:
> +++ a/kernel/watchdog_perf.c
> @@ -277,6 +277,8 @@ int __init watchdog_hardlockup_probe(voi
>
> /**
> * hardlockup_config_perf_event - Overwrite config of wd_hw_attr.
> + *
> + * @str: number which identifies the raw perf event to use
> */
> void __init hardlockup_config_perf_event(const char *str)
We don't usually put a blank line between the name of the function and
the arguments, but other than that, looks good.
prev parent reply other threads:[~2024-05-04 22:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 0:38 [akpm-mm:mm-nonmm-unstable 80/82] kernel/watchdog_perf.c:282: warning: Function parameter or struct member 'str' not described in 'hardlockup_config_perf_event' kernel test robot
2024-05-04 22:44 ` Andrew Morton
2024-05-04 22:47 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zja67MQWDTh6JpNw@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).